View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024355 | Open CASCADE | OCCT:Samples | public | 2013-11-13 17:12 | 2013-12-19 13:59 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.7.0 | Fixed in Version | 6.7.0 | ||
| Summary | 0024355: Compiler Warning level 4 for MFC samples | ||||
| Description | All Visual Studio projects of MFC samples are required to be updated: 1. change compiler warning level: 4 level is required 2. fixed all warnings within projects that appeared after compiler warning level changing | ||||
| Steps To Reproduce | folders of projects of all versions: <occt root>/samples/mfc/standard/<sample name>/adm/win/vc8 vc9 vc10 vc11 | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
| related to | 0023874 | closed | Converting OCCT MFC samples to CMake build system. |
|
|
some warnings have been removed; changes have been committed to CR24355 branch |
|
|
Level 4 warnings of sample projects were fixed on VC9. Changes are located in branch CR24355. Please, review. |
|
|
Changes in samples/mfc/standard/03_Viewer2d/src/Viewer2dDoc.cpp and samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp actually disable part of functionality (reading files), please restore. Warnings related to passing reference to temporary objects could better be eliminated by appropriate change of the parameter of the relevant methods (make reference "const"). Methods SetTitle() and SetText() in dialog classes can be complemented by variants accepting C string, this would allow passing string literals "as is", without any conversions. Note that I pushed one more commit in this branch enabling warning lever W4 in all VS projects of MFC samples, and adding Readme on samples to OCCT docs. |
|
|
>Changes in samples/mfc/standard/03_Viewer2d/src/Viewer2dDoc.cpp >samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp my bad... |
|
|
Remarks were applied. Changes are located in branch CR24355. Please, review. |
|
|
Well done! no remarks, please test |
|
|
There are no warnings in MFC samples in all versions (vc8 vc9 vc10 vc11). Samples work correctly. |
|
occt: master 5c573e69 2013-11-21 09:44:27
Committer: bugmaster Details Diff |
0024355: Compiler Warning level 4 for MFC samples Some warnings were removed from MFC samples All warnings of sample projects with warning level 4 were fixed on VC9 Warnings level increased to -W4 in projects of MFC samples; sample ReadMe files added to documentation Changes in Viewer2dDoc.cpp and OcafDoc.cpp were restored. Minor corrections in documentation |
Affected Issues 0024355 |
|
| mod - dox/dev_guides/building/cmake/cmake.md | Diff File | ||
| mod - dox/FILES.txt | Diff File | ||
| mod - dox/overview/Overview.md | Diff File | ||
| mod - samples/CSharp/ReadMe.md | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/adm/win/vc10/Geometry.vcxproj | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/adm/win/vc11/Geometry.vcxproj | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/adm/win/vc8/Geometry.vcproj | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/adm/win/vc9/Geometry.vcproj | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/GeometryDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/GeometryView.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/GeometryView2D.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/GeomSources.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/GeomSources.h | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession2D_Curve.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Curve.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Direction.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Direction.h | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Point.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Point.h | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Surface.cpp | Diff File | ||
| mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Text.cpp | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/adm/win/vc10/Modeling.vcxproj | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/adm/win/vc11/Modeling.vcxproj | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/adm/win/vc8/Modeling.vcproj | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/adm/win/vc9/Modeling.vcproj | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/src/ISession_Direction.cpp | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/src/ISession_Direction.h | Diff File | ||
| mod - samples/mfc/standard/02_Modeling/src/ModelingDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/adm/win/vc10/Viewer2d.vcxproj | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/adm/win/vc11/Viewer2d.vcxproj | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/adm/win/vc8/Viewer2d.vcproj | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/adm/win/vc9/Viewer2d.vcproj | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/src/Viewer2dDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/adm/win/vc10/Viewer3d.vcxproj | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/adm/win/vc11/Viewer3d.vcxproj | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/adm/win/vc8/Viewer3d.vcproj | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/adm/win/vc9/Viewer3d.vcproj | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/src/ISession_Curve.cpp | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/src/OffsetDlg.cpp | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/src/Viewer3dDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/04_Viewer3d/src/Viewer3dView.cpp | Diff File | ||
| mod - samples/mfc/standard/05_ImportExport/adm/win/vc10/ImportExport.vcxproj | Diff File | ||
| mod - samples/mfc/standard/05_ImportExport/adm/win/vc11/ImportExport.vcxproj | Diff File | ||
| mod - samples/mfc/standard/05_ImportExport/adm/win/vc8/ImportExport.vcproj | Diff File | ||
| mod - samples/mfc/standard/05_ImportExport/adm/win/vc9/ImportExport.vcproj | Diff File | ||
| mod - samples/mfc/standard/05_ImportExport/src/FSD_Archive.cxx | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/adm/win/vc10/Ocaf.vcxproj | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/adm/win/vc11/Ocaf.vcxproj | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/adm/win/vc8/Ocaf.vcproj | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/adm/win/vc9/Ocaf.vcproj | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_BoxDriver.cxx | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_CutDriver.cxx | Diff File | ||
| mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_CylDriver.cxx | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/adm/win/vc10/Triangulation.vcxproj | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/adm/win/vc11/Triangulation.vcxproj | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/adm/win/vc8/Triangulation.vcproj | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/adm/win/vc9/Triangulation.vcproj | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/src/ISession_Curve.cpp | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/src/Tesselate_Presentation.cpp | Diff File | ||
| mod - samples/mfc/standard/07_Triangulation/src/TriangulationDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/08_HLR/adm/win/vc10/HLR.vcxproj | Diff File | ||
| mod - samples/mfc/standard/08_HLR/adm/win/vc11/HLR.vcxproj | Diff File | ||
| mod - samples/mfc/standard/08_HLR/adm/win/vc8/HLR.vcproj | Diff File | ||
| mod - samples/mfc/standard/08_HLR/adm/win/vc9/HLR.vcproj | Diff File | ||
| mod - samples/mfc/standard/08_HLR/src/HLRView2D.cpp | Diff File | ||
| mod - samples/mfc/standard/09_Animation/adm/win/vc10/Animation.vcxproj | Diff File | ||
| mod - samples/mfc/standard/09_Animation/adm/win/vc11/Animation.vcxproj | Diff File | ||
| mod - samples/mfc/standard/09_Animation/adm/win/vc8/Animation.vcproj | Diff File | ||
| mod - samples/mfc/standard/09_Animation/adm/win/vc9/Animation.vcproj | Diff File | ||
| mod - samples/mfc/standard/09_Animation/src/AnimationDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/09_Animation/src/AnimationView3D.cpp | Diff File | ||
| mod - samples/mfc/standard/09_Animation/src/Fonc.cxx | Diff File | ||
| mod - samples/mfc/standard/10_Convert/adm/win/vc10/Convert.vcxproj | Diff File | ||
| mod - samples/mfc/standard/10_Convert/adm/win/vc11/Convert.vcxproj | Diff File | ||
| mod - samples/mfc/standard/10_Convert/adm/win/vc8/Convert.vcproj | Diff File | ||
| mod - samples/mfc/standard/10_Convert/adm/win/vc9/Convert.vcproj | Diff File | ||
| mod - samples/mfc/standard/10_Convert/src/ISession/ISession_Curve.cpp | Diff File | ||
| mod - samples/mfc/standard/10_Convert/src/WNT/OCCDemoView.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/DimensionDlg.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/ImportExport/ImportExport.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/ISession2D/ISession2D_Shape.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/ISession2D/ISession2D_Shape.h | Diff File | ||
| mod - samples/mfc/standard/Common/OCC_2dView.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/OCC_3dBaseDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/OCC_3dDoc.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/OCC_3dView.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/OCC_BaseDoc.h | Diff File | ||
| mod - samples/mfc/standard/Common/Primitive/Sample2D_Face.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/Primitive/Sample2D_Markers.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/Primitive/Sample2D_Markers.h | Diff File | ||
| mod - samples/mfc/standard/Common/Primitive/Sample2D_Text.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/Primitive/Sample2D_Text.h | Diff File | ||
| mod - samples/mfc/standard/Common/ResultDialog.cpp | Diff File | ||
| mod - samples/mfc/standard/Common/ResultDialog.h | Diff File | ||
| mod - samples/mfc/standard/Common/User_Cylinder.cxx | Diff File | ||
| mod - samples/mfc/standard/mfcsample/adm/win/vc10/mfcsample.vcxproj | Diff File | ||
| mod - samples/mfc/standard/mfcsample/adm/win/vc11/mfcsample.vcxproj | Diff File | ||
| mod - samples/mfc/standard/mfcsample/adm/win/vc8/mfcsample.vcproj | Diff File | ||
| mod - samples/mfc/standard/mfcsample/adm/win/vc9/mfcsample.vcproj | Diff File | ||
| mod - samples/mfc/standard/mfcsample/src/mfcsample.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-11-13 17:12 |
|
New Issue | |
| 2013-11-13 17:12 |
|
Assigned To | => bugmaster |
| 2013-11-13 17:15 |
|
Assigned To | bugmaster => ski |
| 2013-11-13 17:15 |
|
Status | new => assigned |
| 2013-11-13 17:16 |
|
Relationship added | related to 0023874 |
| 2013-11-14 14:30 |
|
Note Added: 0026625 | |
| 2013-11-14 18:58 |
|
Note Added: 0026635 | |
| 2013-11-14 18:58 |
|
Assigned To | ski => abv |
| 2013-11-14 18:58 |
|
Status | assigned => resolved |
| 2013-11-15 09:59 |
|
Note Added: 0026640 | |
| 2013-11-15 09:59 |
|
Assigned To | abv => ski |
| 2013-11-15 09:59 |
|
Status | resolved => assigned |
| 2013-11-15 10:12 |
|
Note Added: 0026641 | |
| 2013-11-15 10:13 |
|
Note Edited: 0026641 | |
| 2013-11-15 13:42 |
|
Note Added: 0026653 | |
| 2013-11-15 13:42 |
|
Assigned To | ski => abv |
| 2013-11-15 13:42 |
|
Status | assigned => resolved |
| 2013-11-15 15:56 |
|
Note Added: 0026662 | |
| 2013-11-15 15:56 |
|
Assigned To | abv => bugmaster |
| 2013-11-15 15:56 |
|
Status | resolved => reviewed |
| 2013-11-15 16:42 | apn | Assigned To | bugmaster => apn |
| 2013-11-19 16:00 | apn | Note Added: 0026757 | |
| 2013-11-19 16:09 | apn | Note Edited: 0026757 | |
| 2013-11-19 16:09 | apn | Test case number | => Not needed |
| 2013-11-19 16:09 | apn | Assigned To | apn => bugmaster |
| 2013-11-19 16:09 | apn | Status | reviewed => tested |
| 2013-11-25 13:17 | bugmaster | Changeset attached | => occt master 5c573e69 |
| 2013-11-25 13:17 | bugmaster | Status | tested => verified |
| 2013-11-25 13:17 | bugmaster | Resolution | open => fixed |
| 2013-12-19 13:50 | bugmaster | Status | verified => closed |
| 2013-12-19 13:59 | bugmaster | Fixed in Version | => 6.7.0 |
| 2014-01-11 11:59 |
|
Category | OCCT Release:MFC => OCCT Release:Samples |
| 2014-01-11 12:02 |
|
Category | OCCT Release:Samples => OCCT:Samples |
