View Issue Details

IDProjectCategoryView StatusLast Update
0023874Open CASCADEOCCT:Samplespublic2013-12-19 13:59
ReportersdvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.7.0Fixed in Version6.7.0 
Summary0023874: Converting OCCT MFC samples to CMake build system.
DescriptionSee subject.
TagsNo tags attached.
Test case number

Relationships

related to 0024355 closedbugmaster Compiler Warning level 4 for MFC samples 

Activities

sdv

2013-04-05 11:37

developer   ~0024009

CMake-build system has been implemented instead of multiple VS projects (one per version as we have currently).

ibs

2013-06-24 16:46

developer   ~0024844

RUNTIME_OUTPUT_DIRECTORY_DEBUG ${OCC_SAMPLES_OUTPUT_PATH}/libd
RUNTIME_OUTPUT_DIRECTORY_RELEASE ${OCC_SAMPLES_OUTPUT_PATH}/libd

Dear sdv, can you explain to me why do you decide to put debug and release versions of project in libd directory? or is it just misprint?

sdv

2013-06-25 10:09

developer   ~0024855

Dear Ivan, it is a mistake. I have found another problem.
In the upper level of CMake-file
# add mfcsamples.lib
link_directories( ${LIBRARY_OUTPUT_PATH}/libd )
I suppose it should be depend on build mode.

ibs

2013-06-25 11:56

developer   ~0024858

Ok, i'll fix

sdv

2013-06-25 12:05

developer   ~0024859

Thanks

ibs

2013-06-25 16:39

developer   ~0024862

Last edited: 2013-06-25 16:40

may be we do some changes:

  1. move main CMakeLists.txt to root: <occt>\samples\mfc\standard
  2. move each sample CMakeLists.txt to their folders: <occt>\samples\mfc\standard\01_Geometry
  3. fill out env.bat and go.bat with path to OCCT libs and samples libs (occt root is predefined) in cmake generation process
  4. introduce choice of build mode in cmake configuration process (debug or release) due to the fact that we have to decide whether we use debug OCCT libraries or release OCCT libraries. this is a question...
  5. also we shouldn't forget about 3rdparty libraries using...

or may be... we integrate samples building into OCCT building? it will relieve us from defining occt libs path, 3rdparty path, e.t.c...

ibs

2013-06-28 11:50

developer   ~0024909

Last edited: 2013-06-28 12:08

was done in CR23874 branch of OCCT git: (for standard mfc samples)

 1. move main CMakeLists.txt to root: <occt>\samples\mfc\standard
 2. move each sample CMakeLists.txt to their folders
 3. leave go.bat and env.bat in "standard" folder
 4. introduce choice of build mode in cmake configuration process (debug or release)

important! currently, to run samples you have to use a generated env.bat in casroot folder (to know about all necessary paths): go.bat calls <casroot>/env.bat

it is required a conversation to develop an approach run the samples without any generated non-cmake scripts.

ibs

2013-07-01 15:29

developer   ~0024931

ibs should integrate samples option into main cmake meta-project of occt

ibs

2013-11-14 13:09

developer   ~0026624

all changes are committed to CR23874

abv

2013-11-14 16:34

manager   ~0026632

Tested with VS 2010 x64, please test / integrate

Related Changesets

occt: master 234e52be

2013-11-11 13:00:07

abv


Committer: abv Details Diff
0023874: Converting OCCT MFC samples to CMake build system.

CMake meta-projects for samples were added
launch script for samples was added
unrelated changes: CSF_GraphicShr variable were removed
occt building with cmake article was updated
Affected Issues
0023874
mod - adm/templates/env.bat.in Diff File
mod - adm/templates/env.sh.in Diff File
add - adm/templates/sample.bat Diff File
mod - CMakeLists.txt Diff File
mod - dox/dev_guides/building/cmake/cmake.md Diff File
add - samples/mfc/occtdemo/adm/cmake/Approx/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Chamfers/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Convert/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/DCA/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Extrema/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/GeomConstraints/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Glue/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/GProps/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/HLR/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Interpol/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Intersections/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/LProps/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Offset2d/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/PointOnCurve/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Primitives/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Projection/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Simplify/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/SplitShape/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Sweep/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Tesselate/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/TexturesExt/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/ThruSections/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Transform/CMakeLists.txt Diff File
add - samples/mfc/occtdemo/adm/cmake/Validate/CMakeLists.txt Diff File
add - samples/mfc/standard/01_Geometry/CMakeLists.txt Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession2D_Curve.cpp Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession2D_SensitiveCurve.cpp Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Curve.cpp Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Direction.cpp Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Point.cpp Diff File
mod - samples/mfc/standard/01_Geometry/src/ISession2D/ISession_Surface.cpp Diff File
add - samples/mfc/standard/02_Modeling/CMakeLists.txt Diff File
mod - samples/mfc/standard/02_Modeling/src/ModelingDoc.cpp Diff File
add - samples/mfc/standard/03_Viewer2d/CMakeLists.txt Diff File
add - samples/mfc/standard/04_Viewer3d/CMakeLists.txt Diff File
add - samples/mfc/standard/05_ImportExport/CMakeLists.txt Diff File
mod - samples/mfc/standard/05_ImportExport/src/ImportExportApp.cpp Diff File
add - samples/mfc/standard/06_Ocaf/CMakeLists.txt Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_BoxDriver.cxx Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_CutDriver.cxx Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcafFunction_CylDriver.cxx Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcaf_Application.cxx Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcaf_Commands.cxx Diff File
mod - samples/mfc/standard/06_Ocaf/src/TOcaf_Commands.hxx Diff File
add - samples/mfc/standard/07_Triangulation/CMakeLists.txt Diff File
add - samples/mfc/standard/08_HLR/CMakeLists.txt Diff File
mod - samples/mfc/standard/08_HLR/src/SelectionDialog.h Diff File
add - samples/mfc/standard/09_Animation/CMakeLists.txt Diff File
add - samples/mfc/standard/10_Convert/CMakeLists.txt Diff File
mod - samples/mfc/standard/Common/OCC_2dDoc.cpp Diff File
mod - samples/mfc/standard/Common/OCC_2dDoc.h Diff File
mod - samples/mfc/standard/Common/OCC_3dBaseDoc.cpp Diff File
mod - samples/mfc/standard/Common/OCC_3dBaseDoc.h Diff File
add - samples/mfc/standard/mfcsample/CMakeLists.txt Diff File

Issue History

Date Modified Username Field Change
2013-04-04 15:18 sdv New Issue
2013-04-04 15:18 sdv Assigned To => sdv
2013-04-05 11:37 sdv Note Added: 0024009
2013-04-05 11:37 sdv Status new => resolved
2013-04-15 19:51 abv Assigned To sdv => bugmaster
2013-04-16 18:18 sdv Assigned To bugmaster => abv
2013-06-24 16:46 ibs Note Added: 0024844
2013-06-24 16:46 ibs Assigned To abv => sdv
2013-06-24 16:46 ibs Status resolved => feedback
2013-06-25 10:09 sdv Note Added: 0024855
2013-06-25 11:56 ibs Note Added: 0024858
2013-06-25 11:56 ibs Assigned To sdv => ibs
2013-06-25 11:56 ibs Status feedback => assigned
2013-06-25 12:05 sdv Note Added: 0024859
2013-06-25 16:39 ibs Note Added: 0024862
2013-06-25 16:40 ibs Note Edited: 0024862
2013-06-28 11:50 ibs Note Added: 0024909
2013-06-28 11:55 ibs Assigned To ibs => abv
2013-06-28 11:55 ibs Status assigned => feedback
2013-06-28 12:08 ibs Note Edited: 0024909
2013-07-01 15:29 ibs Note Added: 0024931
2013-07-01 15:29 ibs Assigned To abv => ibs
2013-07-01 15:29 ibs Status feedback => assigned
2013-11-13 17:16 ibs Relationship added related to 0024355
2013-11-14 13:09 ibs Note Added: 0026624
2013-11-14 16:33 ibs Assigned To ibs => abv
2013-11-14 16:33 ibs Status assigned => resolved
2013-11-14 16:34 abv Note Added: 0026632
2013-11-14 16:34 abv Assigned To abv => bugmaster
2013-11-14 16:34 abv Status resolved => reviewed
2013-11-15 10:24 abv Changeset attached => occt master 234e52be
2013-11-15 10:24 abv Assigned To bugmaster => abv
2013-11-15 10:24 abv Status reviewed => verified
2013-11-15 10:24 abv Resolution open => fixed
2013-12-19 13:51 bugmaster Status verified => closed
2013-12-19 13:59 bugmaster Fixed in Version => 6.7.0
2014-01-11 11:59 abv Category OCCT Release:MFC => OCCT Release:Samples
2014-01-11 12:02 abv Category OCCT Release:Samples => OCCT:Samples