MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030873Community[OCCT] OCCT:Modeling Algorithmspublic2019-08-07 14:252019-08-12 15:20
Reporterdrazmyslovich 
Assigned Todrazmyslovich 
PrioritynormalSeverityminor 
StatusassignedResolutionopen 
PlatformWindowsOSVC++ 2015OS Version64 bit
Product Version[OCCT] 7.4.0* 
Target Version[OCCT] 7.5.0Fixed in Version 
Summary0030873: Avoid the loop in reshaper
DescriptionCurrently, BRepTools_ReShape utility is not resistent to application loops.
Steps To ReproduceTopoDS_Shape a;
TopoDS_Shape b;

BRepTools_ReShape reshaper;
reshaper.replace (a, b);
reshaper.replace (b, a);

reshaper.Apply (a); // infinite loop
TagsNo tags attached.
Test case number
Attached Files

- Relationships

-  Notes
(0086063)
git (administrator)
2019-08-07 14:27

Branch CR30873 has been created by drazmyslovich.

SHA-1: 828a75f2280fa20235acae49af4cb2f0876d71e9


Detailed log of new commits:

Author: drazmyslovich
Date: Wed Aug 7 13:25:15 2019 +0200

    0030873: Make ReShape tool resistant to replacement loops
(0086064)
drazmyslovich (developer)
2019-08-07 14:27

The proposed solution is submitted, please, review
(0086082)
msv (developer)
2019-08-08 09:56

Dear Eugeny, please review it.
(0086195)
emv (developer)
2019-08-12 14:43

It is not good to call the Apply method which supposed to rebuild the shape in the replace method. At this stage we just need to check if there is no cyclic dependency between the shape and newshape recorded into a map. I suggest implementing a separate method for that without rebuilding, only analyzing the map.
(0086199)
emv (developer)
2019-08-12 15:20

Additionally, it is better to use Assertion mechanism to warn the user about the error.

- Issue History
Date Modified Username Field Change
2019-08-07 14:25 drazmyslovich New Issue
2019-08-07 14:25 drazmyslovich Assigned To => drazmyslovich
2019-08-07 14:27 git Note Added: 0086063
2019-08-07 14:27 drazmyslovich Note Added: 0086064
2019-08-07 14:27 drazmyslovich Assigned To drazmyslovich => msv
2019-08-07 14:27 drazmyslovich Status new => resolved
2019-08-08 09:56 msv Note Added: 0086082
2019-08-08 09:56 msv Assigned To msv => emv
2019-08-08 09:56 msv Status resolved => assigned
2019-08-08 09:56 msv Status assigned => resolved
2019-08-12 14:43 emv Note Added: 0086195
2019-08-12 14:43 emv Assigned To emv => drazmyslovich
2019-08-12 14:43 emv Status resolved => assigned
2019-08-12 15:11 emv Target Version 7.4.0* => 7.5.0
2019-08-12 15:20 emv Note Added: 0086199


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker