View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0030483Open CASCADEOCCT:Visualizationpublic2019-02-07 12:002019-03-05 13:46
Reporterkgv Assigned Toapn  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version7.1.0 
Target Version7.4.0Fixed in Version7.4.0 
Summary0030483: Visualization, Path Tracing - make Tile Size configurable
Description0027607 introduced Adaptive screen space sampling within Path Tracing engine, and new parameter Graphic3d_RenderingParams::NbRayTracingTiles managing the amount of tiles for this rendering mode.

Implementation about this flag is confusing - tiles size 32x32 cannot be modified.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0030476 closedapn Visualization, Path Tracing - Adaptive Screen Sampling leads to unstable results 
child of 0027607 closedkgv Visualization - Implement adaptive screen space sampling in path tracing 

Activities

git

2019-02-07 15:49

administrator   ~0082064

Branch CR30483 has been created by kgv.

SHA-1: aa0d8b2fa573df6dd60f7389df24d491071ec71f


Detailed log of new commits:

Author: kgv
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - Graphic3d_RenderingParams::NbRayTracingTiles parameter is ignored
    
    OpenGl_TileSampler has been refactored to better describe its logic and solve bugs:
    - Tile size is now recomputed based on desired number of tiles instead of hard-coded number 32.
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with properties
    RayTracingMinTileSize/RayTracingMaxTileSize for testing various tile configurations.
    
    OpenGl_View::initRaytraceResources() now relies on tile properties of OpenGl_TileSampler
    instead of computing numbers of unknown purpose / unclear logic.
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.

git

2019-02-07 15:52

administrator   ~0082065

Branch CR30483 has been updated forcibly by kgv.

SHA-1: 7865871c3641a47c18e0e0edb79725cef6af3fb2

git

2019-02-07 16:05

administrator   ~0082067

Branch CR30483 has been updated forcibly by kgv.

SHA-1: 079cb5bf0ebdcf9bb32a7594b1b08cf8a321c976

kgv

2019-02-08 20:04

developer   ~0082103

Patch is ready for review.

git

2019-02-11 12:43

administrator   ~0082120

Branch CR30483 has been updated forcibly by kgv.

SHA-1: 626adf22cde790a0fff33404c2ccf44848a8b994

git

2019-02-11 16:52

administrator   ~0082130

Branch CR30483_1 has been created by kgv.

SHA-1: 6d5a0819ecdaa3afbd6fff2eb1a085bca5c2f2d1


Detailed log of new commits:

Author: kgv
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - make Tile Size configurable
    
    OpenGl_TileSampler has been refactored to better describe its logic:
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with property
    RayTracingTileSize for testing various tile configurations.
    Default behavior is the following:
    - Target number of tiles (e.g. upper limit per frame): 256
    - Tile size: 32x32.
    
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.

git

2019-02-11 17:21

administrator   ~0082131

Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: bd7e3806abb4f8344d8ecf5a22e21054c77b791a

git

2019-02-11 17:58

administrator   ~0082133

Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: 77bcc880e3f7cc43e5d98bad4e63d065b2e81e11

git

2019-02-12 09:32

administrator   ~0082142

Branch CR30483_1 has been updated forcibly by kgv.

SHA-1: c3f3f5c457860cc4001ebaab29b1fb948c133f7a

osa

2019-02-15 17:34

developer   ~0082200

Review without remarks

git

2019-03-05 13:46

administrator   ~0082639

Branch CR30483 has been deleted by kgv.

SHA-1: 626adf22cde790a0fff33404c2ccf44848a8b994

git

2019-03-05 13:46

administrator   ~0082640

Branch CR30483_1 has been deleted by kgv.

SHA-1: c3f3f5c457860cc4001ebaab29b1fb948c133f7a

Related Changesets

occt: master 66d1cdc6

2019-02-06 16:21:23

kgv


Committer: apn Details Diff		 0030483: Visualization, Path Tracing - make Tile Size configurable

OpenGl_TileSampler has been refactored to better describe its logic:
- Offset image now defines tile index instead of offset to tile origin.
- Added 2D array defining the number of times to sample tile for straight-forward debugging.

Graphic3d_RenderingParams has been extended with property
RayTracingTileSize for testing various tile configurations.
Default behavior is the following:
- Target number of tiles (e.g. upper limit per frame): 256
- Tile size: 32x32.

OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.

Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.		 Affected Issues
0030483
mod - src/Graphic3d/Graphic3d_RenderingParams.hxx Diff File
mod - src/Image/FILES Diff File
mod - src/Image/Image_PixMapData.hxx Diff File
add - src/Image/Image_PixMapTypedData.hxx Diff File
mod - src/OpenGl/OpenGl_Texture.cxx Diff File
mod - src/OpenGl/OpenGl_TileSampler.cxx Diff File
mod - src/OpenGl/OpenGl_TileSampler.hxx Diff File
mod - src/OpenGl/OpenGl_View.hxx Diff File
mod - src/OpenGl/OpenGl_View_Raytrace.cxx Diff File
mod - src/OpenGl/OpenGl_View_Redraw.cxx Diff File
mod - src/Shaders/Display.fs Diff File
mod - src/Shaders/RaytraceBase.fs Diff File
mod - src/Shaders/RaytraceRender.fs Diff File
mod - src/Shaders/Shaders_Display_fs.pxx Diff File
mod - src/Shaders/Shaders_RaytraceBase_fs.pxx Diff File
mod - src/Shaders/Shaders_RaytraceRender_fs.pxx Diff File
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File

Issue History

Date Modified Username Field Change
2019-02-07 12:00 kgv New Issue
2019-02-07 12:00 kgv Assigned To => kgv
2019-02-07 12:00 kgv Relationship added child of 0027607
2019-02-07 12:00 kgv Product Version 7.2.0 => 7.1.0
2019-02-07 12:00 kgv Relationship added related to 0030476
2019-02-07 15:49 git Note Added: 0082064
2019-02-07 15:52 git Note Added: 0082065
2019-02-07 16:05 git Note Added: 0082067
2019-02-08 20:04 kgv Note Added: 0082103
2019-02-08 20:04 kgv Assigned To kgv => san
2019-02-08 20:04 kgv Status new => resolved
2019-02-11 12:43 git Note Added: 0082120
2019-02-11 16:50 kgv Summary Visualization, Path Tracing - Graphic3d_RenderingParams::NbRayTracingTiles parameter is ignored => Visualization, Path Tracing - make Tile Size configurable
2019-02-11 16:50 kgv Description Updated
2019-02-11 16:52 git Note Added: 0082130
2019-02-11 17:21 git Note Added: 0082131
2019-02-11 17:58 git Note Added: 0082133
2019-02-12 09:32 git Note Added: 0082142
2019-02-15 17:34 kgv Assigned To san => osa
2019-02-15 17:34 osa Note Added: 0082200
2019-02-15 17:34 osa Assigned To osa => bugmaster
2019-02-15 17:34 osa Status resolved => reviewed
2019-02-16 11:47 apn Test case number => Not needed
2019-02-16 11:48 apn Changeset attached => occt master 66d1cdc6
2019-02-16 11:48 apn Assigned To bugmaster => apn
2019-02-16 11:48 apn Status reviewed => verified
2019-02-16 11:48 apn Resolution open => fixed
2019-03-05 13:46 git Note Added: 0082639
2019-03-05 13:46 git Note Added: 0082640