View Issue Details

IDProjectCategoryView StatusLast Update
0026070Open CASCADEOCCT:Visualizationpublic2015-05-14 16:36
ReporterabvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2010 
Product Version6.8.0 
Target Version6.9.0Fixed in Version6.9.0 
Summary0026070: Ray tracing with reflections is poor on rotated presentation
DescriptionThe problem is discovered in Windows version of CAD Assistant, on sample model cad.brep: if ray tracing and reflections is enabled, it is shown with artifacts, looking like reflections of non-existent objects.

Note that the model consists of solid and set of wires, and uses location assigned to these in order to have faces forming "CAD" letters visible when the model is opened with default view settings.

Use script in Steps to Reproduce to see the problem (reflections are present on outer surfaces of the shape) in DRAW
Steps To Reproducesource samples/tcl/cad.tcl
vrenderparams -rayTrace -reflections
vlocrotate res 0 0 0 0 0 1 180
vfit
Additional information
and documentation updates
Generation of secondary rays was incorrect in case of non-identity viewer transformation applied to AIS shape. As a result, global illumination effects (like shadows, reflections, and refractions) were also incorrect. This patch fixes the above problems by handling such transformations in ray-tracing shaders.
TagsNo tags attached.
Test case numberv3d raytrace(014) bug26070

Attached Files

  • rt-problems-cad.png (65,277 bytes)

Activities

abv

2015-04-13 15:22

manager  

rt-problems-cad.png (65,277 bytes)

git

2015-04-13 17:48

administrator   ~0039651

Branch CR26070 has been created by dbp.

SHA-1: e2ff00acc9025585bc20ce558fb02378709fbbd2


Detailed log of new commits:

Author: dbp
Date: Mon Apr 13 17:48:35 2015 +0300

    0026070: Ray tracing with reflections is poor on rotated presentation

dbp

2015-04-13 17:49

developer   ~0039652

Dear kgv,

please review the patch in branch CR26070.

kgv

2015-04-13 19:32

developer   ~0039655

Please test the patch.

git

2015-04-13 19:48

administrator   ~0039656

Branch CR26070 has been updated forcibly by mkv.

SHA-1: 8a4298923bfecafdec593bab4b6acc729081f90f

abv

2015-04-13 20:11

manager   ~0039657

I confirm that the patch fixes the original problem in CAD Assistant

mkv

2015-04-14 17:49

tester   ~0039700

Dear BugMaster,
Branch CR26070 was rebased on current master of occt git-repository.

mkv

2015-04-14 17:50

tester   ~0039701

Dear BugMaster,
Branch CR26070 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 8a4298923bfecafdec593bab4b6acc729081f90f

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR26070-master-occt-64/Debian60-64/v3d/raytrace/bug26070.html
http://occt-tests/CR26070-master-occt-64/Windows-64-VC10/v3d/raytrace/bug26070.html
v3d raytrace(014) bug26070: - There is not shape in the photo

Testing on Linux:
occt component :
Total MEMORY difference: 94048774 / 94235751 [-0.20%]
Total CPU difference: 53510.17999999944 / 56193.089999999705 [-4.77%]
products component :
Total MEMORY difference: 23682825 / 23699797 [-0.07%]
Total CPU difference: 16611.549999999985 / 19056.55999999996 [-12.83%]

Testing on Windows:
occt component :
Total MEMORY difference: 57126996 / 57127513 [-0.00%]
Total CPU difference: 15847.564386298953 / 15976.561613198899 [-0.81%]
products component :
Total MEMORY difference: 15477006 / 15478724 [-0.01%]
Total CPU difference: 6315.544483999951 / 6217.388654799964 [+1.58%]

There are no differences in images found by testdiff.

git

2015-04-14 17:50

administrator   ~0039702

Branch CR26070 has been updated by mkv.

SHA-1: 3ca643e062fdede4294e4491c8598bc246c57bb9


Detailed log of new commits:

Author: mkv
Date: Tue Apr 14 17:48:39 2015 +0300

    Test case for issue CR26070

git

2015-04-14 18:08

administrator   ~0039704

Branch CR26070 has been updated by mkv.

SHA-1: b0787145c81c2239f29727fef6c1574ff1402123


Detailed log of new commits:

Author: mkv
Date: Tue Apr 14 18:08:06 2015 +0300

    Small correction of test case for issue CR26070

mkv

2015-04-14 18:08

tester   ~0039705

Dear BugMaster,

Following draw-command was commented:
vshowfaceboundary res 1 255 255 255

Now
v3d raytrace(014) bug26070
test case is OK.
Branch CR26070 is TESTED.

git

2015-05-14 16:36

administrator   ~0041088

Branch CR26070 has been deleted by inv.

SHA-1: b0787145c81c2239f29727fef6c1574ff1402123

Related Changesets

occt: master cf537aac

2015-04-16 07:56:46

dbp


Committer: bugmaster Details Diff
0026070: Ray tracing with reflections is poor on rotated presentation

Test case for issue CR26070
Affected Issues
0026070
mod - src/Shaders/RaytraceBase.fs Diff File
add - tests/v3d/raytrace/bug26070 Diff File

Issue History

Date Modified Username Field Change
2015-04-13 15:02 abv New Issue
2015-04-13 15:02 abv Assigned To => kgv
2015-04-13 15:20 kgv Assigned To kgv => dbp
2015-04-13 15:20 kgv Status new => assigned
2015-04-13 15:22 abv File Added: rt-problems-cad.png
2015-04-13 17:48 git Note Added: 0039651
2015-04-13 17:49 dbp Note Added: 0039652
2015-04-13 17:49 dbp Assigned To dbp => kgv
2015-04-13 17:49 dbp Status assigned => resolved
2015-04-13 19:32 kgv Note Added: 0039655
2015-04-13 19:32 kgv Assigned To kgv => bugmaster
2015-04-13 19:32 kgv Status resolved => reviewed
2015-04-13 19:48 git Note Added: 0039656
2015-04-13 19:51 mkv Assigned To bugmaster => mkv
2015-04-13 20:11 abv Note Added: 0039657
2015-04-14 17:49 mkv Note Added: 0039700
2015-04-14 17:50 mkv Note Added: 0039701
2015-04-14 17:50 mkv Assigned To mkv => dbp
2015-04-14 17:50 mkv Status reviewed => feedback
2015-04-14 17:50 git Note Added: 0039702
2015-04-14 17:50 mkv Test case number => v3d raytrace(014) bug26070
2015-04-14 18:08 git Note Added: 0039704
2015-04-14 18:08 mkv Note Added: 0039705
2015-04-14 18:08 mkv Assigned To dbp => bugmaster
2015-04-14 18:08 mkv Status feedback => tested
2015-04-17 15:40 bugmaster Changeset attached => occt master cf537aac
2015-04-17 15:40 bugmaster Status tested => verified
2015-04-17 15:40 bugmaster Resolution open => fixed
2015-04-28 13:08 kgv Product Version => 6.8.0
2015-04-30 12:18 dbp Additional Information Updated
2015-05-14 15:28 aiv Status verified => closed
2015-05-14 15:30 aiv Fixed in Version => 6.9.0
2015-05-14 16:36 git Note Added: 0041088