View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0026033Open CASCADEOCCT:Codingpublic2015-04-09 08:262017-06-13 17:35
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version6.9.0Fixed in Version6.9.0 
Summary0026033: Coding rules - get rid from _Handle classes
DescriptionThe .cdl syntax to import classes inherited from Standard_Transient has been added not long time ago. Before this feature has been introduced, workaround has been used: handle class has been defined explicitly in addition to class itself in the following manner:
cdl:
  imported Camera;
  imported Camera_Handle;
files:
  Graphic3d_Camera.hxx
  Graphic3d_Camera_Handle.hxx
_Handle.hxx:
  typedef Handle(Graphic3d_Camera) Graphic3d_Camera_Handle;


The handle class has been misnamed due to .cdl rules - all Package classes are automatically named starting from package name.

This workaround is not required anymore and can be replaced by more clean syntax.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0024769 closedbugmaster Extend CDL syntax with "imported transient class" keyword 

Activities

git

2015-04-10 12:21

administrator   ~0039558

Branch CR26033 has been created by isk.

SHA-1: 547c130d90c588415e04ecd5ed56034035b3f21d


Detailed log of new commits:

Author: isk
Date: Fri Apr 10 12:19:57 2015 +0300

    0026033: Coding rules - get rid from _Handle classes

git

2015-04-10 13:55

administrator   ~0039567

Branch CR26033 has been updated by isk.

SHA-1: 25cba987bd3ea33a14afc3bebfaed75efaf8bc5b


Detailed log of new commits:

Author: isk
Date: Fri Apr 10 13:55:19 2015 +0300

    Fix

git

2015-04-10 14:56

administrator   ~0039576

Branch CR26033_1 has been created by isk.

SHA-1: 3f633e425592790f73bcaaaa8c3864fc77e0096a


Detailed log of new commits:

Author: isk
Date: Fri Apr 10 14:56:03 2015 +0300

    0026033: Coding rules - get rid from _Handle classes

kgv

2015-04-10 14:58

developer   ~0039577

Please test the patch.

git

2015-04-10 17:21

administrator   ~0039598

Branch CR26033_1 has been updated forcibly by apv.

SHA-1: 3827e215b07c24e5fc8115bdad510a2bc2505032

apv

2015-04-10 17:22

tester   ~0039599

Branch CR26033_1 has been rebased on the current master

apv

2015-04-14 15:50

tester   ~0039684

Dear BugMaster,

Branch CR26033_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 3827e215b07c24e5fc8115bdad510a2bc2505032

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 4 (4 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing on Linux:
Total MEMORY difference: 94341523 / 94241945 [+0.11%]
Total CPU difference: 54699.12999999931 / 56193.2199999997 [-2.66%]

Testing on Windows:
Total MEMORY difference: 57131549 / 57127628 [+0.01%]
Total CPU difference: 16040.069620299108 / 15976.577213298899 [+0.40%]

Following errors have been detected during C#-sample (OCCTProducts) building:
occtypes.i(333) : Error: Unable to find 'Aspect_DisplayConnection_Handle.hxx'
occtypes.i(333) : Error: Unable to find 'Graphic3d_CStructure_Handle.hxx'
occtypes.i(333) : Error: Unable to find 'Graphic3d_ShaderProgram_Handle.hxx'
occtypes.i(333) : Error: Unable to find 'Graphic3d_MarkerImage_Handle.hxx'
occtypes.i(333) : Error: Unable to find 'Graphic3d_Camera_Handle.hxx'
occtypes.i(333) : Error: Unable to find 'Graphic3d_ClipPlane_Handle.hxx'
c1xx : fatal error C1083: Cannot open source file: 'occcsharp_wrap.cxx': No such file or directory
 Total MEMORY difference: 57065537 / 57074762 [-0.02%]
 Total CPU difference: 16394.51949239888 / 16635.463036899022 [-1.45%]

abv

2015-04-16 11:08

manager   ~0039820

I have pushed fix for C# wrapper to branch CR26033 in products, please check (only C# wrapper)

git

2015-05-14 16:35

administrator   ~0041075

Branch CR26033 has been deleted by inv.

SHA-1: 25cba987bd3ea33a14afc3bebfaed75efaf8bc5b

git

2015-05-14 16:35

administrator   ~0041076

Branch CR26033_1 has been deleted by inv.

SHA-1: 3827e215b07c24e5fc8115bdad510a2bc2505032

git

2017-06-08 15:01

administrator   ~0067223

Branch CR26033 has been created by inv.

SHA-1: 0f4bfcc9a168c48b8c9432b1bcc100c63df5956e


Detailed log of new commits:

Author: bugmaster
Date: Thu Jun 8 15:01:03 2017 +0300

    0026303: Problem with test cases boolean/gdml_private L1-9 and K1-K9
    
    Problem is not reproduced on current status of OCCT.
    Test cases were reintegrated.

git

2017-06-13 17:35

administrator   ~0067359

Branch CR26033 has been deleted by kgv.

SHA-1: 0f4bfcc9a168c48b8c9432b1bcc100c63df5956e

Related Changesets

occt: master 494782f6

2015-04-10 11:56:03

isk


Committer: bugmaster Details Diff		 0026033: Coding rules - get rid from _Handle classes Affected Issues
0026033
mod - src/Aspect/Aspect.cdl Diff File
mod - src/Aspect/Aspect_DisplayConnection.hxx Diff File
rm - src/Aspect/Aspect_DisplayConnection_Handle.hxx Diff File
mod - src/Aspect/FILES Diff File
mod - src/Graphic3d/FILES Diff File
mod - src/Graphic3d/Graphic3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.cdl Diff File
mod - src/Graphic3d/Graphic3d_AspectFillArea3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_AspectLine3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_AspectMarker3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_AspectText3d.cdl Diff File
rm - src/Graphic3d/Graphic3d_BoundBuffer_Handle.hxx Diff File
rm - src/Graphic3d/Graphic3d_Buffer_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_Camera.hxx Diff File
rm - src/Graphic3d/Graphic3d_Camera_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_CAspectFillArea.hxx Diff File
mod - src/Graphic3d/Graphic3d_CAspectLine.hxx Diff File
mod - src/Graphic3d/Graphic3d_CAspectMarker.hxx Diff File
mod - src/Graphic3d/Graphic3d_CAspectText.hxx Diff File
mod - src/Graphic3d/Graphic3d_ClipPlane.hxx Diff File
rm - src/Graphic3d/Graphic3d_ClipPlane_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_CStructure.hxx Diff File
rm - src/Graphic3d/Graphic3d_CStructure_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_GraphicDriver.cdl Diff File
mod - src/Graphic3d/Graphic3d_Group.cdl Diff File
rm - src/Graphic3d/Graphic3d_IndexBuffer_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_MarkerImage.hxx Diff File
rm - src/Graphic3d/Graphic3d_MarkerImage_Handle.hxx Diff File
rm - src/Graphic3d/Graphic3d_SequenceOfHClipPlane_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_ShaderObject.hxx Diff File
rm - src/Graphic3d/Graphic3d_ShaderObject_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_ShaderProgram.hxx Diff File
rm - src/Graphic3d/Graphic3d_ShaderProgram_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_ShaderVariable.hxx Diff File
rm - src/Graphic3d/Graphic3d_ShaderVariable_Handle.hxx Diff File
mod - src/Graphic3d/Graphic3d_Structure.cdl Diff File
mod - src/Graphic3d/Graphic3d_ViewAffinity.hxx Diff File
mod - src/OpenGl/OpenGl_AspectFace.hxx Diff File
mod - src/OpenGl/OpenGl_ShaderManager.hxx Diff File
mod - src/OpenGl/OpenGl_Structure.cxx Diff File
mod - src/Prs3d/Prs3d_PointAspect.cdl Diff File
mod - src/PrsMgr/PrsMgr_PresentableObject.cdl Diff File
mod - src/V3d/V3d_View.cdl Diff File
mod - src/Visual3d/Visual3d_View.cdl Diff File

Issue History

Date Modified Username Field Change
2015-04-09 08:26 kgv New Issue
2015-04-09 08:26 kgv Assigned To => kgv
2015-04-09 08:26 kgv Assigned To kgv => isk
2015-04-09 08:26 kgv Status new => assigned
2015-04-09 08:28 kgv Relationship added related to 0024769
2015-04-10 12:21 git Note Added: 0039558
2015-04-10 13:55 git Note Added: 0039567
2015-04-10 14:56 git Note Added: 0039576
2015-04-10 14:56 isk Assigned To isk => kgv
2015-04-10 14:56 isk Status assigned => resolved
2015-04-10 14:56 isk Steps to Reproduce Updated
2015-04-10 14:58 kgv Note Added: 0039577
2015-04-10 14:58 kgv Assigned To kgv => bugmaster
2015-04-10 14:58 kgv Status resolved => reviewed
2015-04-10 15:50 mkv Assigned To bugmaster => apv
2015-04-10 17:21 git Note Added: 0039598
2015-04-10 17:22 apv Note Added: 0039599
2015-04-14 14:56 apv Test case number => Not needed
2015-04-14 15:50 apv Note Added: 0039684
2015-04-14 15:50 apv Assigned To apv => isk
2015-04-14 15:50 apv Status reviewed => assigned
2015-04-14 15:53 abv Assigned To isk => abv
2015-04-16 11:08 abv Note Added: 0039820
2015-04-16 11:08 abv Assigned To abv => bugmaster
2015-04-16 11:08 abv Status assigned => feedback
2015-04-16 17:22 apv Assigned To bugmaster => apv
2015-04-17 15:40 bugmaster Changeset attached => occt master 494782f6
2015-04-17 15:40 bugmaster Assigned To apv => bugmaster
2015-04-17 15:40 bugmaster Status feedback => verified
2015-04-17 15:40 bugmaster Resolution open => fixed
2015-05-14 15:28 aiv Status verified => closed
2015-05-14 15:31 aiv Fixed in Version => 6.9.0
2015-05-14 16:35 git Note Added: 0041075
2015-05-14 16:35 git Note Added: 0041076
2017-06-08 15:01 git Note Added: 0067223
2017-06-13 17:35 git Note Added: 0067359