View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025630 | Open CASCADE | OCCT:Foundation Classes | public | 2014-12-19 09:54 | 2015-10-16 16:47 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.9.0 | Fixed in Version | 6.9.0 | ||
| Summary | 0025630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert | ||||
| Description | Useless HMath_Vector class is contained in the source code of these classes. Later using of this class leads to memory leaks. | ||||
| Steps To Reproduce | Not applicable | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Please eliminate all static data in these sources |
|
|
Branch CR25630 has been created by azn. SHA-1: 9fa0b3d6daf85646272a01d5f8a18b4d79515033 Detailed log of new commits: Author: azn Date: Fri Dec 26 12:53:30 2014 +0300 25630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Code refactoring of BRepGProp_Sinert and BRepGProp_Vinert classes. - All static variables have been removed. - Common functionality has beem moved from BRepGProp_Sinert and BRepGProp_Vinert classes to the new BRepGProp_Gauss class. |
|
|
Branch CR25630 has been updated forcibly by azn. SHA-1: 42defe7696b9685af607c057d5eff608daeedf91 |
|
|
Please review. |
|
|
BRepGProp_Gauss.hxx: Spell check errors: //! Mass of the current system (without desity). //! May corresponds to: length, area, volume. desity => density corresponds => correspond //! Describes a types of the geometric objects. => //! Describes types of geometric objects. The overloaded methods Compute contain the same (copy-paste) description, however they all have different set of arguments. The description should reflect the meaning of arguments in order to know difference between methods from the description. Two of Compute methods return a double value, but the description does not tell that the returned value is Error of calculation. |
|
|
Branch CR25630 has been updated by azn. SHA-1: 4975024c23d1c73fdfde046aeb09c80e98585019 Detailed log of new commits: Author: azn Date: Thu Jan 22 09:29:10 2015 +0300 25630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Slight changes in the comments. |
|
|
Dear msv, Please check updated branch CR25630. |
|
|
Reviewed. |
|
|
Dear BugMaster, Branch CR25630 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms. SHA-1: 4975024c23d1c73fdfde046aeb09c80e98585019 Compilation error on Linux: ../../../../inc/BRepGProp_Gauss.hxx:215: error: extra qualification ‘BRepGProp_Gauss::’ on member ‘computeSInertiaOfElementaryPart’ http://jenkins-test-04.nnov.opencascade.com/user/mnt/my-views/view/CR25630/job/mnt-CR25630-master_build_occt_linux/1/parsed_console/ Compilation error on MacOS: In file included from /Users/mnt/tools/WOK671/wok_entities/LOC/dev/CR25630-master-occt/src/BRepGProp/BRepGProp_Gauss.cxx:20: /Users/mnt/tools/WOK671/wok_entities/LOC/dev/CR25630-master-occt/inc/BRepGProp_Gauss.hxx:215:25: error: extra qualification on member 'computeSInertiaOfElementaryPart' http://jenkins-test-04.nnov.opencascade.com/user/mnt/my-views/view/CR25630/job/mnt-CR25630-master_prepare_build_occt_MacOS/1/parsed_console/ |
|
|
Branch CR25630 has been updated by azn. SHA-1: b2b902e73dca0d71eb20f813cdb1c9a913edd534 Detailed log of new commits: Author: azn Date: Thu Jan 29 14:01:42 2015 +0300 25630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Fix compilation error. |
|
|
Branch CR25630 has been updated forcibly by azn. SHA-1: 49d2656d169d01d8d6ddd6427cdea632feaf3555 |
|
|
Reviewed. |
|
|
Dear BugMaster, Branch CR25630 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested in Release mode. SHA-1: 49d2656d169d01d8d6ddd6427cdea632feaf3555 Number of compiler warnings: occt component : Linux: 23 (18 on master) BRepGProp_Gauss.hxx:32, GNU C Compiler 4 (gcc), Priority: Normal ‘Standard_Real BRepGProp_Gauss::Inertia::Mass’ BRepGProp_Gauss.hxx:44, GNU C Compiler 4 (gcc), Priority: Normal ‘Standard_Real BRepGProp_Gauss::Inertia::Ixz’ BRepGProp_Gauss.hxx:44, GNU C Compiler 4 (gcc), Priority: Normal ‘BRepGProp_Gauss::Inertia::Ixz’ will be initialized after BRepGProp_Gauss.hxx:45, GNU C Compiler 4 (gcc), Priority: Normal ‘BRepGProp_Gauss::Inertia::Iyz’ will be initialized after BRepGProp_Gauss.cxx:130, GNU C Compiler 4 (gcc), Priority: Normal when initialized here Windows: 2 (0 on master) BRepGProp_Gauss.cxx:964, MSBuild, Priority: Normal conditional expression is constant BRepGProp_Gauss.cxx:1015, MSBuild, Priority: Normal conditional expression is constant products component : Linux: 11 (11 on master) Windows: 1 (1 on master) Regressions/Differences: bugs modalg_2 bug5157_1 bug5157_2 bugs modalg_3 bug6063 bug6063_1 bugs xde bug22898 http://occt-tests/CR25630-master-occt/Debian60-64/summary.html http://occt-tests/CR25630-master-occt/Windows-32-VC10/summary.html Testing cases: Not needed Testing on Linux: Total MEMORY difference: 369092000 / 369837000 Total CPU difference: 52881.88999999973 / 51428.1600000002 Testing on Windows: Total MEMORY difference: 274953168 / 275567048 Total CPU difference: 38396.8125 / 37797.921875 There are not differences in images found by testdiff. |
|
|
Branch CR25630 has been updated forcibly by azn. SHA-1: 3116adfa044189bbe5daf9a5d1c07eacc16c0fba |
|
|
Please review new changes in CR25630 brunch. |
|
|
The warnings Windows: 2 (0 on master) BRepGProp_Gauss.cxx:964, MSBuild, Priority: Normal conditional expression is constant BRepGProp_Gauss.cxx:1015, MSBuild, Priority: Normal conditional expression is constant are not addressed by this fix. |
|
|
Branch CR25630 has been updated by azn. SHA-1: 0bad6df45171b82cf62094ed8529c37c59202e89 Detailed log of new commits: Author: azn Date: Thu Mar 12 13:20:26 2015 +0300 25630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Elimination of constant conditional expression warnings. |
|
|
Alexander, please make correction that we spoke about. |
|
|
Branch CR25630 has been updated by azn. SHA-1: de27ade2df2d1cfcd0385adbe9dea5a3bd5a4aba Detailed log of new commits: Author: azn Date: Mon Mar 16 09:12:48 2015 +0300 0025630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Small fix in comment. |
|
|
Reviewed. |
|
|
Branch CR25630 has been updated forcibly by apv. SHA-1: c4d3ddeda8a7b609fa496742f91c012153a19329 |
|
|
Branch CR25630 has been rebased on the current master |
|
|
Dear BugMaster, Branch CR25630 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: c4d3ddeda8a7b609fa496742f91c012153a19329 Number of compiler warnings: occt component: Linux: 18 (18 on master) Windows: 0 (0 on master) products component: Linux: 11 (11 on master) Windows: 4 (4 on master) Regressions/Differences: Not detected Testing cases: Not needed Testing on Linux: Total MEMORY difference: 89911044 / 90067896 Total CPU difference: 58686.52000000015 / 58911.169999999984 Testing on Windows: Total MEMORY difference: 58085918 / 58093704 Total CPU difference: 49773.015625 / 57284.859375 |
|
|
Branch CR25630 has been deleted by kgv. SHA-1: c4d3ddeda8a7b609fa496742f91c012153a19329 |
|
occt: master 9bd59d1c 2015-03-19 12:50:09
Committer: bugmaster Details Diff |
0025630: Possible memory leaks in BRepGProp_Vinert and BRepGProp_Sinert Code refactoring of BRepGProp_Sinert and BRepGProp_Vinert classes. - All static variables have been removed. - Common functionality connected with Gauss integration has beem moved from BRepGProp_Sinert and BRepGProp_Vinert classes to the new BRepGProp_Gauss class. Slight changes in the comments. Fix compilation error. Fix Sinert errors. Rebased on new master. Elimination of constant conditional expression warnings. Small fix in comment. |
Affected Issues 0025630 |
|
| add - src/BRepGProp/BRepGProp_Gauss.cxx | Diff File | ||
| add - src/BRepGProp/BRepGProp_Gauss.hxx | Diff File | ||
| mod - src/BRepGProp/BRepGProp_Sinert.cxx | Diff File | ||
| mod - src/BRepGProp/BRepGProp_Vinert.cxx | Diff File | ||
| add - src/BRepGProp/FILES | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-19 09:54 |
|
New Issue | |
| 2014-12-19 09:54 |
|
Assigned To | => abv |
| 2014-12-25 09:48 |
|
Note Added: 0035700 | |
| 2014-12-25 09:48 |
|
Assigned To | abv => azn |
| 2014-12-25 09:48 |
|
Status | new => assigned |
| 2015-01-20 08:40 | git | Note Added: 0036230 | |
| 2015-01-20 08:40 |
|
Assigned To | azn => abv |
| 2015-01-20 08:40 |
|
Status | assigned => resolved |
| 2015-01-20 08:40 |
|
Steps to Reproduce Updated | |
| 2015-01-21 10:26 | git | Note Added: 0036293 | |
| 2015-01-21 10:28 |
|
Note Added: 0036294 | |
| 2015-01-21 10:28 |
|
Assigned To | abv => msv |
| 2015-01-21 18:13 |
|
Note Added: 0036345 | |
| 2015-01-21 18:13 |
|
Assigned To | msv => azn |
| 2015-01-21 18:13 |
|
Status | resolved => assigned |
| 2015-01-22 09:29 | git | Note Added: 0036356 | |
| 2015-01-22 09:33 |
|
Note Added: 0036357 | |
| 2015-01-22 09:33 |
|
Assigned To | azn => msv |
| 2015-01-22 09:33 |
|
Status | assigned => resolved |
| 2015-01-22 10:33 |
|
Note Added: 0036362 | |
| 2015-01-22 10:33 |
|
Assigned To | msv => bugmaster |
| 2015-01-22 10:33 |
|
Status | resolved => reviewed |
| 2015-01-28 19:07 | apn | Assigned To | bugmaster => apn |
| 2015-01-29 12:44 | apn | Note Added: 0036803 | |
| 2015-01-29 12:44 | apn | Test case number | => Not needed |
| 2015-01-29 12:44 | apn | Assigned To | apn => azn |
| 2015-01-29 12:45 | apn | Status | reviewed => assigned |
| 2015-01-29 14:03 | git | Note Added: 0036817 | |
| 2015-01-29 14:08 | git | Note Added: 0036818 | |
| 2015-01-29 14:09 |
|
Assigned To | azn => msv |
| 2015-01-29 14:09 |
|
Status | assigned => resolved |
| 2015-01-29 14:44 |
|
Note Added: 0036824 | |
| 2015-01-29 14:44 |
|
Assigned To | msv => bugmaster |
| 2015-01-29 14:44 |
|
Status | resolved => reviewed |
| 2015-01-29 17:57 | apn | Assigned To | bugmaster => apn |
| 2015-02-02 13:03 | apn | Note Added: 0036954 | |
| 2015-02-02 13:04 | apn | Assigned To | apn => azn |
| 2015-02-02 13:04 | apn | Status | reviewed => assigned |
| 2015-03-11 15:45 | git | Note Added: 0038266 | |
| 2015-03-11 15:48 |
|
Note Added: 0038267 | |
| 2015-03-11 15:48 |
|
Assigned To | azn => msv |
| 2015-03-11 15:48 |
|
Status | assigned => resolved |
| 2015-03-11 17:51 |
|
Note Added: 0038279 | |
| 2015-03-11 17:51 |
|
Assigned To | msv => azn |
| 2015-03-11 17:51 |
|
Status | resolved => assigned |
| 2015-03-12 13:21 | git | Note Added: 0038294 | |
| 2015-03-12 13:21 |
|
Assigned To | azn => msv |
| 2015-03-12 13:21 |
|
Status | assigned => resolved |
| 2015-03-13 17:51 |
|
Note Added: 0038349 | |
| 2015-03-13 17:51 |
|
Assigned To | msv => azn |
| 2015-03-13 17:51 |
|
Status | resolved => assigned |
| 2015-03-16 09:14 | git | Note Added: 0038380 | |
| 2015-03-16 09:15 |
|
Assigned To | azn => msv |
| 2015-03-16 09:15 |
|
Status | assigned => resolved |
| 2015-03-16 09:35 |
|
Note Added: 0038382 | |
| 2015-03-16 09:35 |
|
Assigned To | msv => bugmaster |
| 2015-03-16 09:35 |
|
Status | resolved => reviewed |
| 2015-03-16 12:20 |
|
Assigned To | bugmaster => apv |
| 2015-03-16 16:05 | git | Note Added: 0038399 | |
| 2015-03-16 16:06 |
|
Note Added: 0038400 | |
| 2015-03-17 13:44 |
|
Note Added: 0038426 | |
| 2015-03-17 13:44 |
|
Assigned To | apv => bugmaster |
| 2015-03-17 13:44 |
|
Status | reviewed => tested |
| 2015-03-20 13:34 | bugmaster | Changeset attached | => occt master 9bd59d1c |
| 2015-03-20 13:34 | bugmaster | Status | tested => verified |
| 2015-03-20 13:34 | bugmaster | Resolution | open => fixed |
| 2015-05-14 15:28 |
|
Status | verified => closed |
| 2015-05-14 15:31 |
|
Fixed in Version | => 6.9.0 |
| 2015-10-16 16:47 | git | Note Added: 0047033 |
