View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0025629Open CASCADEOCCT:Codingpublic2014-12-19 09:132015-05-14 15:32
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityintegration request 
Status closedResolutionfixed 
Target Version6.9.0Fixed in Version6.9.0 
Summary0025629: Visualization, AIS_InteractiveContext - code clean up
DescriptionCode of AIS_InteractiveContext class is bloated with debugging sections, and obsolete solutions escaped by macros.

Confusing method AIS_InteractiveContext::Clear() should be dropped (::Remove() should be used instead).

Also, AIS_InteractiveContext::DisplayedObjects() has been broken - it does not retrieve object from local contexts anymore.
TagsNo tags attached.
Test case numberNot needed

Relationships

child of 0023117 closedbugmaster Open CASCADE TKV3d and TKOpenGl code clean-up 

Activities

git

2014-12-19 09:16

administrator   ~0035499

Branch CR25629 has been created by kgv.

SHA-1: 95cbb3e53c72935622ac9f6dc03e14c49d930e1c


Detailed log of new commits:

Author: kgv
Date: Fri Dec 19 09:16:18 2014 +0300

    0025629: Visualization, AIS_InteractiveContext - code clean up
    
    Drop confusing method AIS_InteractiveContext::Clear() which is the same as ::Remove().
    AIS_InteractiveContext::Display() - fix double viewer update on first display of presentation.
    AIS_InteractiveContext::DisplayedObjects() - fix objects retrieval from local contexts.
    
    Drop code blocks for debug output.
    Code clean up.

kgv

2014-12-19 09:18

developer   ~0035500

Patch is ready for review in branch CR25629.

git

2014-12-24 11:21

administrator   ~0035660

Branch CR25629 has been updated by kgv.

SHA-1: 28def1f9d82692518ab6dc7dbafea02c93619f3b


Detailed log of new commits:

Author: kgv
Date: Wed Dec 24 11:21:48 2014 +0300

    AIS_InteractiveContext::Load() - do not bind object twice

san

2014-12-24 11:29

developer   ~0035661

Branch CR25629 reviewed without remarks, ready for testing.

git

2014-12-24 12:16

administrator   ~0035667

Branch CR25629_1 has been created by kgv.

SHA-1: dab1a31adf3bc5911959ec2a5a8af335ae4aa8b4


Detailed log of new commits:

Author: kgv
Date: Wed Dec 24 12:15:53 2014 +0300

    0025629: Visualization, AIS_InteractiveContext - code clean up
    
    Drop confusing method AIS_InteractiveContext::Clear() which is the same as ::Remove().
    AIS_InteractiveContext::Display() - fix double viewer update on first display of presentation.
    AIS_InteractiveContext::DisplayedObjects() - fix objects retrieval from local contexts.
    AIS_InteractiveContext::Load() - do not bind object twice.
    
    Drop code blocks for debug output.
    Code clean up.

git

2014-12-26 19:32

administrator   ~0035797

Branch CR25629_1 has been updated forcibly by apv.

SHA-1: d5111a25bf4e3b2fbfc02ad69156b2acce5b2a9a

apv

2014-12-26 19:33

tester   ~0035798

Branch CR25629_1 has been rebased on the current master

apv

2014-12-27 14:57

tester   ~0035815

Branch CR25629 has been created by in products git-repository.
SHA-1: 094bdae349320b032d3ac56a2c9f845acbdd4dbc

Dear kgv,
Please, validate small correction in branch CR25629 in products git-repository.

kgv

2014-12-29 11:14

developer   ~0035822

Correction is OK.

apv

2014-12-29 11:37

tester   ~0035823

Dear BugMaster,

Branch CR25629_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: d5111a25bf4e3b2fbfc02ad69156b2acce5b2a9a

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component :
   Linux: 11 (11 on master)
   Windows: 1 (1 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 369471120 / 369143040
Total CPU difference: 48751.230000000025 / 46134.27000000006

Testing on Windows:
Total MEMORY difference: 276339240 / 276918412
Total CPU difference: 47118.203125 / 38326.15625

git

2015-01-26 12:33

administrator   ~0036541

Branch CR25629_1 has been deleted by inv.

SHA-1: d5111a25bf4e3b2fbfc02ad69156b2acce5b2a9a

git

2015-01-26 12:33

administrator   ~0036546

Branch CR25629 has been deleted by inv.

SHA-1: 28def1f9d82692518ab6dc7dbafea02c93619f3b

Related Changesets

occt: master 2195ab96

2014-12-24 09:15:53

kgv


Committer: bugmaster Details Diff		 0025629: Visualization, AIS_InteractiveContext - code clean up

Drop confusing method AIS_InteractiveContext::Clear() which is the same as ::Remove().
AIS_InteractiveContext::Display() - fix double viewer update on first display of presentation.
AIS_InteractiveContext::DisplayedObjects() - fix objects retrieval from local contexts.
AIS_InteractiveContext::Load() - do not bind object twice.

Drop code blocks for debug output.
Code clean up.		 Affected Issues
0025629
mod - src/AIS/AIS_InteractiveContext.cdl Diff File
mod - src/AIS/AIS_InteractiveContext.cxx Diff File
mod - src/QABugs/QABugs_11.cxx Diff File
mod - src/ViewerTest/ViewerTest.cxx Diff File

Issue History

Date Modified Username Field Change
2014-12-19 09:13 kgv New Issue
2014-12-19 09:13 kgv Assigned To => kgv
2014-12-19 09:13 kgv Relationship added child of 0023117
2014-12-19 09:16 git Note Added: 0035499
2014-12-19 09:18 kgv Note Added: 0035500
2014-12-19 09:18 kgv Assigned To kgv => san
2014-12-19 09:18 kgv Status new => resolved
2014-12-24 11:21 git Note Added: 0035660
2014-12-24 11:29 san Note Added: 0035661
2014-12-24 11:29 san Assigned To san => bugmaster
2014-12-24 11:29 san Status resolved => reviewed
2014-12-24 12:13 mkv Assigned To bugmaster => apv
2014-12-24 12:16 git Note Added: 0035667
2014-12-26 19:32 git Note Added: 0035797
2014-12-26 19:33 apv Note Added: 0035798
2014-12-27 14:57 apv Note Added: 0035815
2014-12-27 14:57 apv Assigned To apv => kgv
2014-12-27 14:57 apv Status reviewed => feedback
2014-12-29 11:14 kgv Note Added: 0035822
2014-12-29 11:14 kgv Assigned To kgv => apv
2014-12-29 11:34 apv Test case number => Not needed
2014-12-29 11:37 apv Note Added: 0035823
2014-12-29 11:37 apv Assigned To apv => bugmaster
2014-12-29 11:37 apv Status feedback => tested
2015-01-16 13:37 bugmaster Changeset attached => occt master 2195ab96
2015-01-16 13:37 bugmaster Status tested => verified
2015-01-16 13:37 bugmaster Resolution open => fixed
2015-01-26 12:33 git Note Added: 0036541
2015-01-26 12:33 git Note Added: 0036546
2015-05-14 15:29 aiv Status verified => closed
2015-05-14 15:32 aiv Fixed in Version => 6.9.0