View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025345 | Open CASCADE | OCCT:Modeling Algorithms | public | 2014-10-09 10:02 | 2017-02-08 11:40 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | no change required | ||
| Target Version | 6.9.0 | Fixed in Version | 6.9.0 | ||
| Summary | 0025345: Revise and document usage of flag Closed in TopoDS_Shape | ||||
| Description | We need to document usage of flag Closed in TopoDS_Shape, depending on a shape type, and revise the code to make sure it is always set properly when new shape is constructed. Some points to be clarified: - Do we need to have this flag set in solids? Note that currently some algorithms set it (e.g. try psphere), and some not (e.g. try box). - Do we need this flag set in wires? - Do we need this flag set in edges, and what is its meaning in such case (note that 'closed' is also used for edge in context of the face, in the sense that it has two pcurves on that face, i.e. seam) The general approach should be to set this flag properly whenever new shape is constructed (look for methods EmptyCopied() and Make...). See #25202 for original issue. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR25345 has been created by abv. SHA-1: 34f9c25601d46c026f47369d210bdb29053e8426 Detailed log of new commits: Author: abv Date: Thu Oct 9 10:03:50 2014 +0400 0025345: Revise and document usage of flag Closed in TopoDS_Shape Setting Closed flag in newly constructed wires, perhaps excessive Author: abv Date: Wed Oct 8 18:52:07 2014 +0400 0025202: Incorrect value of IsClosed flag in shapes produced by some algorithms Method BRep_Tool::IsClosed() extended to analyze closure of wires in addition to shells and solids. External and Internal edges and vertices are ignored in this check. Analysis of compounds is disabled. Update of flag Closed according to actual state is added in most places where new shells are constructed. Draw-command and test case for issue CR25202 |
|
|
Dear Andrey, I hope this problem is covered by the fix of issue 0025656. Could you, please, review it? |
|
|
Branch CR25345 has been deleted by kgv. SHA-1: 34f9c25601d46c026f47369d210bdb29053e8426 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-10-09 10:02 |
|
New Issue | |
| 2014-10-09 10:02 |
|
Assigned To | => ifv |
| 2014-10-09 11:09 | git | Note Added: 0032867 | |
| 2014-12-30 09:33 |
|
Relationship added | duplicate of 0025656 |
| 2014-12-30 09:34 |
|
Note Added: 0035867 | |
| 2014-12-30 09:34 |
|
Assigned To | ifv => abv |
| 2014-12-30 09:34 |
|
Status | new => feedback |
| 2016-11-06 21:32 |
|
Status | feedback => closed |
| 2016-11-06 21:32 |
|
Resolution | open => no change required |
| 2016-11-06 21:32 |
|
Fixed in Version | => 6.9.0 |
| 2016-11-06 21:32 |
|
Target Version | 7.1.0 => 6.9.0 |
| 2017-02-08 11:40 | git | Note Added: 0063637 |
