View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024388Open CASCADEOCCT:Visualizationpublic2013-11-20 18:192014-05-05 13:37
ReportersanAssigned Tobugmaster  
PrioritylowSeveritytrivial 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.7.0 
Target Version6.7.1Fixed in Version6.7.1 
Summary0024388: Option to enable visualization of hidden lines in DRAW
DescriptionCurrently, there is no way to enable visualization of hidden lines in DRAW.
Meanwhile, both HLR algorithms (StdPrs_HLRPolyShape and StdPrs_HLRShape) support this.
It is proposed to add an option to vhlr or vhlrtype command to show hidden lines, and to improve the test cases related to HLR accordingly.
TagsNo tags attached.
Test case numberbugs vis(004) bug24388_1, bug24388_2

Relationships

related to 0023709 closedaba Redesign of hlrtest command 

Activities

aba

2013-12-23 14:19

developer   ~0027303

The git branch CR24388 is ready to be reviewed.

1) The option to draw hidden lines was added to vhlr command
2) Test cases /bugs/vis/bug24388_1 and /bugs/vis/bug24388_2 were added to test hidden lines displaying.

Dear san,
please review.

san

2013-12-24 11:30

developer   ~0027318

Branch CR24388 reviewed with the following remarks:

src/ViewerTest/ViewerTest_ViewerCommands.cxx: VHLR() function - enabling/disabling the computed mode should be moved to the beginning of the function. Currently, checking PREVIOUS value of MyHLRIsOn variable and settings the NEW value few lines after that looks confusing.

The test cases: is it really important to have two test cases for highlighting of HLR'ed presentation? Is it possible to check regular HLR visualization in one of the cases? And once a test case includes several stages and result of each stage is checked, it is recommended to dump 3D view snapshot several times, just to be able to check visually what was wrong with the case.

aba

2014-01-09 17:46

developer   ~0027425

Branch CR24388 was corrected according to remarks.

Dear san,
please review.

san

2014-01-15 17:00

developer   ~0027503

Branch CR24388 reviewed without remarks, ready for testing.

mkv

2014-01-16 11:34

tester   ~0027516

Last edited: 2014-01-16 11:36

 Dear BugMaster,

Branch CR24388 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 98e87b8cdc9f0f5c8be8ebccf1215f63bf055cca

Number of compiler warnings:

occt component :
Linux: 55 (55 on master)
Windows: 1 (1 on master)

products component :
Linux: 20 (20 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:

http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_1.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_1.html
bugs vis(004) bug24388_1: OK

http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_2.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_2.html
bugs vis(004) bug24388_2: OK

Testing on Linux:
Total MEMORY difference: 357927760 / 357072716
Total CPU difference: 44640.649999999914 / 42990.47999999986

Testing on Windows:
Total MEMORY difference: 413251036 / 412474228
Total CPU difference: 29806.625 / 32601.09375

There are not differences in images found by testdiff.

Related Changesets

occt: master e9224045

2014-01-16 10:09:05

aba


Committer: bugmaster Details Diff		 0024388: Option to enable visualization of hidden lines in DRAW

Added additional snapshot dumping to /tests/bugs/vis/bug24388_2. Corrected bug24388_1. Corrected vhlr command.		 Affected Issues
0024388
mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx Diff File
add - tests/bugs/vis/bug24388_1 Diff File
add - tests/bugs/vis/bug24388_2 Diff File

Issue History

Date Modified Username Field Change
2013-11-20 18:19 san New Issue
2013-11-20 18:19 san Assigned To => aba
2013-11-20 18:21 san Relationship added related to 0023709
2013-11-20 18:21 san Priority normal => low
2013-11-20 18:22 san Status new => assigned
2013-11-20 18:52 san Summary vhlr command: option to enable visualization of hidden lines => Option to enable visualization of hidden lines in DRAW
2013-11-20 18:52 san Description Updated
2013-12-23 14:19 aba Note Added: 0027303
2013-12-23 14:19 aba Assigned To aba => san
2013-12-23 14:19 aba Status assigned => resolved
2013-12-24 11:30 san Note Added: 0027318
2013-12-24 11:30 san Assigned To san => aba
2013-12-24 11:30 san Status resolved => assigned
2014-01-09 17:46 aba Note Added: 0027425
2014-01-09 17:46 aba Assigned To aba => san
2014-01-09 17:46 aba Status assigned => resolved
2014-01-15 17:00 san Note Added: 0027503
2014-01-15 17:00 san Assigned To san => bugmaster
2014-01-15 17:00 san Status resolved => reviewed
2014-01-16 07:22 mkv Assigned To bugmaster => mkv
2014-01-16 11:34 mkv Note Added: 0027516
2014-01-16 11:36 mkv Test case number => bugs vis(004) bug24388_1, bug24388_2
2014-01-16 11:36 mkv Assigned To mkv => bugmaster
2014-01-16 11:36 mkv Status reviewed => tested
2014-01-16 11:36 mkv Note Edited: 0027516
2014-01-21 11:22 bugmaster Changeset attached => occt master e9224045
2014-01-21 11:22 bugmaster Status tested => verified
2014-01-21 11:22 bugmaster Resolution open => fixed
2014-05-05 13:36 aiv Status verified => closed
2014-05-05 13:37 aiv Fixed in Version => 6.7.1