View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024321Open CASCADEOCCT:Visualizationpublic2013-11-05 16:492013-12-19 13:59
ReporterdbvAssigned Tobugmaster  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
PlatformAOSL 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024321: Use List collection instead of NCollection_Set for collection of Handle(Graphic3d_ClipPlane)
DescriptionCurrently Graphic3d_SetOfHClipPlane is NCollection_Set. Disadvantage of such approach is that NCollection_Set does not guarantee that the objects will be returned in the order in which they were added. This makes it difficult to reuse the Graphic3d_SetOfHClipPlane in applications.
Additional information
and documentation updates		Description:
The NCollection_Set (Graphic3d_SetOfHClipPlane) was replaced by ordered NCollection_Sequence type (Graphic3d_SequenceOfHClipPlane) to manage collections of planes.

List of changes:
1) Graphic3d_SetOfHClipPlane was replaced by Graphic3d_SequenceOfHClipPlane.
2) PrsMgr_PresentableObject::SetClipPlanes(..), GetClipPlanes() now accept Graphic3d_SequenceOfHClipPlane collection type.
3) V3d_View::SetClipPlanes(...), GetClipPlanes() now accept Graphic3d_SequenceOfHClipPlane collection type.


Porting notes:
It might be necessary to revise code of your application which deals with Graphic3d_SetOfHClipPlane collections and replace the occurrences by similar ordered Graphic3d_SequenceOfHClipPlane collection type.
TagsNo tags attached.
Test case numberNot needed

Activities

apl

2013-11-18 21:50

developer   ~0026720

Dear dbv,

Could you please review branch CR24321?

dbv

2013-11-19 11:56

developer   ~0026733

Reviewed without remarks, please test.

mkv

2013-11-20 12:35

tester   ~0026796

Dear BugMaster,

Branch CR24321 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: fe0c3d58b6cff3847b8b3884658678e8761d873f

Number of compiler warnings:

occt component :
Linux: 317 (317 on master)
Windows: 0 (0 on master)

products component :
Linux: 188 (189 on master)
Windows: 287 (287 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 357424944 / 357253212
Total CPU difference: 44814.02000000031 / 43279.94000000018

Testing on Windows:
Total MEMORY difference: 411868556 / 411604936
Total CPU difference: 31403.84375 / 34417.765625

There are not differences in images found by testdiff.

Related Changesets

occt: master 51b10cd4

2013-11-18 17:48:50

apl


Committer: bugmaster Details Diff		 0024321: Use List collection instead of NCollection_Set for collection of Handle(Graphic3d_ClipPlane)

- The NCollection_Sequence (Graphic3d_SequenceOfHClipPlane) is used for handling ordered lists of clipping planes instead of NCollection_Set (Graphic3d_SetOfHClipPlane).		 Affected Issues
0024321
mod - src/Graphic3d/FILES Diff File
mod - src/Graphic3d/Graphic3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_CStructure.hxx Diff File
mod - src/Graphic3d/Graphic3d_CView.hxx Diff File
mod - src/Graphic3d/Graphic3d_Structure.cdl Diff File
mod - src/Graphic3d/Graphic3d_Structure.cxx Diff File
mod - src/OpenGl/OpenGl_CappingAlgo.cxx Diff File
mod - src/OpenGl/OpenGl_Clipping.cxx Diff File
mod - src/OpenGl/OpenGl_Clipping.hxx Diff File
mod - src/OpenGl/OpenGl_ShaderManager.cxx Diff File
mod - src/OpenGl/OpenGl_ShaderStates.hxx Diff File
mod - src/OpenGl/OpenGl_Structure.cxx Diff File
mod - src/OpenGl/OpenGl_Structure.hxx Diff File
mod - src/OpenGl/OpenGl_View.hxx Diff File
mod - src/OpenGl/OpenGl_View_2.cxx Diff File
mod - src/PrsMgr/PrsMgr_PresentableObject.cdl Diff File
mod - src/PrsMgr/PrsMgr_PresentableObject.cxx Diff File
mod - src/PrsMgr/PrsMgr_PresentableObject.lxx Diff File
mod - src/StdSelect/StdSelect_ViewerSelector3d.cdl Diff File
mod - src/StdSelect/StdSelect_ViewerSelector3d.cxx Diff File
mod - src/V3d/V3d_View.cdl Diff File
mod - src/V3d/V3d_View_2.cxx Diff File
mod - src/Visual3d/Visual3d_ContextView.cdl Diff File
mod - src/Visual3d/Visual3d_ContextView.cxx Diff File
mod - src/Visual3d/Visual3d_View.cxx Diff File

Issue History

Date Modified Username Field Change
2013-11-05 16:49 dbv New Issue
2013-11-05 16:49 dbv Assigned To => apl
2013-11-05 16:54 apl Status new => assigned
2013-11-05 16:55 apl Severity minor => feature
2013-11-05 16:55 apl Reproducibility N/A => always
2013-11-05 16:55 apl OS => L
2013-11-05 16:55 apl OS Version => L
2013-11-05 16:55 apl Platform => A
2013-11-05 16:55 apl Target Version => 6.7.0
2013-11-18 21:49 apl Summary Use NCollection_List instead of NCollection_Set for collection of Handle(Graphic3d_ClipPlane) => Use List collection instead of NCollection_Set for collection of Handle(Graphic3d_ClipPlane)
2013-11-18 21:50 apl Note Added: 0026720
2013-11-18 21:50 apl Assigned To apl => dbv
2013-11-18 21:50 apl Status assigned => resolved
2013-11-18 21:54 apl Additional Information Updated
2013-11-18 21:54 apl Additional Information Updated
2013-11-18 21:55 apl Additional Information Updated
2013-11-19 11:56 dbv Note Added: 0026733
2013-11-19 11:56 dbv Assigned To dbv => bugmaster
2013-11-19 11:56 dbv Status resolved => reviewed
2013-11-19 14:14 mkv Assigned To bugmaster => mkv
2013-11-20 12:35 mkv Note Added: 0026796
2013-11-20 12:36 mkv Test case number => Not needed
2013-11-20 12:36 mkv Assigned To mkv => bugmaster
2013-11-20 12:36 mkv Status reviewed => tested
2013-11-25 13:17 bugmaster Changeset attached => occt master 51b10cd4
2013-11-25 13:17 bugmaster Status tested => verified
2013-11-25 13:17 bugmaster Resolution open => fixed
2013-12-19 13:50 bugmaster Status verified => closed
2013-12-19 13:59 bugmaster Fixed in Version => 6.7.0