View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024316 | Open CASCADE | OCCT:DRAW | public | 2013-11-05 08:15 | 2014-03-11 18:39 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | VC++ 2010 | ||
| Product Version | 6.7.0 | ||||
| Target Version | 6.7.0 | Fixed in Version | 6.7.0 | ||
| Summary | 0024316: Make building with different versions of Tcl easier | ||||
| Description | Tcl is different from other third-party libraries used by OCCT in that it uses version number of the package name as part of the name of its shared library. Hence, library name to be linked with OCCT depends on Tcl version used. Currently Tcl library name is hard-coded in WOK scripts, which causes problem (at least on Windows with MSVC, you have to change name of the library in properties of the generated project files) if you have different version of Tcl. It is highly desirable to have Tcl library name defined automatically for actual Tcl being used. With MSVC, it is possible using #pragma comment statement. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Fixes pushed to branch CR24316 in WOK repository and CR0-abv-IR-2013-11-01 in OCCT repository, please review |
|
|
I have no objections against the patch, although only Windows platform has been modified. I consider using "-framework Tcl, -framework Tk" on Mac OS X platform and detection of tcl85 on Linux platform, since 8.6 is not yet mainstream - in dedicated patch. |
|
occt: master 6a0964c2 2013-11-05 05:48:27
Committer: abv Details Diff |
0024316: Make building with different versions of Tcl easier On Windows with MSVC Tcl library is linked using #pragma statement instead of using project properties, to allow easy switch between Tcl versions. In gendoc.bat, tclsh.exe is called instead of tclsh86.exe, to avoid dependency on hard-coded Tcl version. Tcl-dependent code (unused functions) removed from QABugs package. |
Affected Issues 0024316 |
|
| mod - gendoc.bat | Diff File | ||
| mod - src/Draw/Draw.cxx | Diff File | ||
| mod - src/QABugs/QABugs_11.cxx | Diff File | ||
| mod - src/QABugs/QABugs_13.cxx | Diff File | ||
| mod - src/QABugs/QABugs_3.cxx | Diff File | ||
| mod - src/QABugs/QABugs_4.cxx | Diff File | ||
| mod - src/QADraw/QADraw.cxx | Diff File | ||
| mod - src/TKQADraw/EXTERNLIB | Diff File | ||
| mod - tests/bugs/vis/buc60661 | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-11-05 08:15 |
|
New Issue | |
| 2013-11-05 08:15 |
|
Assigned To | => mkv |
| 2013-11-05 13:48 |
|
Note Added: 0026454 | |
| 2013-11-05 13:48 |
|
Assigned To | mkv => kgv |
| 2013-11-05 13:48 |
|
Status | new => resolved |
| 2013-11-05 14:03 | kgv | Note Added: 0026457 | |
| 2013-11-05 14:03 | kgv | Assigned To | kgv => bugmaster |
| 2013-11-05 14:03 | kgv | Status | resolved => reviewed |
| 2013-11-06 11:07 |
|
Changeset attached | => occt master 6a0964c2 |
| 2013-11-06 11:07 |
|
Assigned To | bugmaster => abv |
| 2013-11-06 11:07 |
|
Status | reviewed => verified |
| 2013-11-06 11:07 |
|
Resolution | open => fixed |
| 2013-12-19 13:51 | bugmaster | Status | verified => closed |
| 2013-12-19 13:58 | bugmaster | Fixed in Version | => 6.7.0 |
| 2014-03-11 18:39 | kgv | Relationship added | related to 0024713 |
