0024293: Dimension flyout lines don't belong to the dimension sensitive entity.

ID	Project	Category	View Status	Date Submitted	Last Update

0024293	Open CASCADE	OCCT:Visualization	public	2013-10-28 14:04	2013-12-19 13:59

Reporter	~~aba~~	Assigned To	bugmaster
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Platform	A	OS	L
Target Version	6.7.0	Fixed in Version	6.7.0

Summary	0024293: Dimension flyout lines don't belong to the dimension sensitive entity.
Description	In default selection mode dimension flyout lines should be a part of the dimension sensitive entity. Now they are not selectable, they are only highlighted in default selection mode, when another part of dimension is detected.
Additional information and documentation updates	Changes: Computing of selection for dimensions has been changed. In the base class AIS_Dimension computeFlyoutSelection () has been added to add flyout sensitive in the default selection mode. This method has been overwritten for AIS_AngleDimension to provide selection of specific flyout lines. In this scope flyout field has been moved to AIS_Dimension as common for all dimensions property. Test case was added to check if flyout lines of length dimension are selectable.
Tags	No tags attached.

Test case number	bugs vis(004) bug24293

~~aba~~ 2013-11-13 12:08 developer ~0026589	The branch CR24293 contains modification of dimension classes to add flyouts to dimension sensitive entity. Dear apl, please review.

~~apl~~ 2013-11-14 11:30 developer ~0026622	Dear Bugmaster, The branch is reviewed. Please test.

~~mkv~~ 2013-11-14 15:33 tester ~0026626	Dear BugMaster, Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms. SHA-1: edb4a086abea294182d10d421afd431861df0c90 There are compilation errors on Linux platform: http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_linux/1/parsed_console/? ../../../../src/AIS/AIS_AngleDimension.cxx: In constructor ‘AIS_AngleDimension::AIS_AngleDimension(const TopoDS_Edge&, const TopoDS_Edge&, const gp_Pln&, const Handle_Prs3d_DimensionAspect&, Standard_Real)’: ../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected ‘{’ before ‘myShapesNumber’ ../../../../src/AIS/AIS_AngleDimension.cxx: At global scope: ../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected constructor, destructor, or type conversion before ‘=’ token ../../../../src/AIS/AIS_AngleDimension.cxx:177: error: expected constructor, destructor, or type conversion before ‘=’ token ../../../../src/AIS/AIS_AngleDimension.cxx:178: error: expected constructor, destructor, or type conversion before ‘=’ token ../../../../src/AIS/AIS_AngleDimension.cxx:179: error: expected constructor, destructor, or type conversion before ‘(’ token ../../../../src/AIS/AIS_AngleDimension.cxx:180: error: expected declaration before ‘}’ token There is compilation error on Windows platform: http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_windows/1/parsed_console/? 34>..\..\..\src\AIS\AIS_AngleDimension.cxx(229) : error C2059: syntax error : '{'

~~aba~~ 2013-11-14 16:34 developer ~0026631	Compilation errors were fixed. Dear mkv, please retest.

~~mkv~~ 2013-11-18 14:54 tester ~0026693	Dear BugMaster, Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 62c39d6c5ddf446022d1733a491ea8b7e270b23e Number of compiler warnings: occt component : Linux: 318 (318 on master) Windows: 0 (0 on master) products component : Linux: 188 (188 on master) Windows: 287 (287 on master) Regressions/Differences: No regressions/differences Testing cases: http://occt-tests/CR24293-0-master-occt/Debian60-64/bugs/vis/bug24293.html http://occt-tests/CR24293-0-master-occt/Windows-32-VC9/bugs/vis/bug24293.html bugs vis(004) bug24293: OK Testing on Linux: Total MEMORY difference: 356584804 / 356528104 Total CPU difference: 43352.48000000008 / 42450.130000000434 Testing on Windows: Total MEMORY difference: 411756980 / 410771744 Total CPU difference: 30270.59375 / 30177.609375 There are not differences in images found by testdiff.

~~mkv~~ 2013-11-18 14:55 tester ~0026694	Dear apl, could you pleas revise result of bugs vis(004) bug24293

~~apl~~ 2013-11-18 15:10 developer ~0026700	Dear mkv, The results are OK. All of the dimension lines are sensitive to selection and highlighted properly.

~~mkv~~ 2013-11-18 15:32 tester ~0026704	OK. CR24293 is TESTED.

occt: master 62b6361a 2013-11-14 12:32:40 ~~aba~~ Committer: bugmaster Details Diff	0024293: Dimension extensions don't belong to the dimension sensitive entity: computeFlyoutSelection() method was added in AIS_Dimension and AIS_AngleDimension classes.	Affected Issues 0024293
	mod - src/AIS/AIS_AngleDimension.cxx	Diff File
	mod - src/AIS/AIS_AngleDimension.hxx	Diff File
	mod - src/AIS/AIS_DiameterDimension.cxx	Diff File
	mod - src/AIS/AIS_DiameterDimension.hxx	Diff File
	mod - src/AIS/AIS_Dimension.cxx	Diff File
	mod - src/AIS/AIS_Dimension.hxx	Diff File
	mod - src/AIS/AIS_LengthDimension.cxx	Diff File
	mod - src/AIS/AIS_LengthDimension.hxx	Diff File
	mod - src/AIS/AIS_RadiusDimension.cxx	Diff File
	mod - src/AIS/AIS_RadiusDimension.hxx	Diff File
	add - tests/bugs/vis/bug24293	Diff File

Date Modified	Username	Field	Change
2013-10-28 14:04	~~aba~~	New Issue
2013-10-28 14:04	~~aba~~	Assigned To	=> aba
2013-10-28 14:05	~~aba~~	Status	new => assigned
2013-11-13 12:08	~~aba~~	Note Added: 0026589
2013-11-13 12:08	~~aba~~	Assigned To	aba => apl
2013-11-13 12:08	~~aba~~	Status	assigned => resolved
2013-11-13 12:10	~~aba~~	Summary	Dimension extensions don't belong to the dimension sensitive entity. => Dimension flyout lines don't belong to the dimension sensitive entity.
2013-11-13 12:10	~~aba~~	Description Updated
2013-11-14 11:30	~~apl~~	Note Added: 0026622
2013-11-14 11:30	~~apl~~	Assigned To	apl => bugmaster
2013-11-14 11:30	~~apl~~	Status	resolved => reviewed
2013-11-14 11:52	~~mkv~~	Assigned To	bugmaster => mkv
2013-11-14 15:33	~~mkv~~	Note Added: 0026626
2013-11-14 15:33	~~mkv~~	Assigned To	mkv => aba
2013-11-14 15:33	~~mkv~~	Status	reviewed => assigned
2013-11-14 16:33	~~aba~~	Status	assigned => resolved
2013-11-14 16:34	~~aba~~	Note Added: 0026631
2013-11-14 16:35	~~aba~~	Assigned To	aba => mkv
2013-11-14 16:35	~~aba~~	Status	resolved => assigned
2013-11-14 16:58	~~aba~~	Status	assigned => resolved
2013-11-14 16:59	~~aba~~	Status	resolved => reviewed
2013-11-18 14:54	~~mkv~~	Note Added: 0026693
2013-11-18 14:55	~~mkv~~	Note Added: 0026694
2013-11-18 14:55	~~mkv~~	Test case number	=> bugs vis(004) bug24293
2013-11-18 14:55	~~mkv~~	Assigned To	mkv => apl
2013-11-18 14:55	~~mkv~~	Status	reviewed => feedback
2013-11-18 15:10	~~apl~~	Note Added: 0026700
2013-11-18 15:10	~~apl~~	Assigned To	apl => mkv
2013-11-18 15:10	~~apl~~	Status	feedback => reviewed
2013-11-18 15:32	~~mkv~~	Note Added: 0026704
2013-11-18 15:32	~~mkv~~	Assigned To	mkv => bugmaster
2013-11-18 15:32	~~mkv~~	Status	reviewed => tested
2013-11-18 17:21	~~aba~~	Additional Information Updated
2013-11-20 14:16	~~apl~~	Relationship added	related to 0024387
2013-11-25 13:17	bugmaster	Changeset attached	=> occt master 62b6361a
2013-11-25 13:17	bugmaster	Status	tested => verified
2013-11-25 13:17	bugmaster	Resolution	open => fixed
2013-11-25 13:19	bugmaster	Target Version	=> 6.7.0
2013-12-19 13:50	bugmaster	Status	verified => closed
2013-12-19 13:59	bugmaster	Fixed in Version	=> 6.7.0

View Issue Details

Relationships

Activities

Related Changesets

Issue History