View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0024272 | Open CASCADE | OCCT:Visualization | public | 2013-10-19 10:22 | 2016-04-20 15:48 |
Reporter | kgv | Assigned To | |||
Priority | normal | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Platform | A | OS | L | ||
Target Version | 7.0.0 | Fixed in Version | 7.0.0 | ||
Summary | 0024272: Provide basic text formatting routines for Font_BRepFont | ||||
Description | Font_BRepFont class is an atom for creation of BRep glyphs. The following functionality is still not yet implemented: - Text formatting tool, like OpenGl_TextFormatter. - Font management tool for Font_BRepFont instances sharing and caching. Notice that Font_BRepFont::RenderText() method should be removed since it has been introduced as temporary solution and contradicts to original design. | ||||
Steps To Reproduce | 3rdparty fonts B4 3rdparty fonts B5 | ||||
Additional information and documentation updates | The method Font_BRepFont::RenderText() created as temporary solution has been dropped. The method from the new class Font_BRepTextBuilder::Perform() should be used instead which takes optional formatter argument for text alignment. | ||||
Tags | No tags attached. | ||||
Test case number | 3rdparty fonts B4, B5 | ||||
|
Branch CR24272 has been created by isk. SHA-1: 505e195d7193e1790df55f63c95793949c816ec5 Detailed log of new commits: Author: isk Date: Wed Aug 12 15:34:42 2015 +0300 0024272: Provide basic text formatting routines for Font_BRepFont |
|
Test cases are missing. Please see tests 3rdparty\fonts\A5 and A6 as references for text formatting. |
|
Branch CR24272 has been updated by isk. SHA-1: 6453776a1533f9dc1a98acba9908513fd99ba3ee Detailed log of new commits: Author: isk Date: Thu Aug 13 10:09:37 2015 +0300 Test cases are updated. |
|
Dear Kirill, please review the branch CR24272. |
|
Branch CR24272 has been updated by isk. SHA-1: d3db6484bb57aedd428bc1e0c32885daac09022d Detailed log of new commits: Author: isk Date: Thu Aug 13 11:04:11 2015 +0300 Missing test cases are added. |
|
Branch CR24272 has been updated forcibly by isk. SHA-1: 7d2996dca01b056905e58106dbc04a88317fbd20 |
2015-08-13 14:22 developer |
B4.png (7,140 bytes) |
2015-08-13 14:22 developer |
B5.png (8,086 bytes) |
|
Please move back glyph rendering logic to the class Font_BRepFont for logic consistency with OpenGl_Font. Please use shaded presentation in these new test cases. |
|
Branch CR24272 has been updated by isk. SHA-1: 960843c3adcb7e47b338ca8e1e0db4d28de523a2 Detailed log of new commits: Author: isk Date: Fri Aug 14 12:43:13 2015 +0300 Move back glyph rendering logic to the class Font_BRepFont. The new test cases are used shaded presentation. |
|
Branch CR24272_1 has been created by isk. SHA-1: ebab6e525e7713f0c66019963ab97b4e4bd17a4e Detailed log of new commits: Author: isk Date: Fri Aug 14 13:27:42 2015 +0300 0024272: Provide basic text formatting routines for Font_BRepFont |
|
Dear Kirill, please review the branch CR24272_1. |
|
Branch CR24272_1 has been updated forcibly by isk. SHA-1: fb20d4cf54d9a314684c938c8980b2bf9c64ee15 |
|
Please test the patch. |
|
Dear BugMaster, Branch CR24272_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: fb20d4cf54d9a314684c938c8980b2bf9c64ee15 There are following compilation errors: Linux: http://jenkins-test-01.nnov.opencascade.com:8080/view/CR24272-1-master/job/CR24272-1-master_build_occt_products_linux/1/parsed_console/ ../../../../src/DxfData/DxfData_TranslateText.cxx:113:23: error: 'class Font_BRepFont' has no member named 'RenderText' Windows: http://jenkins-test-01.nnov.opencascade.com:8080/view/CR24272-1-master/job/CR24272-1-master_build_occt_products_windows_64/1/parsed_console/ ..\..\..\src\DxfData\DxfData_TranslateText.cxx(113): error C2039: 'RenderText' : is not a member of 'Font_BRepFont' Number of compiler warnings: occt component : Linux: 15 (15 on master) Windows: 0 (0 on master) Regressions/Differences/Improvements: No regressions/differences http://occt-tests/CR24272-1-master-occt-64/Debian70-64/bugs/moddata_1/bug22759.html bugs moddata_1 bug22759: FAILED (Killed by CPU limit) Testing cases: http://occt-tests/CR24272-1-master-occt-64/Debian70-64/3rdparty/fonts/B4.html http://occt-tests/CR24272-1-master-occt-64/Windows-64-VC10/3rdparty/fonts/B4.html 3rdparty fonts B4: OK http://occt-tests/CR24272-1-master-occt-64/Debian70-64/3rdparty/fonts/B5.html http://occt-tests/CR24272-1-master-occt-64/Windows-64-VC10/3rdparty/fonts/B5.html 3rdparty fonts B5: OK Testing on Linux: occt component : Total MEMORY difference: 91257910 / 90699573 [+0.62%] Total CPU difference: 17356.549999998944 / 17379.939999998933 [-0.13%] products component : Testing on Windows: occt component : Total MEMORY difference: 56855864 / 56857547 [-0.00%] Total CPU difference: 16544.420853299074 / 16438.496174299304 [+0.64%] products component : There are following differences in images found by testdiff. http://occt-tests/CR24272-1-master-occt-64/Debian70-64/diff-Debian70-64.html http://occt-tests/CR24272-1-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html IMAGE 3rdparty fonts B2: B2.png differs IMAGE 3rdparty fonts B1: B1.png differs IMAGE demo samples snowflake: snowflake.png differs IMAGE demo samples raytrace: raytrace.png differs IMAGE demo samples pencil: pencil.png differs IMAGE demo samples bottle: bottle.png differs |
|
Dear isk, could you please review following test case 3rdparty fonts B4, B5 |
|
Branch CR24272_1 has been updated by isk. SHA-1: 92942ccacd2b0d5106d96b17f94b04e88897cb5b Detailed log of new commits: Author: isk Date: Tue Aug 18 15:50:17 2015 +0300 Font_TextFormatter supports Graphic3d_VTA_TOPFIRSTLINE vertical alignment now. Samples and tests are updated. |
|
Branch CR24272_2 has been created by isk. SHA-1: f7a8799ce73d0ab28274607925ed872b3790d841 Detailed log of new commits: Author: isk Date: Wed Aug 19 13:25:31 2015 +0300 0024272: Provide basic text formatting routines for Font_BRepFont |
|
Branch CR24272_1 has been updated by isk. SHA-1: a81ca41e8f29f550702c2bf9e6bda2b48fd9e2b2 Detailed log of new commits: Author: isk Date: Wed Aug 19 13:49:05 2015 +0300 Missing comments are added. |
|
Branch CR24272_2 has been updated forcibly by isk. SHA-1: 66cf3435f37cff5b06186fa8c9de470c4a9bebbd |
|
Dear Kirill, please review the branch CR24272_2. Dear mkv, test cases 3rdparty fonts B4, B5 is ok. Please note that same branch was created in products. |
|
Branch CR24272_2 has been updated forcibly by isk. SHA-1: c1cf75c2315199def1e3aa6d3248f21aa9859ab5 |
|
Please test the patch. |
|
Branch CR24272_2 has been updated forcibly by isk. SHA-1: 8afbeeb02c53e66fdb2afac0607bb993cb638c52 |
|
Branch CR24272_2 has been updated forcibly by mkv. SHA-1: a0da51a9e16a0bb60609a48de12150ebb0302f97 |
|
Dear BugMaster, Branch CR24272_2 was rebased on current master of occt git-repository. SHA-1: a0da51a9e16a0bb60609a48de12150ebb0302f97 Branch CR24272_2was rebased on current master of products git-repository. SHA-1: 1b9cc7174846147a7d03ecae6bae47d08bc79540 |
|
Dear BugMaster, Branch CR24272_2 from occt git-repository (and CR24272_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: a0da51a9e16a0bb60609a48de12150ebb0302f97 SHA-1: 1b9cc7174846147a7d03ecae6bae47d08bc79540 Number of compiler warnings: occt component : Linux: 16 (15 on master) Windows: 0 (0 on master) products component : Linux: 39 (39 on master) Windows: 0 (0 on master) There is new additional compilation warning on Linux platform: http://jenkins-test-01.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_17008/job/CR24272-2-CR24272-2_build_occt_linux/1/warnings17Result/package.-827222790/ Font_TextFormatter.cxx:311, GNU C Compiler 4 (gcc), Priority: Normal comparison between 'enum Graphic3d_HorizontalTextAlignment' and 'enum Graphic3d_VerticalTextAlignment' [-Wenum-compare] Regressions/Differences/Improvements: No regressions/differences Testing cases: http://occt-tests/CR24272-2-CR24272-2-occt-64/Debian70-64/3rdparty/fonts/B4.html http://occt-tests/CR24272-2-CR24272-2-occt-64/Windows-64-VC10/3rdparty/fonts/B4.html 3rdparty fonts B4: OK http://occt-tests/CR24272-2-CR24272-2-occt-64/Debian70-64/3rdparty/fonts/B5.html http://occt-tests/CR24272-2-CR24272-2-occt-64/Windows-64-VC10/3rdparty/fonts/B5.html 3rdparty fonts B5: OK Testing on Linux: occt component : Total MEMORY difference: 91658782 / 91600072 [+0.06%] Total CPU difference: 17675.139999999003 / 17713.799999998944 [-0.22%] products component : Total MEMORY difference: 25103457 / 25123208 [-0.08%] Total CPU difference: 7242.059999999998 / 7008.090000000001 [+3.34%] Testing on Windows: occt component : Total MEMORY difference: 57066523 / 57054130 [+0.02%] Total CPU difference: 16511.629443098976 / 16696.475027999113 [-1.11%] products component : Total MEMORY difference: 16121854 / 16119994 [+0.01%] Total CPU difference: 5152.588229199957 / 5290.8519154999685 [-2.61%] There are following differences in images found by testdiff. http://occt-tests/CR24272-2-CR24272-2-occt-64/Debian70-64/diff-Debian70-64.html http://occt-tests/CR24272-2-CR24272-2-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html IMAGE 3rdparty fonts A6: A6.png differs IMAGE 3rdparty fonts A5: A5.png differs IMAGE 3rdparty fonts A2: A2.png differs IMAGE bugs vis bug23652: bug23652_Driver1_Viewer1_View1.png differs |
|
Branch CR24272_2 has been updated by isk. SHA-1: 3c2018a9730df53f9c330f9fb12d50e1863d7a68 Detailed log of new commits: Author: isk Date: Mon Aug 24 14:08:51 2015 +0300 Fix condition. |
|
Branch CR24272_3 has been created by isk. SHA-1: 75fea96c4b0bb27e8cba61b686837957d45f87aa Detailed log of new commits: Author: isk Date: Mon Aug 24 14:10:22 2015 +0300 0024272: Provide basic text formatting routines for Font_BRepFont Add new class Font_BRepTextBuilder for generation of formatted BRep text. Delete method Font_BRepFont::RenderText(), which should be replaced by Font_BRepTextBuilder::Perform(). |
|
Dear Kirill, please review the branch CR24272_3. |
|
Please test CR24272_3. |
|
Dear BugMaster, Branch CR24272_3 from occt git-repository (and CR24272_2from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 75fea96c4b0bb27e8cba61b686837957d45f87aa SHA-1: 1b9cc7174846147a7d03ecae6bae47d08bc79540 There are following compilation errors: Linux: http://jenkins-test-01.nnov.opencascade.com:8080/view/CR24272-3-CR24272-2/job/CR24272-3-CR24272-2_build_occt_products_linux/1/parsed_console/ ../../../../src/DxfData/DxfData_TranslateText.cxx:113:23: error: 'class Font_BRepFont' has no member named 'RenderText' Windows: http://jenkins-test-01.nnov.opencascade.com:8080/view/CR24272-3-CR24272-2/job/CR24272-3-CR24272-2_build_occt_products_windows_64/1/parsed_console/ 42>..\..\..\src\DxfData\DxfData_TranslateText.cxx(113): error C2039: 'RenderText' : is not a member of 'Font_BRepFont' MacOS: |
|
Dear tester, please use the branch CR24272_3 in products. |
|
Dear BugMaster, Branch CR24272_3 from occt git-repository (and CR24272_3 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 75fea96c4b0bb27e8cba61b686837957d45f87aa SHA-1: 5daff017e8d9f89a1eb1a10cfb9a4874c604cdd3 Number of compiler warnings: occt component : Linux: 15 (15 on master) Windows: 0 (0 on master) products component : Linux: 39 (39 on master) Windows: 0 (0 on master) Regressions/Differences/Improvements: No regressions/differences Testing cases: http://occt-tests/CR24272-3-CR24272-3-occt-64/Debian70-64/3rdparty/fonts/B4.html http://occt-tests/CR24272-3-CR24272-3-occt-64/Windows-64-VC10/3rdparty/fonts/B4.html 3rdparty fonts B4: OK http://occt-tests/CR24272-3-CR24272-3-occt-64/Debian70-64/3rdparty/fonts/B5.html http://occt-tests/CR24272-3-CR24272-3-occt-64/Windows-64-VC10/3rdparty/fonts/B5.html 3rdparty fonts B5: OK Testing on Linux: occt component : Total MEMORY difference: 91440034 / 91601211 [-0.18%] Total CPU difference: 17791.149999999066 / 17713.829999998943 [+0.44%] products component : Total MEMORY difference: 25101554 / 25107260 [-0.02%] Total CPU difference: 7381.319999999997 / 7004.540000000001 [+5.38%] Testing on Windows: occt component : Total MEMORY difference: 57066871 / 57054373 [+0.02%] Total CPU difference: 16209.25270479927 / 16696.506228199112 [-2.92%] products component : Total MEMORY difference: 16128137 / 16126279 [+0.01%] Total CPU difference: 5350.506697899982 / 5292.115523599969 [+1.10%] There are no differences in images found by testdiff. |
|
Branch CR24272 has been deleted by kgv. SHA-1: 960843c3adcb7e47b338ca8e1e0db4d28de523a2 |
|
Branch CR24272_1 has been deleted by kgv. SHA-1: a81ca41e8f29f550702c2bf9e6bda2b48fd9e2b2 |
|
Branch CR24272_2 has been deleted by kgv. SHA-1: 3c2018a9730df53f9c330f9fb12d50e1863d7a68 |
|
Branch CR24272_3 has been deleted by kgv. SHA-1: 75fea96c4b0bb27e8cba61b686837957d45f87aa |
occt: master ac84fcf6 2015-08-24 11:10:22
Committer: |
0024272: Provide basic text formatting routines for Font_BRepFont Add new class Font_BRepTextBuilder for generation of formatted BRep text. Delete method Font_BRepFont::RenderText(), which should be replaced by Font_BRepTextBuilder::Perform(). |
Affected Issues 0024272 |
|
mod - samples/tcl/bottle.tcl | Diff File | ||
mod - samples/tcl/cpu.tcl | Diff File | ||
mod - samples/tcl/pencil.tcl | Diff File | ||
mod - samples/tcl/snowflake.tcl | Diff File | ||
mod - src/AIS/AIS_Dimension.cxx | Diff File | ||
mod - src/Font/FILES | Diff File | ||
mod - src/Font/Font_BRepFont.cxx | Diff File | ||
mod - src/Font/Font_BRepFont.hxx | Diff File | ||
add - src/Font/Font_BRepTextBuilder.cxx | Diff File | ||
add - src/Font/Font_BRepTextBuilder.hxx | Diff File | ||
mod - src/Font/Font_TextFormatter.cxx | Diff File | ||
mod - src/Graphic3d/Graphic3d_VerticalTextAlignment.hxx | Diff File | ||
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx | Diff File | ||
mod - tests/3rdparty/fonts/B1 | Diff File | ||
mod - tests/3rdparty/fonts/B2 | Diff File | ||
mod - tests/3rdparty/fonts/B3 | Diff File | ||
add - tests/3rdparty/fonts/B4 | Diff File | ||
add - tests/3rdparty/fonts/B5 | Diff File | ||
mod - tests/bugs/vis/bug25783_1 | Diff File | ||
mod - tests/bugs/vis/bug25783_2 | Diff File | ||
mod - tests/bugs/vis/bug26149 | Diff File | ||
mod - tests/v3d/raytrace/bug24819 | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-10-19 10:22 | kgv | New Issue | |
2013-10-19 10:22 | kgv | Assigned To | => san |
2014-04-04 18:34 |
|
Target Version | 6.7.1 => 6.8.0 |
2014-09-26 11:26 |
|
Target Version | 6.8.0 => 7.1.0 |
2015-07-16 15:21 | kgv | Assigned To | san => isk |
2015-07-16 15:21 | kgv | Status | new => assigned |
2015-07-16 15:21 | kgv | Product Version | 6.7.0 => |
2015-07-16 15:21 | kgv | Target Version | 7.1.0 => 7.0.0 |
2015-08-12 15:35 | git | Note Added: 0044037 | |
2015-08-12 15:36 |
|
Assigned To | isk => kgv |
2015-08-12 15:36 |
|
Status | assigned => resolved |
2015-08-12 15:36 |
|
Steps to Reproduce Updated | |
2015-08-12 15:58 | kgv | Note Added: 0044038 | |
2015-08-12 15:58 | kgv | Assigned To | kgv => isk |
2015-08-12 15:58 | kgv | Status | resolved => assigned |
2015-08-12 15:58 | kgv | Steps to Reproduce Updated | |
2015-08-13 10:11 | git | Note Added: 0044061 | |
2015-08-13 10:13 |
|
Note Added: 0044062 | |
2015-08-13 10:13 |
|
Assigned To | isk => kgv |
2015-08-13 10:13 |
|
Status | assigned => resolved |
2015-08-13 10:13 |
|
Steps to Reproduce Updated | |
2015-08-13 10:18 | kgv | Assigned To | kgv => isk |
2015-08-13 10:18 | kgv | Status | resolved => assigned |
2015-08-13 11:04 | git | Note Added: 0044066 | |
2015-08-13 14:21 | git | Note Added: 0044080 | |
2015-08-13 14:22 |
|
File Added: B4.png | |
2015-08-13 14:22 |
|
File Added: B5.png | |
2015-08-13 14:23 |
|
Assigned To | isk => kgv |
2015-08-13 14:23 |
|
Status | assigned => resolved |
2015-08-13 14:44 | kgv | Note Added: 0044086 | |
2015-08-13 14:44 | kgv | Assigned To | kgv => isk |
2015-08-13 14:44 | kgv | Status | resolved => assigned |
2015-08-13 14:46 | kgv | Note Edited: 0044086 | |
2015-08-14 12:43 | git | Note Added: 0044306 | |
2015-08-14 13:31 | git | Note Added: 0044308 | |
2015-08-14 13:33 |
|
Note Added: 0044309 | |
2015-08-14 13:33 |
|
Assigned To | isk => kgv |
2015-08-14 13:33 |
|
Status | assigned => resolved |
2015-08-14 13:33 |
|
Steps to Reproduce Updated | |
2015-08-14 15:08 | git | Note Added: 0044311 | |
2015-08-14 15:37 | kgv | Note Added: 0044312 | |
2015-08-14 15:37 | kgv | Assigned To | kgv => bugmaster |
2015-08-14 15:37 | kgv | Status | resolved => reviewed |
2015-08-14 15:54 |
|
Assigned To | bugmaster => mkv |
2015-08-17 16:34 |
|
Note Added: 0044344 | |
2015-08-17 16:34 |
|
Assigned To | mkv => isk |
2015-08-17 16:34 |
|
Status | reviewed => assigned |
2015-08-17 16:34 |
|
Note Added: 0044345 | |
2015-08-17 16:35 |
|
Test case number | => 3rdparty fonts B4, B5 |
2015-08-19 13:24 | git | Note Added: 0044422 | |
2015-08-19 13:25 | git | Note Added: 0044423 | |
2015-08-19 13:49 | git | Note Added: 0044428 | |
2015-08-19 13:52 | git | Note Added: 0044431 | |
2015-08-19 14:00 |
|
Note Added: 0044432 | |
2015-08-19 14:00 |
|
Assigned To | isk => kgv |
2015-08-19 14:00 |
|
Status | assigned => resolved |
2015-08-19 14:40 | git | Note Added: 0044433 | |
2015-08-19 14:43 | kgv | Note Added: 0044434 | |
2015-08-19 14:43 | kgv | Assigned To | kgv => bugmaster |
2015-08-19 14:43 | kgv | Status | resolved => reviewed |
2015-08-19 14:47 | kgv | Additional Information Updated | |
2015-08-19 15:23 | git | Note Added: 0044435 | |
2015-08-19 16:35 |
|
Assigned To | bugmaster => mkv |
2015-08-21 15:23 | git | Note Added: 0044505 | |
2015-08-24 12:47 |
|
Note Added: 0044535 | |
2015-08-24 12:47 |
|
Note Added: 0044536 | |
2015-08-24 12:47 |
|
Assigned To | mkv => isk |
2015-08-24 12:47 |
|
Status | reviewed => assigned |
2015-08-24 14:09 | git | Note Added: 0044540 | |
2015-08-24 14:19 | git | Note Added: 0044542 | |
2015-08-24 14:20 |
|
Note Added: 0044543 | |
2015-08-24 14:20 |
|
Assigned To | isk => kgv |
2015-08-24 14:20 |
|
Status | assigned => resolved |
2015-08-24 14:33 | kgv | Note Added: 0044544 | |
2015-08-24 14:33 | kgv | Assigned To | kgv => bugmaster |
2015-08-24 14:33 | kgv | Status | resolved => reviewed |
2015-08-24 15:03 |
|
Assigned To | bugmaster => mkv |
2015-08-24 18:21 |
|
Note Added: 0044570 | |
2015-08-24 18:21 |
|
Assigned To | mkv => isk |
2015-08-24 18:21 |
|
Status | reviewed => assigned |
2015-08-25 10:25 |
|
Note Added: 0044586 | |
2015-08-25 10:25 |
|
Assigned To | isk => kgv |
2015-08-25 10:25 |
|
Status | assigned => resolved |
2015-08-25 11:44 | kgv | Assigned To | kgv => bugmaster |
2015-08-25 11:44 | kgv | Status | resolved => reviewed |
2015-08-25 12:25 |
|
Assigned To | bugmaster => mkv |
2015-08-26 12:31 |
|
Note Added: 0044649 | |
2015-08-26 12:31 |
|
Assigned To | mkv => bugmaster |
2015-08-26 12:31 |
|
Status | reviewed => tested |
2015-08-28 11:44 |
|
Changeset attached | => occt master ac84fcf6 |
2015-08-28 11:44 |
|
Assigned To | bugmaster => ski |
2015-08-28 11:44 |
|
Status | tested => verified |
2015-08-28 11:44 |
|
Resolution | open => fixed |
2015-09-15 16:07 | kgv | Relationship added | parent of 0026690 |
2015-10-16 16:08 | git | Note Added: 0046845 | |
2015-10-16 16:08 | git | Note Added: 0046846 | |
2015-10-16 16:08 | git | Note Added: 0046847 | |
2015-10-16 16:08 | git | Note Added: 0046848 | |
2016-04-20 15:44 |
|
Fixed in Version | => 7.0.0 |
2016-04-20 15:48 |
|
Status | verified => closed |