View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024259Open CASCADEOCCT:Foundation Classespublic2013-10-15 06:532015-09-09 11:57
ReporterabvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2008 
Product Version6.7.0 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024259: Clean up OSD_File implementation
DescriptionCurrent implementation of OSD_FileNode and OSD_File is inconsistent between Linux and Windows as it uses the same field myFileChannel for file descriptor (int) on Linux and handle (void*) on Windows.
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0024724 closedkgv NT file routines in WOK use OSD_File::myFileChannel instead of myFileHandle 
related to 0013287 assignedski Compatinility problems in package OSD 

Activities

abv

2013-10-15 09:36

manager   ~0026077

Fix pushed to CR24259, please review

kgv

2013-10-15 10:31

developer   ~0026078

Patch is ready for testing.

mkv

2013-10-16 10:11

tester   ~0026097

Dear BugMaster,

Branch CR24259 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 2ab8677954233e0a3be4b7e8d85bde882f075c7b

Number of compiler warnings:

occt component :
Linux: 379 (370 on master)
Windows: 6 (6 on master)

products component :
Linux: 189 (191 on master)
Windows: 287 (287 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 353308548 / 353398924
Total CPU difference: 37487.36000000012 / 43385.60000000097

Testing on Windows:
Total MEMORY difference: 407067180 / 411317668
Total CPU difference: 32126.5625 / 37715.5625

There are not differences in images found by testdiff.

Related Changesets

occt: master 6ff736d8

2013-10-15 02:58:03

abv


Committer: bugmaster Details Diff		 0024259: Clean up OSD_File implementation

Field myFileChannel removed from OSD_FileNode and introduced to OSD_File as Linux-only along with Windows-only myFileHandle.
Implementation of OSD_File cleaned from redundant type casts; some missing type cases added.
File mode passed to fdopen() corrected in read-write case ("rw" replaced by "w+").
Method OSD_File::Size() now returns Standard_Size to be able to return correct value for large files (on 64-bit platforms only).		 Affected Issues
0024259
mod - src/OSD/OSD_File.cdl Diff File
mod - src/OSD/OSD_File.cxx Diff File
mod - src/OSD/OSD_FileNode.cdl Diff File
mod - src/OSD/OSD_FileNode.cxx Diff File
mod - src/RWStl/RWStl.cxx Diff File

Issue History

Date Modified Username Field Change
2013-10-15 06:53 abv New Issue
2013-10-15 06:53 abv Assigned To => abv
2013-10-15 09:36 abv Note Added: 0026077
2013-10-15 09:36 abv Assigned To abv => kgv
2013-10-15 09:36 abv Status new => resolved
2013-10-15 10:31 kgv Note Added: 0026078
2013-10-15 10:31 kgv Assigned To kgv => bugmaster
2013-10-15 10:31 kgv Status resolved => reviewed
2013-10-15 16:55 mkv Assigned To bugmaster => mkv
2013-10-16 10:11 mkv Note Added: 0026097
2013-10-16 10:12 mkv Test case number => Not needed
2013-10-16 10:12 mkv Assigned To mkv => bugmaster
2013-10-16 10:12 mkv Status reviewed => tested
2013-10-18 13:47 bugmaster Changeset attached => occt master 6ff736d8
2013-10-18 13:47 bugmaster Status tested => verified
2013-10-18 13:47 bugmaster Resolution open => fixed
2013-12-19 13:51 bugmaster Status verified => closed
2013-12-19 13:58 bugmaster Fixed in Version => 6.7.0
2014-03-13 14:42 kgv Relationship added related to 0024724
2015-09-09 11:57 abv Relationship added related to 0013287