View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024240Open CASCADEOCCT:Codingpublic2013-10-08 15:072014-11-11 12:52
ReporterskiAssigned Toapn  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformLinuxOSDebian 4.0 
Product Version6.6.0 
Target Version6.8.0Fixed in Version6.8.0 
Summary0024240: Separation of header files for QANCollection into hxx and cxx
DescriptionIt is necessary to separate header files for QANCollection into hxx and cxx files.
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0023880 closedbugmaster Integration of grid "ncl" into the new testing system 
related to 0024911 closedapn Avoid using virtual functions in NCollection classes 

Activities

ski

2013-10-16 15:41

developer   ~0026108

Issue was resolved. Changes are located in branch CR24240.
Please, review.

abv

2014-05-12 18:58

manager   ~0029288

Reviewed, please test branch CR24240_1 (rebased on current master and slightly refactored to keep original separation of command files 1-4, now given symbolic suffixes).

abv

2014-05-19 11:29

manager   ~0029383

I have pushed modified branch including fixes for 0024240 and 0024911 (based on fix for 0024831) into branch CR24240_2, please test that branch

apn

2014-05-20 15:58

administrator   ~0029414

There are compilation errors on PRODUCTS:

Linux:
../../../../src/Geodesic/Geodesic_MeshDistances.cxx: In member function ‘void Geodesic_MeshDistances::ValidatePath(NCollection_Sequence<gp_XYZ>&, NCollection_Sequence<Geodesic_MeshDistances::Link>&)’:
../../../../src/Geodesic/Geodesic_MeshDistances.cxx:725: error: ‘class NCollection_Sequence<gp_XYZ>::Iterator’ has no member named ‘Previous’
../../../../src/Geodesic/Geodesic_MeshDistances.cxx:726: error: ‘class NCollection_Sequence<Geodesic_MeshDistances::Link>::Iterator’ has no member named ‘Previous’

WNT:
..\..\..\src\OMFBool\OMFBool_DivideContour.cxx(81) : error C2061: syntax error : identifier 'NCollection_IncAllocator'
..\..\..\src\OMFAlgo\OMFAlgo_PlaneIntersect.cxx(142) : error C2065: 'Handle_NCollection_IncAllocator' : undeclared identifier
..\..\..\src\OMFAlgo\OMFAlgo_PlaneIntersect.cxx(142) : error C2146: syntax error : missing ';' before identifier 'anIncAlloc'
..\..\..\src\OMFAlgo\OMFAlgo_PlaneIntersect.cxx(142) : error C2065: 'anIncAlloc' : undeclared identifier
..\..\..\src\OMFAlgo\OMFAlgo_PlaneIntersect.cxx(142) : error C2061: syntax error : identifier 'NCollection_IncAllocator'
..\..\..\src\OMFAlgo\OMFAlgo_PlaneIntersect.cxx(144) : error C2065: 'anIncAlloc' : undeclared identifier

abv

2014-05-28 16:41

manager   ~0029581

Last edited: 2014-05-28 16:42

 Fix for 0024240 and 0024911 pushed to branch CR24240_3, please test

apn

2014-05-29 11:17

administrator   ~0029596

There are errors during PRODUCTS extraction:

=====> OMFCAF:xcpp.fill
.....
Info : Type used : /misc/dn61/LocalWOK/wok_entities/LOC/dev/CR24240-3-master-occt/src/PCDM/PCDM_Writer.cdl
Info : Type used : /misc/dn61/LocalWOK/wok_entities/LOC/dev/CR24240-3-master-occt/src/PCDM/PCDM_Reader.cdl
Error : the deferred method TDF_Attribute::Paste(TDF_Attribute,TDF_RelocationTable) must have an implementation in class OMFCAF_TMesh
Error : Check of OMFCAF has failed
Error : Failed during execution
Info : Step xcpp.fill
Error : Step xcpp.fill failed
Error : Step xcpp.src not done : almost OMFCAF:xcpp.fill failed

abv

2014-05-30 13:32

manager   ~0029621

Sorry, the build problem has been caused by the fact that branch CR24240 has been based on CR24830, while corresponding fix for products was not yet in master. Now 0024830 is integrated, please re-test branch CR24240_4 (the same as CR24240_3 rebased on current master).

abv

2014-05-30 16:22

manager   ~0029623

Please take also branch CR24240 in products repo

mkv

2014-06-03 20:19

tester   ~0029660

Dear BugMaster,

Branch CR24240_4 from occt git-repository and CR24240 from products-git repository are compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 57853a2497f73d5b19e1fc6831cc573cf52ef229
SHA-1: 41ebe07e833bf5108f998da1cc3b2f30257206d7

Number of compiler warnings:

occt component :
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (203 on master)

products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 348058560 / 361251064
Total CPU difference: 52501.73000000004 / 53203.02999999999

Testing on Windows:
Total MEMORY difference: 376167472 / 383786928
Total CPU difference: 44410.734375 / 42819.859375

There are no differences in images found by testdiff.

Related Changesets

occt: master 3a01a933

2014-05-12 12:08:36

abv


Committer: apn Details Diff		 0024240: Separation of header files for QANCollection into hxx and cxx

Files in QANCollection tests reorganized to avoid placing code in header files		 Affected Issues
0024240
mod - src/QANCollection/FILES Diff File
mod - src/QANCollection/QANCollection.cdl Diff File
mod - src/QANCollection/QANCollection.cxx Diff File
rm - src/QANCollection/QANCollection2.cxx Diff File
rm - src/QANCollection/QANCollection3.cxx Diff File
rm - src/QANCollection/QANCollectionTest.cxx Diff File
rm - src/QANCollection/QANCollection_Common2.hxx Diff File
rm - src/QANCollection/QANCollection_Common3.hxx Diff File
rm - src/QANCollection/QANCollection_FuncArrays.hxx Diff File
rm - src/QANCollection/QANCollection_FuncLists.hxx Diff File
rm - src/QANCollection/QANCollection_FuncMaps.hxx Diff File
rm - src/QANCollection/QANCollection_FuncTest.hxx Diff File
add - src/QANCollection/QANCollection_Perf.cxx Diff File
rm - src/QANCollection/QANCollection_PerfArrays.hxx Diff File
rm - src/QANCollection/QANCollection_PerfLists.hxx Diff File
rm - src/QANCollection/QANCollection_PerfMaps.hxx Diff File
rm - src/QANCollection/QANCollection_PerfSparseArray.hxx Diff File
rm - src/QANCollection/QANCollection_PerfTest.hxx Diff File
add - src/QANCollection/QANCollection_Test.cxx Diff File

Issue History

Date Modified Username Field Change
2013-10-08 15:07 ski New Issue
2013-10-08 15:07 ski Assigned To => ski
2013-10-08 15:07 ski Status new => assigned
2013-10-16 15:41 ski Note Added: 0026108
2013-10-16 15:41 ski Assigned To ski => abv
2013-10-16 15:41 ski Status assigned => resolved
2014-01-11 11:58 abv Category OCCT Release:BUILD => OCCT:Coding
2014-03-15 10:25 abv Relationship added related to 0023880
2014-04-04 17:11 abv Target Version => 6.8.0
2014-05-12 18:58 abv Note Added: 0029288
2014-05-12 18:58 abv Assigned To abv => bugmaster
2014-05-12 18:58 abv Status resolved => reviewed
2014-05-14 16:31 apn Assigned To bugmaster => apn
2014-05-19 11:29 abv Note Added: 0029383
2014-05-20 15:58 apn Note Added: 0029414
2014-05-20 15:58 apn Test case number => Not needed
2014-05-20 15:58 apn Assigned To apn => abv
2014-05-20 15:58 apn Status reviewed => assigned
2014-05-28 16:39 abv Relationship added related to 0024911
2014-05-28 16:41 abv Note Added: 0029581
2014-05-28 16:42 abv Status assigned => resolved
2014-05-28 16:42 abv Assigned To abv => bugmaster
2014-05-28 16:42 abv Status resolved => reviewed
2014-05-28 16:42 abv Note Edited: 0029581
2014-05-28 16:51 apn Assigned To bugmaster => apn
2014-05-29 11:17 apn Note Added: 0029596
2014-05-29 11:18 apn Assigned To apn => abv
2014-05-29 11:18 apn Status reviewed => assigned
2014-05-30 13:32 abv Note Added: 0029621
2014-05-30 13:32 abv Assigned To abv => bugmaster
2014-05-30 13:32 abv Status assigned => resolved
2014-05-30 13:32 abv Status resolved => reviewed
2014-05-30 15:12 apn Assigned To bugmaster => apn
2014-05-30 16:22 abv Note Added: 0029623
2014-06-03 20:19 mkv Note Added: 0029660
2014-06-03 20:20 mkv Assigned To apn => bugmaster
2014-06-03 20:20 mkv Status reviewed => tested
2014-06-06 12:04 apn Changeset attached => occt master 3a01a933
2014-06-06 12:04 apn Assigned To bugmaster => apn
2014-06-06 12:04 apn Status tested => verified
2014-06-06 12:04 apn Resolution open => fixed
2014-11-11 12:46 aiv Fixed in Version => 6.8.0
2014-11-11 12:52 aiv Status verified => closed