View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0024234 | Open CASCADE | OCCT:Modeling Algorithms | public | 2013-10-07 12:46 | 2014-06-10 17:50 |
| Reporter | bugmaster | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | VC++ 2005 | ||
| Target Version | 6.7.0 | Fixed in Version | 6.7.0 | ||
| Summary | 0024234: occt master is not compiled by VC++ 2005 (vc8 32/64 bit TKBO) | ||||
| Description | 1>------ Build started: Project: TKBO, Configuration: Release Win32 ------ 1>Compiling... 1>BOPAlgo_Builder_2.cxx 1>\\master\occ\products\occt-3rdparty\tbb30_018oss\include\tbb\critical_section.h(108) : error C3861: 'TryEnterCriticalSection': identifier not found 1>\\master\occ\products\occt-3rdparty\tbb30_018oss\include\tbb\mutex.h(37) : error C2365: 'TryEnterCriticalSection' : redefinition; previous definition was 'formerly unknown identifier' 1>\\master\occ\products\occt-3rdparty\tbb30_018oss\include\tbb\mutex.h(184) : error C3861: 'TryEnterCriticalSection': identifier not found 2>------ Build started: Project: TKDraw, Configuration: Release Win32 ------ 1>\\master\occ\products\occt-3rdparty\tbb30_018oss\include\tbb\recursive_mutex.h(37) : error C2365: 'TryEnterCriticalSection' : redefinition; previous definition was 'formerly unknown identifier' 1>\\master\occ\products\occt-3rdparty\tbb30_018oss\include\tbb\recursive_mutex.h(192) : error C3861: 'TryEnterCriticalSection': identifier not found 1>Build log was saved at "file://d:\new-wok-test-2\occt\win32\vc8\obj\TKBO\BuildLog.htm" 1>TKBO - 5 error(s), 0 warning(s) | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
| related to | 0024301 | closed | bugmaster | Open CASCADE | Provide support for generating projects for VS 2013 |
| related to | 0024718 | closed | bugmaster | Open CASCADE | Broken build on VC8 (VS 2005) if TBB is used |
| related to | 0024998 | closed | apn | Community | The incorrect _USE_MATH_DEFINES definition in Standard_math.hxx prevents the clean build for client applications |
|
|
According to tbb support: http://software.intel.com/en-us/forums/topic/289473 we should define _WIN32_WINNT on VS2005 (newer versions of PSDK define it implicitly but not VS2005) as it done in Standard_Mutex.cxx for example: #if ((defined(_WIN32) || defined(__WIN32__)) && !defined(_WIN32_WINNT)) #define _WIN32_WINNT 0x0400 #endif |
|
|
Fix pushed to branch CR24234 (contains also fixes for building by VS 2013), please review. |
|
|
Patch has been reviewed without remarks. Please test. |
|
|
Compilation of fix has been tested on all configuration of VS |
|
occt: master 008aef40 2013-10-30 20:44:20
Committer: bugmaster Details Diff |
0024234: occt master is not compiled by VC++ 2005 (vc8 32/64 bit TKBO) Fixed building by VS 2005 and VS 2013 (Express): - macro _WIN32_WINNT defined in BOPCol_TBB.hxx for building with TBB on VS 2005 - compiler warnings specific for VS 2005 (vc8) fixed (explicit casts added in assignment expressions involving small integer types) - definition of functions atanh, acosh, asinh is avoided for vc12 and later (they are provided by CRT in vc12) - math constants (M_PI and similar) are defined by including math.h rather than by custom code - misuse of stream operator << fixed in a few places |
Affected Issues 0024234 |
|
| mod - src/BOPCol/BOPCol_TBB.hxx | Diff File | ||
| mod - src/BSplSLib/BSplSLib.cxx | Diff File | ||
| mod - src/DDF/DDF_IOStream.cxx | Diff File | ||
| mod - src/FSD/FSD_File.cxx | Diff File | ||
| mod - src/Graphic3d/Graphic3d_MarkerImage.cxx | Diff File | ||
| mod - src/IGESData/IGESData_IGESWriter.cxx | Diff File | ||
| mod - src/IGESFile/liriges.c | Diff File | ||
| mod - src/ShapeFix/ShapeFix_ComposeShell.cxx | Diff File | ||
| mod - src/Standard/Standard_GUID.cxx | Diff File | ||
| mod - src/Standard/Standard_math.cxx | Diff File | ||
| mod - src/Standard/Standard_math.hxx | Diff File | ||
| mod - src/TDataStd/TDataStd_Integer.cxx | Diff File | ||
| mod - src/TopOpeBRepDS/TopOpeBRepDS_ProcessFaceInterferences.cxx | Diff File | ||
| mod - src/XmlObjMgt/XmlObjMgt.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-10-07 12:46 | bugmaster | New Issue | |
| 2013-10-07 12:46 | bugmaster | Assigned To | => ifv |
| 2013-10-07 12:47 | bugmaster | Status | new => assigned |
| 2013-10-07 12:49 | bugmaster | Summary | 0024233: occt master is not compiled by VC++ 2005 (vc8 32/64 bit TKBO) => occt master is not compiled by VC++ 2005 (vc8 32/64 bit TKBO) |
| 2013-10-07 12:49 | bugmaster | Project | OCCT => Open CASCADE |
| 2013-10-07 15:11 | kgv | Note Added: 0025938 | |
| 2013-10-17 14:37 | bugmaster | Assigned To | ifv => kgv |
| 2013-10-31 00:48 |
|
Note Added: 0026376 | |
| 2013-10-31 00:48 |
|
Status | assigned => resolved |
| 2013-10-31 01:01 |
|
Relationship added | related to 0024301 |
| 2013-10-31 09:32 | kgv | Note Added: 0026379 | |
| 2013-10-31 09:32 | kgv | Assigned To | kgv => bugmaster |
| 2013-10-31 09:32 | kgv | Status | resolved => reviewed |
| 2013-10-31 09:32 | kgv | OS | => VC++ 2005 |
| 2013-10-31 09:32 | kgv | OS Version | => 32 bit |
| 2013-10-31 09:32 | kgv | Platform | => Windows |
| 2013-10-31 09:32 | kgv | Target Version | => 6.7.0 |
| 2013-10-31 09:32 | kgv | Description Updated | |
| 2013-10-31 15:30 | bugmaster | Note Added: 0026395 | |
| 2013-10-31 15:30 | bugmaster | Status | reviewed => tested |
| 2013-11-06 11:07 | bugmaster | Changeset attached | => occt master 008aef40 |
| 2013-11-06 11:07 | bugmaster | Status | tested => verified |
| 2013-11-06 11:07 | bugmaster | Resolution | open => fixed |
| 2013-12-19 13:51 | bugmaster | Status | verified => closed |
| 2013-12-19 13:58 | bugmaster | Fixed in Version | => 6.7.0 |
| 2014-03-13 09:14 |
|
Relationship added | related to 0024718 |
| 2014-06-10 17:50 | kgv | Relationship added | related to 0024998 |
