View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024170Open CASCADEOCCT:Codingpublic2013-09-12 18:192013-12-19 13:57
ReporteromyAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformLinuxOSDebian 4.0 
Product Version6.6.0 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024170: Eliminate CLang compiler warning -Wunused local functions
DescriptionIt is necessary to eliminate warning -Wunused local function, shown by CLang compiler on Ubuntu 13.04
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0024162 closedabv Eliminate CLang compiler warning 

Activities

omy

2013-09-12 18:42

developer   ~0025555

Dear abv,
Please, review the branch CR24170

abv

2013-09-14 05:59

manager   ~0025574

I have reverted change in Visual3d_View.cxx since the code is suspicious and requires additional analysis to be corrected. Apart of this, no remarks, please test

mkv

2013-09-17 08:18

tester   ~0025594

Dear BugMaster,

Branch CR24170 was compiled on Linux platform.

There is compilation error:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24170/job/mnt-CR24170-master_build_occt_linux/1/parsed_console/?
../../../../inc/IntStart_SearchOnBoundaries_2.gxx:72: error: ‘BoundedArc’ was not declared in this scope

abv

2013-09-17 09:33

manager   ~0025596

I suggest gxx files IntStart_SearchOnBoundaries_1.gxx and IntStart_SearchOnBoundaries_2.gxx should be eliminated, with their code put to main IntStart_SearchOnBoundaries.gxx

omy

2013-09-17 12:17

developer   ~0025597

Dear abv,
Please, review the changes in branch CR24170.

abv

2013-09-17 12:28

manager   ~0025598

No remarks, please test

mkv

2013-09-18 09:42

tester   ~0025623

Dear BugMaster,

Branch CR24170 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: bab35ab859eae219e6d4903867c1e32df6ae47a9

Number of compiler warnings:

occt component :
Linux: 779 (790 on master)
Windows: 392 (392 on master)

products component :
Linux: 190 (190 on master)
Windows: 287 (287 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 365530240 / 366361780
Total CPU difference: 43597.40000000098 / 44238.54000000111

Testing on Windows:
Total MEMORY difference: 427313660 / 429125892
Total CPU difference: 41323.3125 / 39406.125

There are not differences in images found by testdiff.

Related Changesets

occt: master 74d80fb9

2013-09-17 06:03:19

abv


Committer: abv Details Diff		 0024170: Eliminate CLang compiler warning -Wunused local functions

Removed unreferenced local functions -Wunused
Removed self assignment
Merged IntStart_SearchOnBoundaries*.gxx files into one file.		 Affected Issues
0024170
mod - src/BRepMesh/BRepMesh_Classifier.cxx Diff File
mod - src/BRepMesh/BRepMesh_FastDiscret.cxx Diff File
mod - src/DNaming/DNaming_SelectionDriver.cxx Diff File
mod - src/Draw/Draw_GraphicCommands.cxx Diff File
rm - src/IntStart/FILES Diff File
mod - src/IntStart/IntStart_SearchOnBoundaries.gxx Diff File
rm - src/IntStart/IntStart_SearchOnBoundaries_1.gxx Diff File
rm - src/IntStart/IntStart_SearchOnBoundaries_2.gxx Diff File
mod - src/NCollection/NCollection_IncAllocator.cxx Diff File
mod - src/QABugs/QABugs_11.cxx Diff File
mod - src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx Diff File
mod - src/TNaming/TNaming_NamedShape.cxx Diff File

Issue History

Date Modified Username Field Change
2013-09-12 18:19 omy New Issue
2013-09-12 18:19 omy Assigned To => omy
2013-09-12 18:19 omy Relationship added related to 0024162
2013-09-12 18:42 omy Note Added: 0025555
2013-09-12 18:42 omy Assigned To omy => abv
2013-09-12 18:42 omy Status new => resolved
2013-09-14 05:59 abv Note Added: 0025574
2013-09-14 05:59 abv Assigned To abv => bugmaster
2013-09-14 05:59 abv Status resolved => reviewed
2013-09-16 16:41 mkv Assigned To bugmaster => mkv
2013-09-17 08:18 mkv Note Added: 0025594
2013-09-17 08:18 mkv Test case number => Not needed
2013-09-17 08:18 mkv Assigned To mkv => omy
2013-09-17 08:18 mkv Status reviewed => assigned
2013-09-17 09:33 abv Note Added: 0025596
2013-09-17 12:17 omy Note Added: 0025597
2013-09-17 12:17 omy Assigned To omy => abv
2013-09-17 12:17 omy Status assigned => resolved
2013-09-17 12:28 abv Note Added: 0025598
2013-09-17 12:28 abv Assigned To abv => bugmaster
2013-09-17 12:28 abv Status resolved => reviewed
2013-09-17 15:03 mkv Assigned To bugmaster => mkv
2013-09-18 09:42 mkv Note Added: 0025623
2013-09-18 09:42 mkv Assigned To mkv => bugmaster
2013-09-18 09:42 mkv Status reviewed => tested
2013-09-20 15:44 abv Changeset attached => occt master 74d80fb9
2013-09-20 15:44 abv Assigned To bugmaster => abv
2013-09-20 15:44 abv Status tested => verified
2013-09-20 15:44 abv Resolution open => fixed
2013-12-19 13:52 bugmaster Status verified => closed
2013-12-19 13:57 bugmaster Fixed in Version => 6.7.0
2014-01-11 11:58 abv Category OCCT Release:BUILD => OCCT:Coding