View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024025Open CASCADEOCCT:Modeling Algorithmspublic2013-06-13 11:082013-12-19 13:55
ReporteremvAssigned Toemv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024025: The method Modified2() in BRepAlgoAPI_BooleanOperation should be removed
DescriptionThe method BRepAlgoAPI_BooleanOperation::Modified2(const TopoDS_Shape& aS) is no longer relevant, because in the previous version of BOP it had used History collector to find modified shapes. There is no such collector in current version of BOP and thus this method should be removed.
The replacement for this method is BRepAlgoAPI_BooleanOperation::Modified(const TopoDS_Shape& aS).
TagsNo tags attached.
Test case numberNot needed

Activities

emv

2013-06-18 12:33

developer   ~0024784

Git branch CR24025 is ready to be reviewed (http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commit;h=cb8c24095ef29645082d1a9b73a8dac17ac84cef).

abv

2013-06-18 12:45

manager   ~0024785

No remarks, please test

mkv

2013-06-19 12:20

tester   ~0024796

Last edited: 2013-06-19 12:28

 Dear BugMaster,

Branch CR24025 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 7 (7 on master)

products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)

Regressions(???):
caf nam(008) A8
http://occt-tests/CR24025-master-occt/Debian60-64/caf/nam/A8.html
http://occt-tests/CR24025-master-occt/Windows-32-VC9/caf/nam/A8.html

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 365796188 / 365656192
Total CPU difference: 47316.46000000118 / 41188.11000000088

Testing on Windows:
Total MEMORY difference: 408865072 / 407697924
Total CPU difference: 40806.234375 / 35795.109375

There are not differences in images found by testdiff.

emv

2013-06-19 14:45

developer   ~0024800

Test case caf nam A8 is not a regression. It throws an exception on master (Standard_NumericError). The TODO marks in this test case should be updated.

mkv

2013-06-19 15:58

tester   ~0024802

Dear BugMaster,
Test case caf nam(008) A8 was corrected and pushed to branch CR24025.

Related Changesets

occt: master 5549deff

2013-06-20 11:48:11

emv

Details Diff		 0024025: The method Modified2() in BRepAlgoAPI_BooleanOperation should be removed.
Removed method BRepAlgoAPI_BooleanOperation::Modified2(const TopoDS_Shape& aS) as it is no longer relevant (in the previous version of BOP it had used History collector to find modified shapes, but there is no such collector in current version of BOP). The replacement for this method is BRepAlgoAPI_BooleanOperation::Modified(const TopoDS_Shape& aS).
Small correction of test case		 Affected Issues
0024025
mod - src/BRepAlgoAPI/BRepAlgoAPI_BooleanOperation.cdl Diff File
mod - src/BRepAlgoAPI/BRepAlgoAPI_BooleanOperation.cxx Diff File
mod - src/QANewBRepNaming/QANewBRepNaming_BooleanOperationFeat.cxx Diff File
mod - src/QANewBRepNaming/QANewBRepNaming_Loader.cxx Diff File
mod - src/QANewModTopOpe/QANewModTopOpe_Limitation.cdl Diff File
mod - src/QANewModTopOpe/QANewModTopOpe_Limitation.cxx Diff File

Issue History

Date Modified Username Field Change
2013-06-13 11:08 emv New Issue
2013-06-13 11:08 emv Assigned To => emv
2013-06-18 12:33 emv Note Added: 0024784
2013-06-18 12:33 emv Assigned To emv => abv
2013-06-18 12:33 emv Status new => resolved
2013-06-18 12:45 abv Note Added: 0024785
2013-06-18 12:45 abv Assigned To abv => bugmaster
2013-06-18 12:45 abv Status resolved => reviewed
2013-06-18 13:46 mkv Assigned To bugmaster => mkv
2013-06-19 12:20 mkv Note Added: 0024796
2013-06-19 12:21 mkv Test case number => Not needed
2013-06-19 12:21 mkv Assigned To mkv => emv
2013-06-19 12:21 mkv Status reviewed => feedback
2013-06-19 12:28 mkv Note Edited: 0024796
2013-06-19 14:45 emv Note Added: 0024800
2013-06-19 14:45 emv Assigned To emv => mkv
2013-06-19 14:45 emv Status feedback => assigned
2013-06-19 15:58 mkv Note Added: 0024802
2013-06-19 15:59 mkv Assigned To mkv => bugmaster
2013-06-19 15:59 mkv Status assigned => resolved
2013-06-19 15:59 mkv Status resolved => reviewed
2013-06-19 15:59 mkv Status reviewed => tested
2013-06-20 15:11 bugmaster Target Version => 6.7.0
2013-06-21 09:52 emv Changeset attached => occt master 5549deff
2013-06-21 09:52 emv Assigned To bugmaster => emv
2013-06-21 09:52 emv Status tested => verified
2013-06-21 09:52 emv Resolution open => fixed
2013-12-19 13:53 bugmaster Status verified => closed
2013-12-19 13:55 bugmaster Fixed in Version => 6.7.0