View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024004Open CASCADEOCCT:Modeling Algorithmspublic2013-05-30 10:072013-12-19 13:55
ReporteremvAssigned Toemv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024004: Initialization of arrays TPoints, TEdges, TTriangles of the class IntPolyh_MaillageAffinage by exact values
DescriptionThis issue is to implement two ideas for current version of OCCT:
1. Initialization of the arrays of the class IntPolyh_MaillageAffinage by exact values. The idea suggested by Roman Lygin (http://opencascade.blogspot.fr/2008/12/why-are-boolean-operations-so-sloooooow.html);
2. Optimizing for loops. Patch suggested by OCE team (https://github.com/tpaviot/oce/commit/7b19650b2902305709c5124823bd4b81331353f7).
TagsNo tags attached.
Test case numberNot needed

Activities

emv

2013-05-30 10:22

developer   ~0024559

Last edited: 2013-05-30 10:25

 Git branch CR24004 is ready to be reviewed (http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commit;h=8cbcf352baaf00b33387ff206a7f96681d09caa4).

abv

2013-05-30 10:36

manager   ~0024560

No remarks, please test

mkv

2013-06-03 17:05

tester   ~0024615

Dear BugMaster,

Branch CR24004 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 8cbcf352baaf00b33387ff206a7f96681d09caa4

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 366118068 / 366069124
Total CPU difference: 41874.71000000143 / 44999.37000000119

Testing on Windows:
Total MEMORY difference: 405267692 / 406570360
Total CPU difference: 33170.0 / 34856.3125

There are not differences in images found by testdiff.

Related Changesets

occt: master fee4fa0f

2013-05-30 06:19:57

emv

Details Diff		 0024004: Initialization of arrays TPoints, TEdges, TTriangles of the class IntPolyh_MaillageAffinage by exact values
This commit implements two ideas for current version of OCCT:
1. Initialization of the arrays of the class IntPolyh_MaillageAffinage by exact values. The idea suggested by Roman Lygin (http://opencascade.blogspot.fr/2008/12/why-are-boolean-operations-so-sloooooow.html [^]);
2. Optimizing for loops. The idea has been taken from OCE (https://github.com/tpaviot/oce/commit/7b19650b2902305709c5124823bd4b81331353f7 [^]).		 Affected Issues
0024004
mod - src/IntPolyh/IntPolyh_MaillageAffinage.cxx Diff File

Issue History

Date Modified Username Field Change
2013-05-30 10:07 emv New Issue
2013-05-30 10:07 emv Assigned To => emv
2013-05-30 10:22 emv Note Added: 0024559
2013-05-30 10:22 emv Assigned To emv => abv
2013-05-30 10:22 emv Status new => resolved
2013-05-30 10:25 emv Note Edited: 0024559
2013-05-30 10:36 abv Note Added: 0024560
2013-05-30 10:36 abv Assigned To abv => bugmaster
2013-05-30 10:36 abv Status resolved => reviewed
2013-05-30 15:02 bugmaster Assigned To bugmaster => mkv
2013-06-03 17:05 mkv Note Added: 0024615
2013-06-03 17:05 mkv Test case number => Not needed
2013-06-03 17:05 mkv Assigned To mkv => bugmaster
2013-06-03 17:05 mkv Status reviewed => tested
2013-06-06 10:02 bugmaster Target Version => 6.7.0
2013-06-10 10:30 emv Changeset attached => occt master fee4fa0f
2013-06-10 10:30 emv Assigned To bugmaster => emv
2013-06-10 10:30 emv Status tested => verified
2013-06-10 10:30 emv Resolution open => fixed
2013-12-19 13:53 bugmaster Status verified => closed
2013-12-19 13:55 bugmaster Fixed in Version => 6.7.0