View Issue Details

IDProjectCategoryView StatusLast Update
0023964Open CASCADEOCCT:Modeling Datapublic2013-12-19 13:57
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Product Version6.6.0 
Target Version6.7.0Fixed in Version6.7.0 
Summary0023964: Extrema_ExtXX::Point methods might return constant reference instead of copy
DescriptionMethod ::Point(const Standard_Integer N) might return constant reference instead of copy in the following classes:
Extrema_ExtPElC
Extrema_ExtPElC2d
Extrema_ExtPElS
Extrema_ExtPExtS
Extrema_ExtPRevS
Extrema_ExtPS
Extrema_ExtPSOfRev
TagsNo tags attached.
Test case numberNot needed

Activities

azv

2013-09-11 18:08

administrator   ~0025534

Branch: CR23964
Changed Point() methods to return constant reference

ifv

2013-09-11 18:50

developer   ~0025536

Ok

mkv

2013-09-12 13:03

tester   ~0025546

Dear BugMaster,

Branch CR23964 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 020dde22d46d0468fa7c9620dda9f15e79bfc39c

Number of compiler warnings:

occt component :
Linux: 783 (787 on master)
Windows: 393 (392 on master)

products component :
Linux: 190 (190 on master)
Windows: 287 (287 on master)

Regressions:
occt part
http://occt-tests/CR23964-master-occt/Debian60-64/summary.html
http://occt-tests/CR23964-master-occt/Windows-32-VC9/summary.html
products part
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR23964/job/mnt-CR23964-master_products_tests_linux_start/
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR23964/job/mnt-CR23964-master_products_tests_windows_start/

azv

2013-09-16 14:24

administrator   ~0025589

Changed method Extrema_GLocateExtPC::Point() to get off exceptions

ifv

2013-09-16 15:02

developer   ~0025592

Ok

mkv

2013-09-18 09:34

tester   ~0025621

Last edited: 2013-09-18 09:39

Dear BugMaster,

Branch CR23964 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: bb98e4ca9b357c8cb1d578601f4f5756fae7604e

Number of compiler warnings:

occt component :
Linux: 786 (790 on master)
Windows: 392 (392 on master)

products component :
Linux: 190 (190 on master)
Windows: 287 (287 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 366744580 / 366730580
Total CPU difference: 45364.280000000406 / 44238.20000000111

Testing on Windows:
Total MEMORY difference: 426660924 / 429311400
Total CPU difference: 48554.21875 / 39422.375

There are not differences in images found by testdiff.

Related Changesets

occt: master 5d99f2c8

2013-09-19 11:56:51

azv


Committer: bugmaster Details Diff
0023964: Extrema_ExtXX::Point methods might return constant reference instead of copy
Changed definitions of Point() functions
Removal of floating point exceptions from previous commit
Affected Issues
0023964
mod - src/Extrema/Extrema_ExtPElC.cdl Diff File
mod - src/Extrema/Extrema_ExtPElC.cxx Diff File
mod - src/Extrema/Extrema_ExtPElC2d.cdl Diff File
mod - src/Extrema/Extrema_ExtPElC2d.cxx Diff File
mod - src/Extrema/Extrema_ExtPElS.cdl Diff File
mod - src/Extrema/Extrema_ExtPElS.cxx Diff File
mod - src/Extrema/Extrema_ExtPExtS.cdl Diff File
mod - src/Extrema/Extrema_ExtPExtS.cxx Diff File
mod - src/Extrema/Extrema_ExtPRevS.cdl Diff File
mod - src/Extrema/Extrema_ExtPRevS.cxx Diff File
mod - src/Extrema/Extrema_ExtPS.cdl Diff File
mod - src/Extrema/Extrema_ExtPS.cxx Diff File
mod - src/Extrema/Extrema_ExtPSOfRev.cdl Diff File
mod - src/Extrema/Extrema_ExtPSOfRev.gxx Diff File
mod - src/Extrema/Extrema_FuncExtPC.cdl Diff File
mod - src/Extrema/Extrema_FuncExtPC.gxx Diff File
mod - src/Extrema/Extrema_FuncExtPS.cdl Diff File
mod - src/Extrema/Extrema_FuncExtPS.cxx Diff File
mod - src/Extrema/Extrema_FuncExtSS.cdl Diff File
mod - src/Extrema/Extrema_FuncExtSS.cxx Diff File
mod - src/Extrema/Extrema_GenExtPC.cdl Diff File
mod - src/Extrema/Extrema_GenExtPC.gxx Diff File
mod - src/Extrema/Extrema_GenExtPS.cdl Diff File
mod - src/Extrema/Extrema_GenExtPS.cxx Diff File
mod - src/Extrema/Extrema_GenExtSS.cdl Diff File
mod - src/Extrema/Extrema_GenExtSS.cxx Diff File
mod - src/Extrema/Extrema_GenLocateExtPC.cdl Diff File
mod - src/Extrema/Extrema_GenLocateExtPC.gxx Diff File
mod - src/Extrema/Extrema_GenLocateExtPS.cdl Diff File
mod - src/Extrema/Extrema_GenLocateExtPS.cxx Diff File
mod - src/Extrema/Extrema_GExtPC.cdl Diff File
mod - src/Extrema/Extrema_GExtPC.gxx Diff File
mod - src/Extrema/Extrema_GLocateExtPC.cdl Diff File
mod - src/Extrema/Extrema_GLocateExtPC.gxx Diff File

Issue History

Date Modified Username Field Change
2013-05-15 09:49 kgv New Issue
2013-05-15 09:49 kgv Assigned To => jgv
2013-05-15 12:30 abv Assigned To jgv => ifv
2013-05-15 12:30 abv Status new => assigned
2013-09-10 17:59 ifv Assigned To ifv => azv
2013-09-11 18:08 azv Note Added: 0025534
2013-09-11 18:08 azv Assigned To azv => ifv
2013-09-11 18:08 azv Status assigned => resolved
2013-09-11 18:50 ifv Note Added: 0025536
2013-09-11 18:50 ifv Status resolved => reviewed
2013-09-12 08:41 mkv Assigned To ifv => mkv
2013-09-12 13:03 mkv Note Added: 0025546
2013-09-12 13:03 mkv Test case number => Not needed
2013-09-12 13:03 mkv Assigned To mkv => azv
2013-09-12 13:03 mkv Status reviewed => assigned
2013-09-16 14:24 azv Note Added: 0025589
2013-09-16 14:24 azv Assigned To azv => ifv
2013-09-16 14:24 azv Status assigned => resolved
2013-09-16 15:02 ifv Note Added: 0025592
2013-09-16 15:02 ifv Status resolved => reviewed
2013-09-16 16:40 mkv Assigned To ifv => mkv
2013-09-18 09:34 mkv Note Added: 0025621
2013-09-18 09:34 mkv Assigned To mkv => bugmaster
2013-09-18 09:34 mkv Status reviewed => tested
2013-09-18 09:37 mkv Note Edited: 0025621
2013-09-18 09:39 mkv Note Edited: 0025621
2013-09-20 15:44 bugmaster Changeset attached => occt master 5d99f2c8
2013-09-20 15:44 bugmaster Status tested => verified
2013-09-20 15:44 bugmaster Resolution open => fixed
2013-12-19 13:52 bugmaster Status verified => closed
2013-12-19 13:57 bugmaster Fixed in Version => 6.7.0