View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023915Open CASCADEOCCT:Visualizationpublic2013-04-19 12:412013-12-19 13:55
ReporterdbvAssigned Todbv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.7.0Fixed in Version6.7.0 
Summary0023915: Redundant header inclusion
DescriptionV3d_PositionLight.cxx and V3d_SpotLight.cxx contains redundant WNT_Window/Xw_Window inclusion.
TagsNo tags attached.
Test case numberNot needed

Activities

dbv

2013-04-19 12:43

developer   ~0024221

Fix has been pushed to the occt git branch CR23915

Please review.

kgv

2013-04-19 12:49

developer   ~0024222

Patch has reviewed without remarks.

mkv

2013-04-25 15:46

tester   ~0024275

Dear BugMaster,

Branch CR23915 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: a7950925534458d8f7fac149b46364a8b5951bda


Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 64 (64 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 366121536 / 366591836
Total CPU difference: 43663.930000001244 / 54395.14000000041

Testing on Windows:
Total MEMORY difference: 420247800 / 419888816
Total CPU difference: 27809.828125 / 34632.125

There are not serious differences in images found by testdiff.

Related Changesets

occt: master b4def893

2013-04-19 08:42:51

dbv

Details Diff		 0023915: Redundant header inclusion
Removed redundant inclusion		 Affected Issues
0023915
mod - src/V3d/V3d_PositionLight.cxx Diff File
mod - src/V3d/V3d_SpotLight.cxx Diff File

Issue History

Date Modified Username Field Change
2013-04-19 12:41 dbv New Issue
2013-04-19 12:41 dbv Assigned To => san
2013-04-19 12:41 dbv Assigned To san => dbv
2013-04-19 12:41 dbv Status new => assigned
2013-04-19 12:43 dbv Note Added: 0024221
2013-04-19 12:43 dbv Assigned To dbv => kgv
2013-04-19 12:43 dbv Status assigned => resolved
2013-04-19 12:49 kgv Note Added: 0024222
2013-04-19 12:49 kgv Assigned To kgv => bugmaster
2013-04-19 12:49 kgv Status resolved => reviewed
2013-04-19 14:31 abv Target Version => 6.7.0
2013-04-25 15:46 mkv Note Added: 0024275
2013-04-25 15:47 mkv Test case number => Not needed
2013-04-25 15:47 mkv Status reviewed => tested
2013-04-30 10:28 dbv Changeset attached => occt master b4def893
2013-04-30 10:28 dbv Assigned To bugmaster => dbv
2013-04-30 10:28 dbv Status tested => verified
2013-04-30 10:28 dbv Resolution open => fixed
2013-12-19 13:53 bugmaster Status verified => closed
2013-12-19 13:55 bugmaster Fixed in Version => 6.7.0