View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023787Open CASCADEOCCT:Configurationpublic2013-02-21 22:022013-04-29 15:23
ReporterabvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2008 
Product Version6.5.4 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023787: Eliminate trivial type conversion warnings in MSVC
DescriptionOCCT code still has about 35 compiler warnings reported by MSVC++ 9.0 on casting of double to float, long to int etc., which can be easily eliminated
TagsNo tags attached.
Test case numberNot needed

Activities

abv

2013-02-22 07:47

manager   ~0023441

Most of remaining warnings of MS VC++ 9.0 in 32 bit mode corrected, please review

kgv

2013-02-22 10:21

developer   ~0023447

Patch was reviewed without remarks.

mkv

2013-02-28 14:17

tester   ~0023523

Dear BugMaster,

Branch CR23787 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: e4d9c45a7b94d1f6c4588b935d4dfa90ad6f11ae

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 12 (39 on master)

products component :
Linux: 9 (9 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 239728052 / 239606140
Total CPU difference: 27091.990000000027 / 16161.8599999998

Testing on Windows:
Total MEMORY difference: 343528848 / 343545904
Total CPU difference: 17490.09375 / 16749.0

There are not serious differences in images found by testdiff.

Related Changesets

occt: master 7f4c4756

2013-02-21 18:04:18

abv


Committer: abv Details Diff		 0023787: Eliminate trivial type conversion warnings in MSVC

Explicit type cast added in conversions from double to float in PrsMgr, Select3D, StdPrs, Visual3d, and Voxel.
Minor corrections in ShapeProcess and TCollection.
In Visual3d_ViewManager::ConvertCoord...(), output is initialized by zeros instead of RealLast() in case of failure.
In XmlMXCAFDoc, material density is correctly converted to string when writing to Xml.		 Affected Issues
0023787
mod - src/PrsMgr/PrsMgr_PresentableObject.cxx Diff File
mod - src/Select3D/Select3D_SensitiveGroup.cxx Diff File
mod - src/ShapeProcess/ShapeProcess_Context.cxx Diff File
mod - src/StdPrs/StdPrs_ToolShadedShape.cxx Diff File
mod - src/TCollection/TCollection_ExtendedString.cxx Diff File
mod - src/Visual3d/Visual3d_Layer.cxx Diff File
mod - src/Visual3d/Visual3d_View.cxx Diff File
mod - src/Visual3d/Visual3d_ViewManager.cxx Diff File
mod - src/Voxel/Voxel_Reader.cxx Diff File
mod - src/VrmlData/VrmlData_ShapeConvert.cxx Diff File
mod - src/XmlMXCAFDoc/XmlMXCAFDoc_MaterialDriver.cxx Diff File

Issue History

Date Modified Username Field Change
2013-02-21 22:02 abv New Issue
2013-02-21 22:02 abv Assigned To => bugmaster
2013-02-22 07:47 abv Note Added: 0023441
2013-02-22 07:47 abv Assigned To bugmaster => kgv
2013-02-22 07:47 abv Status new => resolved
2013-02-22 10:21 kgv Note Added: 0023447
2013-02-22 10:21 kgv Assigned To kgv => bugmaster
2013-02-22 10:21 kgv Status resolved => reviewed
2013-02-28 10:40 bugmaster Assigned To bugmaster => mkv
2013-02-28 14:17 mkv Note Added: 0023523
2013-02-28 14:17 mkv Test case number => Not needed
2013-02-28 14:17 mkv Assigned To mkv => bugmaster
2013-02-28 14:17 mkv Status reviewed => tested
2013-03-04 17:32 abv Changeset attached => occt master 7f4c4756
2013-03-04 17:32 abv Assigned To bugmaster => abv
2013-03-04 17:32 abv Status tested => verified
2013-03-04 17:32 abv Resolution open => fixed
2013-04-23 13:35 aiv Status verified => closed
2013-04-29 15:23 aiv Fixed in Version => 6.6.0
2014-01-11 11:58 abv Category OCCT:Development Environment => OCCT:Configuration