View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023690 | Community | OCCT:Application Framework | public | 2013-01-07 23:32 | 2013-04-29 15:22 |
| Reporter | Roman Lygin | Assigned To | Roman Lygin | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.4 | ||||
| Target Version | 6.6.0 | Fixed in Version | 6.6.0 | ||
| Summary | 0023690: Miscellaneous minor enhancements in OCAF/XDE | ||||
| Description | A set of a few minor enhancements mainly to positively affect performance. Grouped into commit to reduce integration overhead. TDF_Label - constructor made inline XCAFDoc_Color - GetColor() to return const& XCAFDoc_ColorTool - GetColor() returning a label made static XCAFDoc_Location - Get() to return const& | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Pushed into the git repository as branch CR23690 Of course, to benefit from these changes (except TDF_Label) the callers must be respectively updated. Inlining TDF_Label constructors will be used automatically during next compile |
|
|
No remarks, please test |
|
|
Dear BugMaster, There are compilation errors on Linux: http://jenkins-test-01.nnov.opencascade.com/user/mnt/my-views/view/CR23690/job/mnt-CR23690-master_build_occt_linux/2/parsed_console/? ../../../src/XCAFDoc/XCAFDoc_ColorTool.cxx: In static member function 'static Standard_Boolean XCAFDoc_ColorTool::GetColor(const TopoDS_Shape&, XCAFDoc_ColorType, TDF_Label&)': ../../../src/XCAFDoc/XCAFDoc_ColorTool.cxx:323: error: cannot call member function 'const Handle_XCAFDoc_ShapeTool& XCAFDoc_ColorTool::ShapeTool()' without object ../../../src/XCAFDoc/XCAFDoc_ColorTool.cxx:324: error: cannot call member function 'Standard_Boolean XCAFDoc_ColorTool::GetColor(const TDF_Label&, XCAFDoc_ColorType, TDF_Label&)' without object |
|
|
Sorry for the trouble. The fixed XCAFDoc_ColorTool.cdl has been updated in the branch CR23690 (with --force). The root-cause of the failure - wrong overload has been made static. The correct method is one accepting TDF_Label, not TopoDS_Shape. I have not caught the issue prior to committing as this .cdl change has not been promoted into my 6.5.4-based dev environment (to minimize API changes) and I do not built the git environment as there are no Visual Studio files. Neither do I use WOK other than for header extraction. |
|
|
Dear BugMaster, Branch CR23690 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed |
|
occt: master d97f89db 2013-01-18 09:47:00 Details Diff |
0023690: Miscellaneous minor enhancements in OCAF/XDE |
Affected Issues 0023690 |
|
| mod - src/TDF/TDF_Label.cdl | Diff File | ||
| mod - src/TDF/TDF_Label.cxx | Diff File | ||
| mod - src/TDF/TDF_Label.lxx | Diff File | ||
| mod - src/XCAFDoc/XCAFDoc_Color.cdl | Diff File | ||
| mod - src/XCAFDoc/XCAFDoc_Color.cxx | Diff File | ||
| mod - src/XCAFDoc/XCAFDoc_ColorTool.cdl | Diff File | ||
| mod - src/XCAFDoc/XCAFDoc_Location.cdl | Diff File | ||
| mod - src/XCAFDoc/XCAFDoc_Location.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-01-07 23:32 | Roman Lygin | New Issue | |
| 2013-01-07 23:32 | Roman Lygin | Assigned To | => szy |
| 2013-01-07 23:48 | Roman Lygin | Note Added: 0022908 | |
| 2013-01-07 23:48 | Roman Lygin | Status | new => resolved |
| 2013-01-08 11:01 |
|
Note Added: 0022909 | |
| 2013-01-08 11:01 |
|
Status | resolved => reviewed |
| 2013-01-10 16:25 |
|
Note Added: 0022933 | |
| 2013-01-10 16:25 |
|
Test case number | => Not needed |
| 2013-01-10 16:25 |
|
Assigned To | szy => abv |
| 2013-01-10 16:25 |
|
Status | reviewed => assigned |
| 2013-01-10 16:32 |
|
Assigned To | abv => Roman Lygin |
| 2013-01-10 23:17 | Roman Lygin | Note Added: 0022937 | |
| 2013-01-10 23:17 | Roman Lygin | Assigned To | Roman Lygin => mkv |
| 2013-01-10 23:17 | Roman Lygin | Status | assigned => resolved |
| 2013-01-11 12:57 |
|
Status | resolved => reviewed |
| 2013-01-17 15:24 |
|
Note Added: 0023006 | |
| 2013-01-17 15:26 |
|
Assigned To | mkv => bugmaster |
| 2013-01-17 15:26 |
|
Status | reviewed => tested |
| 2013-01-21 18:29 | Roman Lygin | Changeset attached | => occt master d97f89db |
| 2013-01-21 18:29 | Roman Lygin | Assigned To | bugmaster => Roman Lygin |
| 2013-01-21 18:29 | Roman Lygin | Status | tested => verified |
| 2013-01-21 18:29 | Roman Lygin | Resolution | open => fixed |
| 2013-02-20 10:19 | bugmaster | Target Version | => 6.6.0 |
| 2013-04-23 13:35 |
|
Status | verified => closed |
| 2013-04-29 15:22 |
|
Fixed in Version | => 6.6.0 |
