View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023678Open CASCADEOCCT:Modeling Algorithmspublic2012-12-28 18:092013-04-29 15:21
ReporterabvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2008 
Product Version6.6.0 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023678: Compiler warning in BRepFill_Pipe::ShareFaces()
DescriptionThe method BRepFill_Pipe::ShareFaces() added in #23606 contains dirty code for which compiler (MSVC 9) reports three warnings:

34>..\..\..\src\BRepFill\BRepFill_Pipe.cxx(808) : warning C4553: '==' : operator has no effect; did you intend '='?
34>..\..\..\src\BRepFill\BRepFill_Pipe.cxx(852) : warning C4553: '==' : operator has no effect; did you intend '='?
34>..\..\..\src\BRepFill\BRepFill_Pipe.cxx(846) : warning C4101: 'indV' : unreferenced local variable
TagsNo tags attached.
Test case numberNot needed

Relationships

has duplicate 0023685 closedskv Community Comparision operator (==) instead of assignment (=) used 

Activities

abv

2012-12-28 18:13

manager   ~0022885

Correction pushed to branch CR23678; please review

skv

2012-12-29 12:06

developer   ~0022887

Just one remark:
Line 847:

 Standard_Integer je = (i == 1 ? myEdges->RowLength());

should be replaced by:

 Standard_Integer je = (i == 1 ? 1 : myEdges->RowLength());

Please fix it.

abv

2012-12-29 12:19

manager   ~0022888

Error corrected

skv

2012-12-29 12:46

developer   ~0022890

No remarks.

mkv

2013-01-15 17:41

tester   ~0022969

Dear BugMaster,

Branch CR23678 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

Related Changesets

occt: master 7566ccf3

2013-01-18 08:16:43

abv


Committer: abv Details Diff		 0023678: Compiler warning in BRepFill_Pipe::ShareFaces() Affected Issues
0023678
mod - src/BRepFill/BRepFill_Pipe.cxx Diff File

Issue History

Date Modified Username Field Change
2012-12-28 18:09 abv New Issue
2012-12-28 18:09 abv Assigned To => jgv
2012-12-28 18:13 abv Note Added: 0022885
2012-12-28 18:13 abv Assigned To jgv => skv
2012-12-28 18:13 abv Status new => resolved
2012-12-29 12:06 skv Note Added: 0022887
2012-12-29 12:06 skv Assigned To skv => abv
2012-12-29 12:06 skv Status resolved => assigned
2012-12-29 12:19 abv Note Added: 0022888
2012-12-29 12:19 abv Assigned To abv => skv
2012-12-29 12:19 abv Status assigned => resolved
2012-12-29 12:46 skv Note Added: 0022890
2012-12-29 12:46 skv Assigned To skv => mkv
2012-12-29 12:46 skv Status resolved => reviewed
2013-01-04 17:09 abv Relationship added has duplicate 0023685
2013-01-15 17:41 mkv Note Added: 0022969
2013-01-15 17:41 mkv Test case number => Not needed
2013-01-15 17:41 mkv Assigned To mkv => bugmaster
2013-01-15 17:41 mkv Status reviewed => tested
2013-01-21 18:29 abv Changeset attached => occt master 7566ccf3
2013-01-21 18:29 abv Assigned To bugmaster => abv
2013-01-21 18:29 abv Status tested => verified
2013-01-21 18:29 abv Resolution open => fixed
2013-04-23 13:36 aiv Status verified => closed
2013-04-29 15:21 aiv Fixed in Version => 6.6.0