View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023634Open CASCADEOCCT:Visualizationpublic2012-12-12 18:042017-11-02 16:37
Reporterkgv Assigned Tokgv  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023634: Eliminate Polyline and Polygon usage in drawers
DescriptionPolyline and Polygon primitives should be replaced within primitive arrays
as Graphic3d_GraphicDriver::Polyline() and Graphic3d_GraphicDriver::Polygon() were deprecated and will be removed.
TagsNo tags attached.
Test case numberNot needed

Attached Files

  • 21886_ExportToPGF.pgf (21,886 bytes)
  • 20398_ExportToPGF.pgf (20,398 bytes)

Relationships

related to 0022971 closedkgv Open CASCADE TKOpenGl clean up obsolete functionality 
related to 0029292 closedbugmaster Open CASCADE Coding Rules - remove Graphic3d_Vector duplicating gp_XYZ 
child of 0023117 closedbugmaster Open CASCADE TKV3d and TKOpenGl code clean-up 

Activities

kgv

2012-12-12 18:07

developer   ~0022681

The subset of 0023117 patch was re-based and pushed into CR23634 branch.
Please test it for regressions.

mkv

2012-12-24 18:45

tester   ~0022819

Last edited: 2012-12-24 18:46

 Dear BugMaster,

Branch CR23634 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

http://occt-tests/CR23634-master-occt/Mandriva2010/3rdparty/export/A7.html
Regressions/Improvements:
3rdparty export(001) A7 - Export to PGF file was done but file has a different size

Testing cases:
Not needed

san

2012-12-24 19:00

developer   ~0022820

Dear mkv,

Have you checked the exported file contents?
If it is correct, please update the reference file. The file size could have changed because now different primitive types are used by the test case - see the bug's title, it contains a hint.

mkv

2012-12-25 12:07

tester   ~0022826

Dear san,
I checked the exported file contents only by the length (see test case).
png file of this test case was checked by visualisation in the viewer (GIMP), it is correct.
Test case 3rdparty export(001) A7 was corrected.

san

2012-12-25 16:14

developer   ~0022833

Dear mkv,

It is not necessary to check the PNG snapshot.
The given test case checks if PGF export works as expected.
Since PGF is a part of TEX specification, checking the visual results requires generation of some target format (PDF or PS) from the TEX document.
Thus probably it is enough to compare the new PGF output with the reference one line-by-line and see if the differences are reasonable or not.

san

2013-01-10 18:13

developer   ~0022934

Reminder sent to: mkv

Dear mkv,

Could you please attach the old and new PGF output to this issue so that we could analyze the differences?

mkv

2013-01-11 15:35

tester  

21886_ExportToPGF.pgf (21,886 bytes)

mkv

2013-01-11 15:35

tester  

20398_ExportToPGF.pgf (20,398 bytes)

mkv

2013-01-11 15:37

tester   ~0022941

Dear san,
 21886_ExportToPGF.pgf - old pgf file;
 20398_ExportToPGF.pgf - pgf file of this fix.

san

2013-01-11 15:39

developer   ~0022942

Last edited: 2013-01-11 15:40

 Dear kgv,

Could you please review the differences between the two PGF export output files attached?

kgv

2013-01-11 16:37

developer   ~0022947

Technically there no differences between files - one of them contains some segments split into 2 halves.

san

2013-01-11 19:54

developer   ~0022950

Please proceed with the patch integration ASAP.

Related Changesets

occt: master b8ddfc2f

2013-01-18 09:36:18

kgv

Details Diff		 0023634: Eliminate Polyline and Polygon usage in drawers

Polylines and polygons removed, now everything is based on PrimitiveArrays.
Added use of Graphic3d_ArrayOfSegments, some additional clean up in Graphic3d_Group.
Dead code elimination in AIS and V3d
Corrected compilation errors
Fixed grid presentation
Adding test case correction		 Affected Issues
0023634
mod - src/AIS/AIS_AngleDimension.cxx Diff File
mod - src/AIS/AIS_Axis.cxx Diff File
mod - src/AIS/AIS_Circle.cxx Diff File
mod - src/AIS/AIS_GraphicTool.cxx Diff File
mod - src/AIS/AIS_InteractiveContext.cxx Diff File
mod - src/AIS/AIS_InteractiveObject.lxx Diff File
mod - src/AIS/AIS_Line.cxx Diff File
mod - src/AIS/AIS_LocalContext_1.cxx Diff File
mod - src/AIS/AIS_Plane.cxx Diff File
mod - src/AIS/AIS_PlaneTrihedron.cxx Diff File
mod - src/AIS/AIS_Relation.cxx Diff File
mod - src/AIS/AIS_Shape.cxx Diff File
mod - src/AIS/AIS_Triangulation.cxx Diff File
mod - src/AIS/AIS_Trihedron.cxx Diff File
mod - src/DsgPrs/DsgPrs_AnglePresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_Chamf2dPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_ConcentricPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_DiameterPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_EllipseRadiusPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_EqualDistancePresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_EqualRadiusPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_FilletRadiusPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_FixPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_IdenticPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_LengthPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_MidPointPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_OffsetPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_ParalPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_PerpenPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_RadiusPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_ShadedPlanePresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_ShapeDirPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_SymmetricPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_TangentPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_XYZAxisPresentation.cxx Diff File
mod - src/DsgPrs/DsgPrs_XYZPlanePresentation.cxx Diff File
mod - src/Graphic3d/FILES Diff File
mod - src/Graphic3d/Graphic3d.cdl Diff File
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.cdl Diff File
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.cxx Diff File
mod - src/Graphic3d/Graphic3d_ArrayOfPrimitives.lxx Diff File
mod - src/Graphic3d/Graphic3d_CGroup.hxx Diff File
mod - src/Graphic3d/Graphic3d_CStructure.hxx Diff File
mod - src/Graphic3d/Graphic3d_GraphicDriver.cdl Diff File
mod - src/Graphic3d/Graphic3d_GraphicDriver.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group.cdl Diff File
mod - src/Graphic3d/Graphic3d_Group.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_1.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_10.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_13.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_2.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_3.cxx Diff File
rm - src/Graphic3d/Graphic3d_Group_5.cxx Diff File
rm - src/Graphic3d/Graphic3d_Group_7.cxx Diff File
mod - src/Graphic3d/Graphic3d_Group_8.cxx Diff File
mod - src/Graphic3d/Graphic3d_Structure.cdl Diff File
mod - src/Graphic3d/Graphic3d_Structure.cxx Diff File
mod - src/Graphic3d/Graphic3d_Structure.pxx Diff File
mod - src/Graphic3d/Graphic3d_Vector.cxx Diff File
rm - src/Graphic3d/Graphic3d_Vertex.cdl Diff File
mod - src/Graphic3d/Graphic3d_Vertex.cxx Diff File
add - src/Graphic3d/Graphic3d_Vertex.hxx Diff File
rm - src/Graphic3d/Graphic3d_VertexC.cdl Diff File
rm - src/Graphic3d/Graphic3d_VertexC.cxx Diff File
rm - src/Graphic3d/Graphic3d_VertexN.cdl Diff File
rm - src/Graphic3d/Graphic3d_VertexN.cxx Diff File
rm - src/Graphic3d/Graphic3d_VertexNC.cdl Diff File
rm - src/Graphic3d/Graphic3d_VertexNC.cxx Diff File
rm - src/Graphic3d/Graphic3d_VertexNT.cdl Diff File
rm - src/Graphic3d/Graphic3d_VertexNT.cxx Diff File
mod - src/InterfaceGraphic/FILES Diff File
rm - src/InterfaceGraphic/InterfaceGraphic_Cextern.hxx Diff File
mod - src/InterfaceGraphic/InterfaceGraphic_telem.hxx Diff File
mod - src/MeshVS/MeshVS_ElementalColorPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_MeshEntityOwner.cxx Diff File
mod - src/MeshVS/MeshVS_MeshPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_NodalColorPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_TextPrsBuilder.cxx Diff File
mod - src/MeshVS/MeshVS_VectorPrsBuilder.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver.hxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver_3.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver_703.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver_705.cxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver_713.cxx Diff File
mod - src/OpenGl/OpenGl_Group.cxx Diff File
mod - src/OpenGl/OpenGl_Group.hxx Diff File
mod - src/OpenGl/OpenGl_Polyline.hxx Diff File
mod - src/OpenGl/OpenGl_Text.cxx Diff File
mod - src/OpenGl/OpenGl_tsm.hxx Diff File
mod - src/Prs3d/Prs3d_AnglePresentation.cxx Diff File
mod - src/Prs3d/Prs3d_Arrow.cxx Diff File
mod - src/Prs3d/Prs3d_Datum.gxx Diff File
mod - src/Prs3d/Prs3d_HLRShape.gxx Diff File
mod - src/Prs3d/Prs3d_LengthPresentation.cxx Diff File
mod - src/Prs3d/Prs3d_Line.gxx Diff File
mod - src/Prs3d/Prs3d_Point.gxx Diff File
mod - src/Prs3d/Prs3d_Vector.gxx Diff File
mod - src/Prs3d/Prs3d_WFDeflectionRestrictedFace.gxx Diff File
mod - src/Prs3d/Prs3d_WFRestrictedFace.gxx Diff File
mod - src/Prs3d/Prs3d_WFShape.gxx Diff File
mod - src/QABugs/QABugs_PresentableObject.cxx Diff File
mod - src/StdPrs/StdPrs_Curve.cxx Diff File
mod - src/StdPrs/StdPrs_DeflectionCurve.cdl Diff File
mod - src/StdPrs/StdPrs_DeflectionCurve.cxx Diff File
mod - src/StdPrs/StdPrs_HLRPolyShape.cxx Diff File
mod - src/StdPrs/StdPrs_Plane.cxx Diff File
mod - src/StdPrs/StdPrs_PoleCurve.cxx Diff File
mod - src/StdPrs/StdPrs_ShadedShape.cxx Diff File
mod - src/StdPrs/StdPrs_ShadedSurface.cxx Diff File
mod - src/StdPrs/StdPrs_WFDeflectionRestrictedFace.cxx Diff File
mod - src/StdPrs/StdPrs_WFPoleSurface.cxx Diff File
mod - src/StdPrs/StdPrs_WFSurface.cxx Diff File
mod - src/StdSelect/StdSelect.cxx Diff File
mod - src/StdSelect/StdSelect_ViewerSelector3d.cxx Diff File
mod - src/V3d/V3d.cxx Diff File
mod - src/V3d/V3d_CircularGrid.cdl Diff File
mod - src/V3d/V3d_CircularGrid.cxx Diff File
mod - src/V3d/V3d_DirectionalLight.cxx Diff File
mod - src/V3d/V3d_Plane.cxx Diff File
mod - src/V3d/V3d_PositionalLight.cxx Diff File
mod - src/V3d/V3d_PositionLight.cxx Diff File
mod - src/V3d/V3d_RectangularGrid.cdl Diff File
mod - src/V3d/V3d_RectangularGrid.cxx Diff File
mod - src/V3d/V3d_SpotLight.cxx Diff File
mod - src/V3d/V3d_View.cxx Diff File
mod - src/V3d/V3d_Viewer.cxx Diff File
mod - src/V3d/V3d_Viewer_3.cxx Diff File
mod - src/V3d/V3d_Viewer_4.cxx Diff File
mod - src/V3d/V3d_View_4.cxx Diff File
mod - src/V3d/V3d_View_5.cxx Diff File
mod - src/ViewerTest/ViewerTest_ObjectCommands.cxx Diff File
mod - src/Visual3d/Visual3d_View.cxx Diff File
mod - src/XCAFPrs/XCAFPrs_AISObject.cxx Diff File
mod - tests/3rdparty/export/A7 Diff File

Issue History

Date Modified Username Field Change
2012-12-12 18:04 kgv New Issue
2012-12-12 18:04 kgv Assigned To => kgv
2012-12-12 18:05 kgv Relationship added child of 0023117
2012-12-12 18:06 kgv Relationship added related to 0022971
2012-12-12 18:07 kgv Note Added: 0022681
2012-12-12 18:07 kgv Status new => resolved
2012-12-12 18:07 kgv Assigned To kgv => bugmaster
2012-12-12 18:07 kgv Status resolved => reviewed
2012-12-13 17:17 mkv Assigned To bugmaster => mkv
2012-12-13 17:17 mkv Test case number => Not needed
2012-12-24 18:45 mkv Note Added: 0022819
2012-12-24 18:45 mkv Assigned To mkv => kgv
2012-12-24 18:45 mkv Status reviewed => feedback
2012-12-24 18:46 mkv Note Edited: 0022819
2012-12-24 18:58 san Assigned To kgv => mkv
2012-12-24 19:00 san Note Added: 0022820
2012-12-25 12:07 mkv Note Added: 0022826
2012-12-25 12:07 mkv Assigned To mkv => bugmaster
2012-12-25 12:07 mkv Status feedback => tested
2012-12-25 16:14 san Note Added: 0022833
2012-12-25 16:14 san Assigned To bugmaster => mkv
2012-12-25 16:14 san Status tested => feedback
2013-01-10 18:13 san Note Added: 0022934
2013-01-11 15:35 mkv File Added: 21886_ExportToPGF.pgf
2013-01-11 15:35 mkv File Added: 20398_ExportToPGF.pgf
2013-01-11 15:37 mkv Note Added: 0022941
2013-01-11 15:39 san Assigned To mkv => kgv
2013-01-11 15:39 san Note Added: 0022942
2013-01-11 15:40 san Note Edited: 0022942
2013-01-11 16:37 kgv Assigned To kgv => mkv
2013-01-11 16:37 kgv Note Added: 0022947
2013-01-11 16:37 kgv Status feedback => assigned
2013-01-11 17:06 kgv Assigned To mkv => bugmaster
2013-01-11 17:06 kgv Status assigned => feedback
2013-01-11 19:54 san Note Added: 0022950
2013-01-16 14:51 bugmaster Status feedback => tested
2013-01-21 18:29 kgv Changeset attached => occt master b8ddfc2f
2013-01-21 18:29 kgv Assigned To bugmaster => kgv
2013-01-21 18:29 kgv Status tested => verified
2013-01-21 18:29 kgv Resolution open => fixed
2013-04-23 13:36 aiv Status verified => closed
2013-04-29 15:22 aiv Fixed in Version => 6.6.0
2017-11-02 16:37 kgv Relationship added related to 0029292