View Issue Details

IDProjectCategoryView StatusLast Update
0023582Open CASCADEOCCT:Modeling Algorithmspublic2013-12-19 13:56
Reporterkgv Assigned Tokgv  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.4 
Target Version6.7.0Fixed in Version6.7.0 
Summary0023582: Argument of LocOpe_WiresOnShape::SetCheckInterior() function is ignored.
DescriptionPatch #23429 introduce new method SetCheckInterior() however it argument is just ignored (and msvc produces C4100 warning):
>inline void LocOpe_WiresOnShape::SetCheckInterior(const Standard_Boolean ToCheckInterior)
>{
> myCheckInterior = Standard_True;
>}
TagsNo tags attached.
Test case numberNot needed

Activities

kgv

2012-12-07 10:42

developer   ~0022609

Patch is ready for review in CR23582 branch.

abv

2012-12-07 11:02

manager   ~0022610

No remarks, please test

abv

2012-12-07 12:26

manager   ~0022619

Julia, please review the proposed fix. Note that test bugs modalg bug23429 is OK both with and w/o the fix; thus I wonder if the flag is really related to the original problem (or whether the test is adequate)

jgv

2012-12-13 13:19

developer   ~0022687

The branch CR23582_1 is ready for reviewing

jgv

2012-12-14 11:47

developer   ~0022698

The branch CR23582_1 is updated (correction of method Init() of LocOpe_WiresOnShape).

mkv

2012-12-17 18:19

tester   ~0022732

Dear BugMaster,

Branch CR23582_1 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

Regressions:
chl 934 B0 - splitshape error

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23582-1-master-products_15122012/lin
See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-12-07-IR12-07-products_0712012/lin
See test cases in /QADisk/occttests/tests/ED

jgv

2013-07-12 17:43

developer   ~0025055

The branch CR23582_2 is ready for testing.

apn

2013-07-16 14:04

administrator   ~0025079

Dear BugMaster,

Branch CR23582_2 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: e3b61df99e7df06c50b5e817d3094faf0efa85e6

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 8 (8 on master)

products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 365590956 / 365745120
Total CPU difference: 43316.4900000009 / 45334.67000000106

Testing on Windows:
Total MEMORY difference: 426143100 / 426159192
Total CPU difference: 33158.1875 / 35068.703125

There are not differences in images found by testdiff.

Related Changesets

occt: master fa748d09

2013-07-12 13:40:15

jgv


Committer: kgv Details Diff
0023582: Argument of LocOpe_WiresOnShape::SetCheckInterior() function is ignored. Affected Issues
0023582
mod - src/LocOpe/LocOpe_WiresOnShape.lxx Diff File

Issue History

Date Modified Username Field Change
2012-11-26 12:28 kgv New Issue
2012-11-26 12:28 kgv Assigned To => jgv
2012-12-07 10:42 kgv Note Added: 0022609
2012-12-07 10:42 kgv Assigned To jgv => abv
2012-12-07 10:42 kgv Status new => resolved
2012-12-07 11:02 abv Note Added: 0022610
2012-12-07 11:02 abv Assigned To abv => bugmaster
2012-12-07 11:02 abv Status resolved => reviewed
2012-12-07 12:17 abv Assigned To bugmaster => jgv
2012-12-07 12:17 abv Status reviewed => assigned
2012-12-07 12:26 abv Note Added: 0022619
2012-12-07 12:26 abv Status assigned => resolved
2012-12-13 13:18 jgv Assigned To jgv => abv
2012-12-13 13:19 jgv Note Added: 0022687
2012-12-14 11:47 jgv Note Added: 0022698
2012-12-14 11:47 jgv Status resolved => reviewed
2012-12-14 18:45 mkv Assigned To abv => mkv
2012-12-17 18:19 mkv Note Added: 0022732
2012-12-17 18:20 mkv Test case number => Not needed
2012-12-17 18:20 mkv Assigned To mkv => kgv
2012-12-17 18:20 mkv Status reviewed => assigned
2012-12-17 20:52 abv Assigned To kgv => jgv
2013-04-19 15:35 abv Target Version 6.6.0 => 6.7.0
2013-07-12 17:43 jgv Note Added: 0025055
2013-07-12 17:43 jgv Status assigned => resolved
2013-07-12 17:43 jgv Status resolved => reviewed
2013-07-15 15:22 apn Assigned To jgv => apn
2013-07-16 14:04 apn Note Added: 0025079
2013-07-16 14:05 apn Assigned To apn => bugmaster
2013-07-16 14:05 apn Status reviewed => tested
2013-07-19 13:33 kgv Changeset attached => occt master fa748d09
2013-07-19 13:33 kgv Assigned To bugmaster => kgv
2013-07-19 13:33 kgv Status tested => verified
2013-07-19 13:33 kgv Resolution open => fixed
2013-12-19 13:52 bugmaster Status verified => closed
2013-12-19 13:56 bugmaster Fixed in Version => 6.7.0