View Issue Details

IDProjectCategoryView StatusLast Update
0023487Open CASCADEOCCT:Modeling Datapublic2013-04-29 15:21
ReportervsrAssigned Toilv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.3 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023487: Remove obsolete BRepTools::OuterShell() function
DescriptionAs described in issue #23129, BRepTools::OuterShell() function works wrong - it always returns the first shell, while its documentation says that it should return the outer most shell of the solid passed as parameter.

New function BRepClass3d::OuterShell(), that provides correct result, is implemented in frames of issue #23129. The function BRepTools::OuterShell() is now considered obsolete: it should be removed from OCCT and all corresponding calls to it should be replaced by new function, if it is feasible (as new function belongs to the upper-level API).
Steps To ReproduceSee issue #23129.
TagsNo tags attached.
Test case numberNot needed

Activities

ilv

2012-10-29 13:12

developer   ~0021987

Deleted function BRepTools::OuterShell(), all corresponding calls to BRepTools::OuterShell() replaced by function BRepClass3d::OuterShell().
Please, review my code.

vsr

2012-11-01 09:23

developer   ~0022041

Julia, please review proposed patch.

abv

2012-11-01 09:39

manager   ~0022042

No remarks, please test

mkv

2012-11-02 15:34

tester   ~0022081

Last edited: 2012-11-14 17:53

Dear BugMaster,
Branch CR23487 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
xcaf brep_to_stp_add_CL (009) B6 B9 C7 D2 D4 F2 F6 F7 G7 G9

Regressions:
dec 009 B6 B9 C7 D2 D4 F2 F6 F7 G7 G9

New behaviour:
chl 926 D5

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23487-master-products_02112012
See reference results in /QADisk/occttests/results/KAS/dev/CR-2012-10-12-IR-2012-10-12-products
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

ilv

2012-11-15 17:03

developer   ~0022271

Changes in BRepClass3d::OuterShell
If solid has only one shell, then it will return, without checking orientation.
Please, review changes.

abv

2012-11-19 12:12

manager   ~0022293

No remarks, please test

mkv

2012-11-20 17:54

tester   ~0022314

Dear BugMaster,
Branch CR23487 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

Related Changesets

occt: master 2f0109b7

2012-11-23 11:01:28

ilv

Details Diff
0023487: Remove obsolete BRepTools::OuterShell() function

All corresponding calls to BRepTools::OuterShell() replaced by function BRepClass3d::OuterShell()
Changed function BRepClass3d::OuterShell
Affected Issues
0023487
mod - src/BRepClass3d/BRepClass3d.cdl Diff File
mod - src/BRepClass3d/BRepClass3d.cxx Diff File
mod - src/BRepTools/BRepTools.cdl Diff File
mod - src/BRepTools/BRepTools.cxx Diff File
mod - src/TopoDSToStep/TopoDSToStep_MakeBrepWithVoids.cxx Diff File
mod - src/TopoDSToStep/TopoDSToStep_MakeFacetedBrep.cxx Diff File
mod - src/TopoDSToStep/TopoDSToStep_MakeFacetedBrepAndBrepWithVoids.cxx Diff File
mod - src/TopoDSToStep/TopoDSToStep_MakeManifoldSolidBrep.cxx Diff File
mod - src/TopOpeBRepBuild/TopOpeBRepBuild_KPart.cxx Diff File

Issue History

Date Modified Username Field Change
2012-10-24 11:17 vsr New Issue
2012-10-24 11:17 vsr Assigned To => jgv
2012-10-24 11:19 vsr Status new => assigned
2012-10-26 14:52 jgv Assigned To jgv => abv
2012-10-26 16:15 abv Assigned To abv => ilv
2012-10-29 13:12 ilv Note Added: 0021987
2012-10-29 13:12 ilv Assigned To ilv => vsr
2012-10-29 13:12 ilv Status assigned => resolved
2012-11-01 09:23 vsr Note Added: 0022041
2012-11-01 09:23 vsr Assigned To vsr => jgv
2012-11-01 09:39 abv Note Added: 0022042
2012-11-01 09:39 abv Assigned To jgv => bugmaster
2012-11-01 09:39 abv Status resolved => reviewed
2012-11-02 15:34 mkv Note Added: 0022081
2012-11-02 15:35 mkv Test case number => Not needed
2012-11-02 15:35 mkv Assigned To bugmaster => ilv
2012-11-02 15:35 mkv Status reviewed => assigned
2012-11-14 17:48 mkv Note Edited: 0022081
2012-11-14 17:53 mkv Note Edited: 0022081
2012-11-15 17:03 ilv Note Added: 0022271
2012-11-15 17:03 ilv Assigned To ilv => abv
2012-11-15 17:03 ilv Status assigned => resolved
2012-11-19 12:12 abv Note Added: 0022293
2012-11-19 12:12 abv Assigned To abv => bugmaster
2012-11-19 12:12 abv Status resolved => reviewed
2012-11-19 18:37 mkv Assigned To bugmaster => mkv
2012-11-20 17:54 mkv Note Added: 0022314
2012-11-20 17:55 mkv Assigned To mkv => bugmaster
2012-11-20 17:55 mkv Status reviewed => tested
2012-11-26 15:45 ilv Changeset attached => occt master 2f0109b7
2012-11-26 15:45 ilv Assigned To bugmaster => ilv
2012-11-26 15:45 ilv Status tested => verified
2012-11-26 15:45 ilv Resolution open => fixed
2012-12-10 17:16 ilv Changeset attached => occt master 2f0109b7
2013-04-23 13:36 aiv Status verified => closed
2013-04-29 15:21 aiv Fixed in Version => 6.6.0