View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023404Open CASCADEOCCT:Foundation Classespublic2012-08-28 12:312012-11-16 13:17
ReporterabkAssigned Toabk 
PrioritylowSeveritytrivial 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.3 
Target Version6.5.4Fixed in Version6.5.4 
Summary0023404: Create SquareConfusion function in Precision package for speed and convenience
DescriptionCreate function SquareConfusion which returns square of Precision::Confusion() in FoundationClasses module -> TKMath toolkit -> Precision package.
TagsNo tags attached.
Test case numberNot needed

Activities

abv

2012-08-31 20:21

manager   ~0021378

The new method is named Confusion() in CDL, instead of SquareConfusion(); please fix. Also, I would expect that you replace squares of Precision::Confusion() by SquareConfusion() in OCCT code (you can easily find about 30 places)... without that the patch is almost meaningful

abk

2012-09-25 15:46

developer   ~0021554

The new method name was corrected.
Squares of Precision::Confusion() were replaced by Precision::SquareConfusion().

abv

2012-10-02 09:33

manager   ~0021609

No remarks, please test

mkv

2012-10-03 14:41

tester   ~0021632

Last edited: 2012-10-03 14:42

 Dear abv,
The branch CR23404 was rebased to the master.
Validate these modifications please.

abv

2012-10-03 14:49

manager   ~0021633

Looks fine, please proceed

mkv

2012-10-04 17:24

tester   ~0021659

Dear BugMaster,
Branch CR23404 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

Related Changesets

occt: master 08cd2f6b

2012-10-05 09:55:16

abk

Details Diff		 0023404: Create SquareConfusion function in Precision package for speed and convenience

SquareConfusion function was created in FoundationClasses module -> TKMath toolkit -> Precision package.
The function returns square of Precision::Confusion().
SquareConfusion function was corrected in FoundationClasses module -> TKMath toolkit -> Precision package.
Squares of Precision::Confusion() were replaced by Precision::SquareConfusion().		 Affected Issues
0023404
mod - src/AIS/AIS.cxx Diff File
mod - src/BRepFeat/BRepFeat_MakeRevolutionForm.cxx Diff File
mod - src/BRepLib/BRepLib_MakeEdge.cxx Diff File
mod - src/BRepMesh/BRepMesh_FastDiscretFace.cxx Diff File
mod - src/BRepOffset/BRepOffset_Tool.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_C1.cxx Diff File
mod - src/Draft/Draft_Modification_1.cxx Diff File
mod - src/DsgPrs/DsgPrs.cxx Diff File
mod - src/DsgPrs/DsgPrs_EqualDistancePresentation.cxx Diff File
mod - src/Extrema/Extrema_ExtPElC.cxx Diff File
mod - src/Extrema/Extrema_ExtPRevS.cxx Diff File
mod - src/GeomliteTest/GeomliteTest_SurfaceCommands.cxx Diff File
mod - src/LocOpe/LocOpe_SplitDrafts.cxx Diff File
mod - src/NIS/NIS_Surface.cxx Diff File
mod - src/Poly/Poly.cxx Diff File
mod - src/Precision/Precision.cdl Diff File
mod - src/Precision/Precision.lxx Diff File
mod - src/ShapeAnalysis/ShapeAnalysis_Curve.cxx Diff File
mod - src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx Diff File
mod - src/ShapeFix/ShapeFix_Wireframe.cxx Diff File
mod - src/StdPrs/StdPrs_ShadedShape.cxx Diff File
mod - src/Voxel/Voxel_Writer.cxx Diff File
mod - src/VrmlData/VrmlData_IndexedFaceSet.cxx Diff File
mod - src/VrmlData/VrmlData_ShapeConvert.cxx Diff File

Issue History

Date Modified Username Field Change
2012-08-28 12:31 abk New Issue
2012-08-28 12:31 abk Assigned To => abk
2012-08-28 14:52 abk Status new => assigned
2012-08-28 14:53 abk Assigned To abk => abv
2012-08-28 14:53 abk Status assigned => resolved
2012-08-31 20:21 abv Note Added: 0021378
2012-08-31 20:21 abv Status resolved => assigned
2012-09-25 15:46 abk Note Added: 0021554
2012-09-25 15:47 abk Status assigned => resolved
2012-10-02 09:33 abv Note Added: 0021609
2012-10-02 09:33 abv Assigned To abv => bugmaster
2012-10-02 09:33 abv Status resolved => reviewed
2012-10-02 18:46 mkv Assigned To bugmaster => mkv
2012-10-03 14:41 mkv Note Added: 0021632
2012-10-03 14:42 mkv Assigned To mkv => abv
2012-10-03 14:42 mkv Status reviewed => feedback
2012-10-03 14:42 mkv Note Edited: 0021632
2012-10-03 14:49 abv Note Added: 0021633
2012-10-03 14:49 abv Assigned To abv => mkv
2012-10-03 14:49 abv Status feedback => reviewed
2012-10-04 17:24 mkv Note Added: 0021659
2012-10-04 17:25 mkv Test case number => Not needed
2012-10-04 17:25 mkv Assigned To mkv => bugmaster
2012-10-04 17:25 mkv Status reviewed => tested
2012-10-08 16:14 abk Changeset attached => occt master 08cd2f6b
2012-10-08 16:16 abk Assigned To bugmaster => abk
2012-10-08 16:16 abk Status tested => verified
2012-10-08 16:16 abk Resolution open => fixed
2012-11-16 13:14 bugmaster Fixed in Version => 6.5.4
2012-11-16 13:17 bugmaster Status verified => closed