View Issue Details

IDProjectCategoryView StatusLast Update
0023275Open CASCADEOCCT:Foundation Classespublic2012-11-16 13:18
ReportervtnAssigned Toaba 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.4 
Target Version6.5.4Fixed in Version6.5.4 
Summary0023275: restore command set name of result variable incorrectly if absolute path is used.
Descriptionrestore /...../shape.brep

The name result variable is /...../shape.brep instead of shape.
TagsNo tags attached.
Test case numberdemo draw restore

Activities

aba

2012-10-23 12:35

developer   ~0021895

src/DrawResources/StandardCommands.tcl was edited.
In line 284 code after condition 'if(name=="")' was changed to parse variable name from the file path. So, if we have 'restore /...../shape.brep', name of variable equals to "shape".

aba

2012-10-23 12:44

developer   ~0021897

The Git branch CR23275 is ready to be reviewed.
Dear oan, please review.

oan

2012-11-01 12:58

developer   ~0022051

I have no comments.

abv

2012-11-01 16:22

manager   ~0022061

Please use git branch CR23275_1: I have simplified the code using Tcl command "file" to process filename, and added a test case. Branch CR23275 deleted.

apn

2012-11-02 13:58

administrator   ~0022072

Dear BugMaster,
Branch CR23275_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
demo draw restore - OK

Related Changesets

occt: master 1598ec0e

2012-11-01 12:14:06

abv


Committer: aba Details Diff
0023275: restore command set name of result variable incorrectly if absolute path is used

Command restore corrected to set default name of the shape equal to filename without extension
Test case added (demo draw restore)
Affected Issues
0023275
mod - src/DrawResources/StandardCommands.tcl Diff File
add - tests/demo/draw/restore Diff File

Issue History

Date Modified Username Field Change
2012-07-13 16:15 vtn New Issue
2012-07-13 16:15 vtn Assigned To => abv
2012-10-18 12:55 abv Assigned To abv => aba
2012-10-20 10:43 abv Status new => assigned
2012-10-23 12:35 aba Note Added: 0021895
2012-10-23 12:44 aba Note Added: 0021897
2012-10-23 12:46 aba Status assigned => resolved
2012-10-23 12:48 aba Assigned To aba => oan
2012-11-01 12:58 oan Note Added: 0022051
2012-11-01 12:58 oan Status resolved => reviewed
2012-11-01 13:00 oan Assigned To oan => aba
2012-11-01 16:21 abv Assigned To aba => bugmaster
2012-11-01 16:22 abv Note Added: 0022061
2012-11-02 13:58 apn Note Added: 0022072
2012-11-02 13:59 apn Test case number => demo draw restore
2012-11-02 13:59 apn Status reviewed => tested
2012-11-06 19:02 aba Changeset attached => occt master 1598ec0e
2012-11-06 19:02 aba Assigned To bugmaster => aba
2012-11-06 19:02 aba Status tested => verified
2012-11-06 19:02 aba Resolution open => fixed
2012-11-16 13:13 bugmaster Fixed in Version => 6.5.4
2012-11-16 13:18 bugmaster Status verified => closed