View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0021690Open CASCADEOCCT:DRAWpublic2010-04-20 13:162012-03-29 17:26
ReporterabdAssigned Tobugmaster  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
OSWindows NT 
Product Version6.4.0 
Target Version6.5.3Fixed in Version6.5.3 
Summary0021690: "cpulimit" commad does not implemented on Win32 platform
DescriptionAt the moment, "cpulimit" DRAW command has only unix part of implementation.
See the package "Draw", file Draw_BasicCommands.cxx, lines 208-244

By the way, SWDRAW package has needed implementation for WNT platform.
see the file cpulimit.pc

To resolve this issue I propose move implementation from SWDRAW package to Draw.
TagsNo tags attached.
Test case numberTest case is not required

Activities

ama

2011-12-06 15:07

developer   ~0018752

SVN branch http://svn/svn/occt/branches/OCC21690 (revision 9663) is ready to be reviewed (implementation "cpulimit" DRAW command for WNT platform).

abv

2011-12-06 19:33

manager   ~0018766

Code review remarks:
(a) it is bad practice to commit in one set changes made for the fix and update from trunk, please avoid this in the future
(b) as soon as implementation in SWDRAW/cpulimit.pc becomes unuseful, could you please remove it?

ama

2011-12-07 17:49

developer   ~0018772

SVN branch http://svn/svn/occt/branches/OCC21690 is ready.
In package SWDRAW command "limitelapsed" for Win32 platform and file "cpulimit.pc" with its implementation has been removed. This is done because the functionality of command "limitelapsed" transferred to the command "cpulimit" in package DRAW.

abv

2011-12-08 09:33

manager   ~0018776

Reviewed with no remarks; please test and use in testing on WNT

mkv

2011-12-09 11:19

tester   ~0018806

Last edited: 2011-12-09 11:19

 Dear BugMaster,
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.

There are compilation errors in mkv-21690-occt:

Info : -------> Draw_BasicCommands.cxx
Error : Errors occured in Shell
/dn47/KAS/dev/mkv-21690-occt/src/Draw/Draw_BasicCommands.cxx:217: error: expected initializer before в__CpuFuncв_T

Error : Failed : Draw_BasicCommands.cxx

Info : ----------------------- Compilation Report -----------------------
Info : Failed : :KAS:dev:mkv-21690-occt:Draw:source:Draw_BasicCommands.cxx
Info : -----------------------------------------------------------------

ama

2011-12-09 15:34

developer   ~0018811

SVN branch http://svn/svn/occt/branches/OCC21690 (revision 9699): correction for compilation on Linux platform.

mkv

2011-12-12 16:26

tester   ~0018819

*RESTORED*
(0018818) abv (administrator) - 2011-12-09 20:19
 http://tracker.dev.opencascade.org/view.php?id=21690#c18818
----------------------------------------------------------------------
No remarks on code; please do not forget to switch bugs to resolved state when
you provide the fix

mkv

2011-12-12 19:16

tester   ~0018826

Dear BugMaster,
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.

There are not regressions in mkv-21690-products regarding to KAS:dev:products-652-opt.

See results in /QADisk/occttests/results/KAS/dev/mkv-21690-products_09122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

bugmaster

2011-12-16 16:12

administrator   ~0018888

Last edited: 2012-01-10 17:22

 Integrated into trunk of occt repository

Date: 2011-12-16 16:10:37 +0400 (Fri, 16 Dec 2011)
New Revision: 9768

Removed:
   trunk/src/SWDRAW/FILES
   trunk/src/SWDRAW/cpulimit.pc
Modified:
   trunk/src/Draw/Draw_BasicCommands.cxx
   trunk/src/SWDRAW/SWDRAW.cxx

Related Changesets

occt: master 47cbc555

2011-12-16 12:10:37

ama


Committer: bugmaster Details Diff		 0021690: "cpulimit" command does not implemented on Win32 platform Affected Issues
0021690
mod - src/Draw/Draw_BasicCommands.cxx Diff File
rm - src/SWDRAW/cpulimit.pc Diff File
rm - src/SWDRAW/FILES Diff File
mod - src/SWDRAW/SWDRAW.cxx Diff File

Issue History

Date Modified Username Field Change
2010-05-13 16:20 bugmaster Assigned To bugmaster => abv
2010-05-13 16:20 bugmaster Status new => assigned
2011-12-01 13:52 abv Assigned To abv => ama
2011-12-06 15:07 ama Note Added: 0018752
2011-12-06 15:08 ama Assigned To ama => abv
2011-12-06 16:19 abv Status assigned => resolved
2011-12-06 19:33 abv Note Added: 0018766
2011-12-06 19:33 abv Assigned To abv => ama
2011-12-06 19:33 abv Status resolved => assigned
2011-12-07 17:49 ama Note Added: 0018772
2011-12-07 17:51 ama Assigned To ama => abv
2011-12-08 09:32 abv Status assigned => resolved
2011-12-08 09:33 abv Note Added: 0018776
2011-12-08 09:33 abv Assigned To abv => ama
2011-12-08 09:33 abv Status resolved => reviewed
2011-12-08 10:04 abv Product Version => 6.4.0
2011-12-08 10:04 abv Fixed in Version EMPTY =>
2011-12-08 10:04 abv Target Version => 6.5.3
2011-12-08 10:04 abv Description Updated
2011-12-09 11:19 mkv Note Added: 0018806
2011-12-09 11:19 mkv Note Edited: 0018806
2011-12-09 11:20 mkv Status reviewed => assigned
2011-12-09 15:34 ama Note Added: 0018811
2011-12-09 15:35 ama Assigned To ama => abv
2011-12-12 16:26 mkv Note Added: 0018819
2011-12-12 16:26 mkv Assigned To abv => ama
2011-12-12 16:26 mkv Status assigned => resolved
2011-12-12 16:27 mkv Status resolved => reviewed
2011-12-12 19:16 mkv Note Added: 0018826
2011-12-12 19:16 mkv Test case number => Test case is not required
2011-12-12 19:16 mkv Status reviewed => tested
2011-12-16 16:12 bugmaster Note Added: 0018888
2011-12-16 16:12 bugmaster Status tested => verified
2011-12-16 16:12 bugmaster Resolution open => fixed
2012-01-10 17:22 bugmaster Note Edited: 0018888
2012-03-29 17:26 bugmaster Changeset attached => occt master 47cbc555