View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0026603CommunityOCCT:Samplespublic2015-08-26 11:542018-07-17 08:49
ReporterafvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2010 
Product Version6.9.0 
Target Version7.0.0Fixed in Version7.0.0 
Summary0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x
DescriptionThis problem described on the occt forum : http://www.opencascade.org/org/forum/thread_27248/?forum=3

In the first creating document window, View area was created with standard size ( left bottom angle window ). When the object is displayed, it has wrong position. At pressing on maximize or normalize button, View area save previous size and not resized, but document window not have problem with resize event.
Steps To ReproduceStep 1: Run application.
Step 2: Press on "New" button.
Step 3: Press on "MakeBottle" button.
Bug №1: Incorrect position of the bottle.
Step 4: Press "maximize" button.
Bug №2: View area save previous size and not resized, bottle displayed with the wrong size and position.
Additional information
and documentation updates		The problem was debugged using the latest Qt release (Qt 5.5), one additional problem was discovered in the sample application with this Qt version:
after creating a new document, application crashed, because View area was not created, but the link is already there. Therefore, the method that initializes View area was transferred to constructor widget.

With using Qt 5.x need to update samples in OCCT products.
TagsNo tags attached.
Test case numberNot needed

Attached Files

  • Untitled.jpg (21,398 bytes)
  • Untitled1.jpg (69,080 bytes)
  • Wrong3DView.jpg (93,594 bytes)
  • UpdateProblem.jpg (178,271 bytes)

Relationships

related to 0024570 closedbugmaster Community Qt5 mouse tracking is not working with V3d_View (GNU/Linux) 
related to 0027291 closedbugmaster Open CASCADE Command File->New crashes Import Export Qt sample on Linux 
related to 0027922 closedabv Community Samples - Qt sample document window display problem 

Activities

afv

2015-08-26 11:55

developer  

Untitled.jpg (21,398 bytes)

afv

2015-08-26 11:55

developer  

Untitled1.jpg (69,080 bytes)

san

2015-08-26 20:28

developer   ~0044692

Dear afv,

Please, consider the following points when processing this issue (as agreed during our meeting yesterday):
1. Find the reason for incorrect system window size after using maximize/restore buttons in the Qt 5.5 sources.
2. Describe the Qt 5.5 behavior specifics that lead to incorrect behavior of OCCT viewer in this issue, and explain why the involved OCCT API is incompatible with Qt behavior.
3. NEW: In order to avoid conflicts between Qt 5.5 and OS-specific OCCT API (WNT_Window, Xw_Window), it is proposed to wrap the view widget into a custom Aspect_Window descendant class at the application level and retrieve window geometry from QWidget.

git

2015-09-02 17:27

administrator   ~0044974

Branch CR26603 has been created by afv.

SHA-1: 1892d0011954d43a16c8585c2e03c0a52250e780


Detailed log of new commits:

Author: afv
Date: Wed Sep 2 17:26:57 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

afv

2015-09-02 17:41

developer   ~0044975

I created two branches:
1) CR26603 - branch for tutorial sample.
2) CR26603_1 - branch for occt products.

san

2015-09-03 17:12

developer   ~0045017

Last edited: 2015-09-03 18:04

 Branches CR26603 (occt) and CR26603_1 (occt-products) reviewed with the following remarks.

General
=====================================
- Commit comment in products branch CR26603_1: read carefully the OCCT contribution workflow regarding the correct commit messages.
- What about Qt platform plugins? No relevant changes made to env.bat.
- It is proposed to add QTDIR variable explicitly to env.bat and subsequently add %QTDIR%/bin to PATH like in env.sh under Linux.

samples/qt/Common/src/CrossWindow.cxx
=====================================
- Choose class names more carefully! CrossWindow is difficult to understand. In a Qt-based application, OcctWindow or WidgetWrapper would be more relevant.

- Destroy() is too complicated - can be simplified as follows:
+void CrossWindow::Destroy()
+{
+ myWidget = NULL;
+}

- What is the purpose of myXLeft, myYTop, myXRight and myYBottom data members? My understanding is that they are used to store previous widget geometry and determine the type of resize in DoResize(). Meanwhile, widget size and position is returned using the current widget geometry - i.e. myWidget->rect(). This is done correctly in some methods but not in Position(), so please correct it. Else please explain the role of these data members and the way they are used.

- Check the OCCT coding rules regarding placement of parentheses in if-statements, expressions and function calls.

- NativeParentHandle(), NativeHandle(): function header comments missing.

- NativeParentHandle(): will crash if myWidget->parentWidget() returns 0.

samples/qt/Common/src/CrossWindow.h
=====================================
- Remove DEFINE_STANDARD_HANDLE macro and forward declaration of the class, refer to Standard_Handle.hxx for details

- Once again, consider a different, more understandable class name

- Revise the class description:
  - Avoid "we" usage, impersonal sentences or third-person sentences are preferred in source code documentation (using "it" or "the class" as the subject).
  - Remove irrelevant phrases like " When building this application" - only when building? Not at runtime? It is enough to say "With Qt 5.x, ..."
  - Check carefully what you wrote - e.g. I do not understand "when you change the window size using the operating system, we will receive incorrect data, as part of our application" - it has nothing to do with what we understood during Qt debugging, we did not change the window size using Win32 API but we queried the window size using Win32 API.
  - Make sure you do not mix "slot" and "event"
  - I would rather say "an implementation of Aspect_Window interface based on QWidget API" instead of "cross-platform Window"
  - "use only the internal data Qt" - we do not use internal Qt data at all. Your class relies on window geometry information provided by Qt API.
  - "( in our case this is the widget where the window based )" - completely unclear, do you mean "the Qt widget where a 3D view content is displayed"?
  - Please check English grammar! Ask our technical writers for help if necessary.
   
- Position() method:
  - Remove Standard_EXPORT macro - I guess this class' methods need not to be exported because you build an executable application rather than a DLL
  - Correct indentation
  
samples/qt/Common/src/View.h
=====================================
- myDrawRect field declaration - correct indentation

git

2015-09-04 11:54

administrator   ~0045041

Branch CR26603 has been updated by afv.

SHA-1: c00832ba2e653b84c4663a2901ba7bb6bb16e527


Detailed log of new commits:

Author: afv
Date: Fri Sep 4 11:53:42 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x
    Fixed remarks.

Author: afv
Date: Wed Sep 2 17:51:57 2015 +0300

    minor remark

Author: afv
Date: Wed Sep 2 17:49:58 2015 +0300

    minor remark

git

2015-09-04 13:34

administrator   ~0045061

Branch CR26603 has been deleted by afv.

SHA-1: c00832ba2e653b84c4663a2901ba7bb6bb16e527

git

2015-09-04 13:58

administrator   ~0045063

Branch CR26603 has been created by afv.

SHA-1: d2f0fb55b3f0b61dc21b29f4ba031bdf2011822d


Detailed log of new commits:

Author: afv
Date: Fri Sep 4 13:57:35 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

san

2015-09-11 15:27

developer   ~0045495

Last edited: 2015-09-11 15:31

 Branch CR26603 reviewed with the following remarks:

samples/qt/Common/src/OcctWindow.cxx
=====================================
OcctWindow::NativeParentHandle() - incorrect indentation, see below:

+void OcctWindow::Destroy()
+{
+  myWidget = NULL;
+}
+
+// =======================================================================
+// function : NativeParentHandle
+// purpose  :
+// =======================================================================
+Aspect_Drawable OcctWindow::NativeParentHandle() const
+{
+  QWidget* aParentWidget = myWidget->parentWidget();
+  if ( aParentWidget != NULL )
+       return (Aspect_Drawable)aParentWidget->winId(); <---!!!!
+  else
+       return 0;                                       <---!!!!
+}


OcctWindow::Position() - incorrect indentation within the argument list, see below:

+void OcctWindow::Position ( Standard_Integer& theX1, Standard_Integer& theY1,
+                             Standard_Integer& theX2, Standard_Integer& theY2 ) const <--!!!


samples/qt/Common/src/OcctWindow.h
=====================================
Class documentation - please replace with the text below:

OcctWindow class implements Aspect_Window interface using Qt API as a platform-independent source of window geometry information. A similar class should be used instead of platform-specific OCCT classes (WNT_Window, Xw_Window) in any Qt 5 application using OCCT 3D visualization.

With Qt 5, the requirement for a Qt-based application to rely fully on Qt public API and stop using platform-specific APIs looks mandatory. An example of this is changed QWidget event sequence: when a widget is first shown on the screen, a resize event is generated before the underlying native window is resized correctly, however the QWidget instance already holds correct size information at that moment.
The OCCT classes acting as a source of window geometry for V3d_View class (WNT_Window, Xw_Window) are no longer compatible with changed Qt behavior because they rely on platform-specific API that cannot return correct window geometry information in some cases. A reasonable solution is to provide a Qt-based implementation of Aspect_Window interface at application level.


virtual void Position() - incorrect indentation within the argument list (not corrected after previous code reviewing), see below:

+  virtual void Position( Standard_Integer& theX1, Standard_Integer& theY1, 
+                                                Standard_Integer& theX2, Standard_Integer& theY2 ) const; <--!!!


samples/qt/Common/src/View.h
=====================================
Incorrect indentation - see below (not corrected after the previous code reviewing):
     bool                            myIsAntialiasingEnabled;
 
-    bool                            myFirst;
-    bool                                       myDrawRect;           // set when a rect is used for selection or magnify 
+    bool                                   myDrawRect;           // set when a rect is used for selection or magnify 
     Handle(V3d_View)                myView;


samples/qt/IESample/env.bat
=====================================
Should be corrected similarly to samples/qt/Tutorial/env.bat

BenjaminBihler

2015-09-11 17:36

developer   ~0045519

Hi, I have checked the fix. Unfortunately it seems not to work here. I am using Qt 5.4.2 and the OCC community edition. Also I have modified the Qt sample so that it is not exactly your code anymore, but it is extremely similar.

The resizing problem still happens here. The actual 3D view does not fit to the window. Would you mind using a gradient background? Then you can easily see whether the 3D view is correctly resized.

I use the following:

------------------
Quantity_Color mainColor = Quantity_Color(51.0 / 255.0, 51.0 / 255.0, 102.0 / 255.0, Quantity_TOC_RGB);
Quantity_Color gradientColor = Quantity_Color(171.0 / 255.0, 171.0 / 255.0, 192.0 / 255.0, Quantity_TOC_RGB);
myView->SetBgGradientColors(mainColor, gradientColor, Aspect_GFM_VER, Standard_False);
------------------

Another problem is that the fix seems to be incompatible with Qt 4. But I can use

#if (QT_VERSION < QT_VERSION_CHECK(5,0,0))
...
#endif

to make my application work with Qt 4 and Qt5.

I am looking forward to your answer.

BenjaminBihler

2015-09-11 17:43

developer   ~0045523

To make my point more clear, let me give you a number of steps to reproduce my problem:

1. Start application. The application window is maximized and the document window is maximized within the application window.
2. "Restore Down" the document window (the inner window, not the application window). "Restore Down" is the opposite action of "Maximize" and it is done by clicking onto the same window icon.
3. "Maximize" the document window again. Now the 3D view is smaller than the document window. Its size is the same as returned by the sizeHint() method from the Qt window class. Please see the attached file Wrong3DView.jpg.

BenjaminBihler

2015-09-11 17:43

developer  

Wrong3DView.jpg (93,594 bytes)

san

2015-09-14 11:34

developer   ~0045553

Hello Benjamin,

Can you please reproduce the situation illustrated by Wrong3DView.jpg using standard OCCT Qt samples (Tutorial or IESample) and the OCCT development snapshot form CR26603 Git branch? Without this your comment does not look relevant.

And thanks for the remark regarding Qt 4.x compatibility, we will take it into account.

BenjaminBihler

2015-09-14 12:23

developer   ~0045559

I will try to reproduce the error with standard OCCT samples. This will take a while and I am not sure whether I can find the time to finish it.

Still changing the background and trying maximization/restoring of the document window should just take a few minutes. Therefore I would like to ask you to try that. I am quite sure that you will see the same errors as described above.

san

2015-09-14 12:30

developer   ~0045560

Naturally, we have already tried at our side and found no problem, resizing seems to work correctly with the patch from CR26603 branch.
I mean not only the standard OCCT samples but also the OCCT version you use, please see the beginning of your comment above (0026603:0045519).

BenjaminBihler

2015-09-14 18:14

reporter   ~0045603

To not make you wait: I will stick to Qt 4. Never mind, you can mark the issue as resolved.

Vico Liang

2015-09-15 08:25

reporter   ~0045604

I have the same issue even if the patch CR26603 is applied in QT5.5. It just reproduce at the first time to show up the window. it works after resizing the window manually.

san

2015-09-15 09:31

developer   ~0045606

Hello Vico,

Please, confirm that you use the following environment:
- Qt 5.5
- OCCT + the standard Qt sample (Tutorial or IESample) built from sources taken from CR26603 branch
I need to make sure that we use exactly the same OCCT snapshot.
Thanks a lot in advance!

Vico Liang

2015-09-15 09:43

reporter   ~0045607

Dear san,

The environment in my side: Qt 5.5 + OCCT6.9 + CR26603. But I did not try that with occt Qt sample, i did it in my own way with patch CR26603. All build from source codes.

BenjaminBihler

2015-09-15 13:15

reporter   ~0045627

Dear Vico,

I had not managed to compile OCCT with MSVC 2013 (compile error about overloads having similar conversions).

But if you have already compiled OCCT, could you check the OCCT Qt sample? If you can reproduce the bug, but san cannot (let's assume he has really tried hard to do so), then can it have to do anything with our graphics card? Mine here is NVIDIA Quadro 4000.

Thank you!
Benjamin

Vico Liang

2015-09-15 14:05

reporter   ~0045636

Where to get the QT sample for QT5.x? the default QT sample is still packaged in QT4.

san

2015-09-15 14:42

developer   ~0045639

Last edited: 2015-09-15 14:59

 Dear all,

Most likely, the principal difference in behavior of the current OCCT master and OCCT 6.9.0 is due to the following patch for #26392:
http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=62e1beed962f76420131e79de4ffa8748e70e50d#patch26

Thus if you take the application patch from CR26603 and the modification for OpenGl_Window.cxx from #26392, everything might work as expected. Can you please check?

BenjaminBihler

2015-09-15 14:42

reporter   ~0045640

If you have checked out the new branch, then in the folder occt\samples\qt\Common\src you will find the files OcctWindow.cxx and OcctWindow.h. This is the new adaption to Qt 5. Then you could compile the sample occt\samples\qt\Tutorial and check whether document window maximation works.

BenjaminBihler

2015-09-15 14:56

reporter   ~0045641

Thank you for the tip, san, I will try that.

san

2015-09-17 11:25

developer   ~0045754

Just to remind that we are waiting for further feedback regarding this issue.
Does OCCT 6.9.0 with the patched OpenGl_Window.cxx works as expected in your environment?

BenjaminBihler

2015-09-17 11:29

reporter   ~0045755

I am compiling an updated OCE version right now and I hope that I can give you further information this evening.

BenjaminBihler

2015-09-17 17:30

reporter   ~0045821

Dear san,

your tip was correct. If I apply the changes from the patch #26392, the document window maximization/restoration problem disappears! Thank you very much for your great work!

Still I have another problem! :-( It seems to be also related with Qt 5 and the way the OpenGL window is created or destroyed. Unfortunately it is very blurred. Here is the description:

When I close document windows and open new ones, sometimes it happes, that the document window content is not updated correctly. This is a problem of that document window and it stays like that during the window lifetime. When I resize the window manually, the content is not correctly redrawn. Yet sometimes (especially if I move the window out of the screen and back again) content updates may happen. I will attach a screenshot called UpdateProblem.jpg. There the left document window has this update problem, while the right document window is okay.

I could spot one difference between windows being updated correctly and "damaged" windows:
When I create the first document window of my QMdiArea or if I close a document window, I get this error message:

TKOpenGl.WinSystem | Type: Error | ID: 6 | Severity: High | Message:
  wglMakeCurrent() has failed. Das Handle ist ung�ltig.

The german sentence means: "The handle is invalid".

This error message did not appear when I was using Qt 4.

"Normally" this error message appears exactly once during document window creation or closing. But sometimes it appear six times. In that case the window is "damaged" and the updates will not be performed correctly.

Have you ever seen an error message like this or have you also had that problem? Is there another patch branch fixing it?

I know that this is a terrible error description. But unfortunately this is a sporadic problem (could it have to do something with concurrent code and timing problems during document window creation?).

Thank you very much for your answer.

Benjamin

BenjaminBihler

2015-09-17 17:31

reporter  

UpdateProblem.jpg (178,271 bytes)

san

2015-09-17 17:47

developer   ~0045824

Benjamin,

Thanks for confirming that the window resizing issue is resolved!

Now let me sum up the new problem:
- It is not reproduced with help of an official OCCT release or the current OCCT development version
- It is not reproduced with help of the standard OCCT sample application
- It is not reproduced in a regular and deterministic way

In this situation, one approach that could be recommended is migrating your application to an official OCCT release (http://www.opencascade.com/content/download-center) or to the OCCT development version (http://dev.opencascade.org/index.php?q=home/resources), checking if the problem still exists, and trying to reproduce it using the standard OCCT sample application (or providing another reproducer) so that the OCCT development team be able to debug the issue.

Alternatively, you can apply for our commercial customer support services: http://www.opencascade.com/content/technology-support. Like this, our experts will be able to help you most efficiently.

san

2015-09-17 17:52

developer   ~0045825

Last edited: 2015-09-17 17:52

 Dear afv,

Please clean up the pending reviewer's remarks (if any) and send the patch back for the final reviewing and testing.

BenjaminBihler

2015-09-17 18:05

reporter   ~0045828

san,

sorry for annoying you that much!

Best regards,
Benjamin

git

2015-09-18 08:39

administrator   ~0045848

Branch CR26603 has been deleted by afv.

SHA-1: d2f0fb55b3f0b61dc21b29f4ba031bdf2011822d

git

2015-09-18 09:23

administrator   ~0045849

Branch CR26603 has been created by afv.

SHA-1: 4b6093b5ff45cf5ad40f4f54c053acfcf411cad8


Detailed log of new commits:

Author: afv
Date: Fri Sep 18 09:22:38 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

afv

2015-09-18 10:52

reporter   ~0045854

Fixed all remarks for note 0045495.

san

2015-09-18 11:48

developer   ~0045867

New files have been lost in the patch, please add them back - and double-check the patch contents in general.

san

2015-09-18 11:57

developer   ~0045870

And what about Qt 4 compatibility?

To sum up TODO:
- Remarks from 0026603:0045495 - seems to be done
- Missing files (OcctWindow) + verify the patch contents and make sure all your local changes are included
- Qt 4 compatibility (see 0026603:0045519), do the same with the product samples please.

san

2015-09-18 15:31

developer   ~0045895

Some more TODOs - without them the build environment for the Qt samples is broken:

- Rebase CR26603 branch onto the current master
- Get a clean local copy of OCCT from this branch and build it using CMake - like this, you will obtain new OCCT binary tree structure where %CASROOT%\msvc.bat is no more available. A quick solution is to copy msvc.bat from adm\templates by genproj.bat for each Qt sample. Later on, Qt samples will be migrated to CMake.
- Update the Qt samples for this new directory structure and check compilation and execution.

git

2015-09-30 11:13

administrator   ~0046313

Branch CR26603_1 has been created by afv.

SHA-1: facfe5933a6c00f9f3f8dd510c9d51891012590b


Detailed log of new commits:

Author: afv
Date: Wed Sep 30 10:55:24 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

Author: afv
Date: Wed Sep 30 10:48:53 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

Author: afv
Date: Mon Sep 28 10:23:48 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

Author: afv
Date: Mon Sep 28 09:49:41 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

git

2015-10-05 13:39

administrator   ~0046452

Branch CR26603_2 has been created by afv.

SHA-1: b4e4368b54ea9e0f5237bff75607689366bdc24c


Detailed log of new commits:

Author: afv
Date: Mon Oct 5 13:36:07 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

afv

2015-10-05 13:40

reporter   ~0046453

Last edited: 2015-10-05 13:41

 Before check branch CR26603_2 , need to check branch CR26739 in OCCT and OCCT Products

san

2015-10-06 11:24

developer   ~0046492

Please add the patch for Linux.

git

2015-10-08 09:35

administrator   ~0046579

Branch CR26603_2 has been updated by afv.

SHA-1: 7fc72d675ce759fc6ca6047b149abb9f3650891b


Detailed log of new commits:

Author: afv
Date: Thu Oct 8 09:33:47 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

git

2015-10-08 10:13

administrator   ~0046581

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: 7e805b3543aeb416481828a2091e68ae2f4c9423

san

2015-10-09 15:47

developer   ~0046630

Dear afv,

What is the current status of this issue? Any specific problems under Linux?

git

2015-10-12 14:37

administrator   ~0046677

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: b4ad4efe6d04a042c5402285766eb7284bf387ee

git

2015-10-12 15:11

administrator   ~0046678

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: e335800a84b961160ee67f48c71e5f8c35ab6db4

git

2015-10-12 15:38

administrator   ~0046679

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: f677e21c45beb846543b36bc7a07c924f9d3cb21

san

2015-10-12 19:29

developer   ~0046682

Branch CR26603_2 in occt and occt-products reviewed without remarks.
Please test Qt samples based on IESample with Qt 5.5.0 under all supported operating systems.

mkv

2015-10-14 12:42

tester   ~0046732

Dear BugMaster,
Branch CR26603_2 from occt git-repository (and CR26603_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: f677e21c45beb846543b36bc7a07c924f9d3cb21
SHA-1: ce1d467c85c28e621b62141f0e631c4ea7d84de6

Number of compiler warnings:

occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

There are compilation errors in occt Qt samples on windows platform:
http://jenkins-test-01.nnov.opencascade.com:8080/view/CR26603-2-CR26603-2/job/CR26603-2-CR26603-2_build_occt_qt_samples_window/1/parsed_console/
1>d:\builds\vc10\CR26603-2-CR26603-2-occt-64\inc\Font_FTLibrary.hxx(23): fatal error C1083: Cannot open include file: 'ft2build.h': No such file or directory

git

2015-10-14 13:31

administrator   ~0046735

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: 54493dee3fdd252ca479f4c94876802875df3170

git

2015-10-15 09:37

administrator   ~0046762

Branch CR26603_2 has been updated forcibly by afv.

SHA-1: c04fcd8c860d91435691aa6e0bd617bf0939d7f1

afv

2015-10-15 09:45

reporter   ~0046763

Dear san,

Please review. This is minor fix - in base branch 0026739 qt samples VoxelDemo was removed at all.

san

2015-10-15 12:07

developer   ~0046783

Branch CR26603_2 reviewed without remarks - please test the Qt samples with Qt 5.5 on all platforms, paying attention to different ways of resizing a 3D view window (minimize, maximize, resize manually by dragging a corner or a border).

mkv

2015-10-16 16:46

tester   ~0047028

Dear afv,
could you please rebase branch CR26603_2 on current master of occt git-repository, there are conflict files.
Dear afv,
could you please rebase branch CR26603_2 on current master of products git-repository, there are conflict files.

git

2015-10-19 15:38

administrator   ~0047160

Branch CR26603_3 has been created by afv.

SHA-1: 81dce0a06adb67d3fc1bef8517b0d73a1e184fd7


Detailed log of new commits:

Author: afv
Date: Mon Oct 19 15:37:50 2015 +0300

    0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x

git

2015-10-19 16:02

administrator   ~0047166

Branch CR26603_3 has been updated forcibly by afv.

SHA-1: f1cdb142ba8dc11ea6e4b1b61c3165acf88e1c10

mkv

2015-10-20 17:49

tester   ~0047232

Dear BugMaster,
Branch CR26603_3 from occt git-repository (and CR26603_3 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: f1cdb142ba8dc11ea6e4b1b61c3165acf88e1c10
SHA-1: 13c9e1d1c081339a39a10605b9d34fe88e13aaaa

Number of compiler warnings:

occt component :
Linux: 8 (8 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

There are not compilation errors in occt Qt samples on Windows platform:
There are not compilation errors in products Qt samples on Windows platform:

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92098290 / 92270380 [-0.19%]
Total CPU difference: 19745.289999999764 / 19657.70999999973 [+0.45%]
products component :
Total MEMORY difference: 26258128 / 26295062 [-0.14%]
Total CPU difference: 7741.659999999993 / 7414.720000000001 [+4.41%]

Testing on Windows:
occt component :
Total MEMORY difference: 58026127 / 58036786 [-0.02%]
Total CPU difference: 18297.326089799157 / 17972.048404698966 [+1.81%]
products component :
Total MEMORY difference: 17164123 / 17167618 [-0.02%]
Total CPU difference: 5648.983411199966 / 5655.301451699955 [-0.11%]

There are no differences in images found by testdiff.

git

2016-04-17 14:42

administrator   ~0053219

Branch CR26603 has been deleted by kgv.

SHA-1: 4b6093b5ff45cf5ad40f4f54c053acfcf411cad8

git

2016-04-17 14:42

administrator   ~0053220

Branch CR26603_1 has been deleted by kgv.

SHA-1: facfe5933a6c00f9f3f8dd510c9d51891012590b

git

2016-04-17 14:42

administrator   ~0053221

Branch CR26603_2 has been deleted by kgv.

SHA-1: c04fcd8c860d91435691aa6e0bd617bf0939d7f1

git

2016-04-17 14:42

administrator   ~0053222

Branch CR26603_3 has been deleted by kgv.

SHA-1: f1cdb142ba8dc11ea6e4b1b61c3165acf88e1c10

Related Changesets

occt: master de6273a3

2015-10-19 13:02:23

afv


Committer: bugmaster Details Diff		 0026603: Problem with maximization and normalization document windows in Qt samples with Qt 5.x Affected Issues
0026603
add - samples/qt/Common/src/OcctWindow.cxx Diff File
add - samples/qt/Common/src/OcctWindow.h Diff File
mod - samples/qt/Common/src/View.cxx Diff File
mod - samples/qt/Common/src/View.h Diff File
mod - samples/qt/IESample/env.bat Diff File
mod - samples/qt/Interface/src/Application.h Diff File
mod - samples/qt/Tutorial/env.bat Diff File

Issue History

Date Modified Username Field Change
2015-08-26 11:54 afv New Issue
2015-08-26 11:54 afv Assigned To => afv
2015-08-26 11:55 afv Steps to Reproduce Updated
2015-08-26 11:55 afv File Added: Untitled.jpg
2015-08-26 11:55 afv File Added: Untitled1.jpg
2015-08-26 13:22 san Status new => assigned
2015-08-26 13:24 san Additional Information Updated
2015-08-26 13:25 san Summary Problem with maximization and normalization document windows in Qt samples => Problem with maximization and normalization document windows in Qt samples with Qt 5.x
2015-08-26 20:28 san Note Added: 0044692
2015-09-02 17:27 git Note Added: 0044974
2015-09-02 17:41 afv Note Added: 0044975
2015-09-02 17:41 afv Assigned To afv => san
2015-09-02 17:41 afv Status assigned => resolved
2015-09-03 17:12 san Note Added: 0045017
2015-09-03 17:12 san Assigned To san => afv
2015-09-03 17:12 san Status resolved => assigned
2015-09-03 18:04 san Note Edited: 0045017
2015-09-04 11:54 git Note Added: 0045041
2015-09-04 12:07 afv Assigned To afv => san
2015-09-04 12:07 afv Status assigned => resolved
2015-09-04 13:34 git Note Added: 0045061
2015-09-04 13:58 git Note Added: 0045063
2015-09-04 14:10 afv Additional Information Updated
2015-09-11 15:27 san Note Added: 0045495
2015-09-11 15:27 san Assigned To san => afv
2015-09-11 15:27 san Status resolved => assigned
2015-09-11 15:30 san Note Edited: 0045495
2015-09-11 15:31 san Note Edited: 0045495
2015-09-11 17:36 BenjaminBihler Note Added: 0045519
2015-09-11 17:43 BenjaminBihler Note Added: 0045523
2015-09-11 17:43 BenjaminBihler File Added: Wrong3DView.jpg
2015-09-14 11:34 san Note Added: 0045553
2015-09-14 12:23 BenjaminBihler Note Added: 0045559
2015-09-14 12:30 san Note Added: 0045560
2015-09-14 18:14 BenjaminBihler Note Added: 0045603
2015-09-15 08:25 Vico Liang Note Added: 0045604
2015-09-15 09:31 san Note Added: 0045606
2015-09-15 09:43 Vico Liang Note Added: 0045607
2015-09-15 13:15 BenjaminBihler Note Added: 0045627
2015-09-15 13:17 san Product Version 7.0.0 => 6.9.0
2015-09-15 14:05 Vico Liang Note Added: 0045636
2015-09-15 14:42 san Note Added: 0045639
2015-09-15 14:42 BenjaminBihler Note Added: 0045640
2015-09-15 14:56 BenjaminBihler Note Added: 0045641
2015-09-15 14:59 san Note Edited: 0045639
2015-09-17 11:25 san Note Added: 0045754
2015-09-17 11:29 BenjaminBihler Note Added: 0045755
2015-09-17 17:30 BenjaminBihler Note Added: 0045821
2015-09-17 17:31 BenjaminBihler File Added: UpdateProblem.jpg
2015-09-17 17:47 san Note Added: 0045824
2015-09-17 17:52 san Note Added: 0045825
2015-09-17 17:52 san Status assigned => feedback
2015-09-17 17:52 san Note Edited: 0045825
2015-09-17 18:05 BenjaminBihler Note Added: 0045828
2015-09-18 08:39 git Note Added: 0045848
2015-09-18 09:23 git Note Added: 0045849
2015-09-18 10:52 afv Note Added: 0045854
2015-09-18 10:52 afv Assigned To afv => bugmaster
2015-09-18 10:52 afv Status feedback => resolved
2015-09-18 11:46 san Assigned To bugmaster => san
2015-09-18 11:48 san Note Added: 0045867
2015-09-18 11:48 san Assigned To san => afv
2015-09-18 11:48 san Status resolved => assigned
2015-09-18 11:57 san Note Added: 0045870
2015-09-18 15:31 san Note Added: 0045895
2015-09-30 11:13 git Note Added: 0046313
2015-09-30 11:24 afv Assigned To afv => san
2015-09-30 11:24 afv Status assigned => resolved
2015-10-05 13:39 git Note Added: 0046452
2015-10-05 13:40 afv Note Added: 0046453
2015-10-05 13:41 afv Note Edited: 0046453
2015-10-06 11:24 san Note Added: 0046492
2015-10-06 11:24 san Assigned To san => afv
2015-10-06 11:24 san Status resolved => assigned
2015-10-08 09:35 git Note Added: 0046579
2015-10-08 10:13 git Note Added: 0046581
2015-10-09 15:47 san Note Added: 0046630
2015-10-09 15:47 san Status assigned => feedback
2015-10-12 14:37 git Note Added: 0046677
2015-10-12 14:52 afv Assigned To afv => san
2015-10-12 14:52 afv Status feedback => resolved
2015-10-12 15:11 git Note Added: 0046678
2015-10-12 15:38 git Note Added: 0046679
2015-10-12 19:29 san Note Added: 0046682
2015-10-12 19:29 san Assigned To san => bugmaster
2015-10-12 19:29 san Status resolved => reviewed
2015-10-13 16:23 mkv Assigned To bugmaster => mkv
2015-10-14 12:42 mkv Note Added: 0046732
2015-10-14 12:42 mkv Assigned To mkv => afv
2015-10-14 12:42 mkv Status reviewed => assigned
2015-10-14 12:42 mkv Test case number => Not needed
2015-10-14 13:31 git Note Added: 0046735
2015-10-15 09:37 git Note Added: 0046762
2015-10-15 09:45 afv Note Added: 0046763
2015-10-15 09:45 afv Assigned To afv => bugmaster
2015-10-15 09:45 afv Status assigned => resolved
2015-10-15 12:07 san Note Added: 0046783
2015-10-15 12:07 san Status resolved => reviewed
2015-10-15 12:10 mkv Assigned To bugmaster => mkv
2015-10-16 16:46 mkv Note Added: 0047028
2015-10-16 16:46 mkv Assigned To mkv => afv
2015-10-16 16:46 mkv Status reviewed => feedback
2015-10-19 15:38 git Note Added: 0047160
2015-10-19 16:02 git Note Added: 0047166
2015-10-19 16:19 afv Assigned To afv => mkv
2015-10-19 17:02 mkv Assigned To mkv => bugmaster
2015-10-19 17:02 mkv Status feedback => reviewed
2015-10-19 17:03 mkv Assigned To bugmaster => mkv
2015-10-20 17:49 mkv Note Added: 0047232
2015-10-20 17:51 mkv Assigned To mkv => bugmaster
2015-10-20 17:51 mkv Status reviewed => feedback
2015-11-13 11:53 bugmaster Changeset attached => occt master de6273a3
2015-11-13 11:53 bugmaster Status feedback => verified
2015-11-13 11:53 bugmaster Resolution open => fixed
2015-11-17 16:37 kgv Relationship added related to 0024570
2016-03-23 16:00 kgv Relationship added related to 0027291
2016-04-17 14:42 git Note Added: 0053219
2016-04-17 14:42 git Note Added: 0053220
2016-04-17 14:42 git Note Added: 0053221
2016-04-17 14:42 git Note Added: 0053222
2016-04-20 15:42 aiv Fixed in Version => 7.0.0
2016-04-20 15:51 aiv Status verified => closed
2016-09-29 20:14 kgv Relationship added related to 0027922