View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0033426Open CASCADEOCCT:Data Exchangepublic2023-07-13 19:342023-09-21 13:02
Reporterdpasukhi Assigned Tobugmaster  
PrioritylowSeveritycrash 
Status verifiedResolutionfixed 
Product Version7.7.0 
Target VersionUnscheduledFixed in Version7.8.0 
Summary0033426: Data Exchange, VRML - Impossible to import VRML V1
DescriptionWe can't read our presended VRML occt/data/vrml/face.vrml
TagsNo tags attached.
Test case number33426

Relationships

related to 0030066 verifiedvglukhik Community Data Exchange - Fail to load VRML from ArcGIS 
has duplicate 0029539 closedbugmaster Open CASCADE Data Exchange - unable to read VRML from data samples 

Activities

dpasukhi

2023-07-31 13:14

administrator   ~0113815

The problem is too deep.
The last release at least from 7.5 don't be able to read file from occt/data/vrml folder.

git

2023-08-24 13:41

administrator   ~0114019

Branch CR33426 has been created by ichesnokova.

SHA-1: db4ba64f4ec4d5f46739377760777271c9dfd383


Detailed log of new commits:

Author: ichesnok
Date: Mon Jul 24 09:43:30 2023 +0100

    0033426: Data Exchange, VRML - Impossible to import VRML V1
    
    VrmlData_ShapeNode creating (for vrml v1 case) was added

git

2023-08-25 18:14

administrator   ~0114024

Branch CR33426 has been updated forcibly by ichesnokova.

SHA-1: f39d849c9607d2f70421085072109b17d31989ae

git

2023-08-25 19:07

administrator   ~0114025

Branch CR33426 has been updated forcibly by ichesnokova.

SHA-1: b9382108b3a74d9e80b8acb1a6c2162c8a3334ff

git

2023-08-31 10:57

administrator   ~0114043

Branch CR33426 has been updated forcibly by ichesnokova.

SHA-1: f0e27caf037a3cbbe94ebb115c0a515f73844272

ichesnokova

2023-08-31 16:51

developer   ~0114049

Dear ika,
please review branch CR33426.
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33426-master-ichesnok/view/COMPARE/

git

2023-09-05 10:25

administrator   ~0114072

Branch CR33426 has been updated forcibly by ichesnokova.

SHA-1: dc96d288adeebd8479d63fd5c8bcd2faf3fc1225

ika

2023-09-08 18:24

developer   ~0114112

Dear ichesnokova,

1) Warning:
http://jenkins-test-10.nnov.opencascade.com/view/CR33426-master-ichesnok/view/OCCT%20compile/job/CR33426-master-ichesnok-OCCT-Ubuntu2004-64-opt-compile/5/parsed_console/

VrmlData_Material.hxx
2) strange number of spaces in AmbientColor() and SetAmbientColor() methods, please fix.

VrmlData_Group.cxx
3)
+ if (anIt.Value()->IsKind(STANDARD_TYPE(VrmlData_Coordinate)))
+ {
+ aCoord = Handle(VrmlData_Coordinate)::DownCast(anIt.Value());
+ }
+ else if (anIt.Value()->IsKind(STANDARD_TYPE(VrmlData_IndexedFaceSet)))
+ {
+ anIndFaceSet = Handle(VrmlData_IndexedFaceSet)::DownCast(anIt.Value());
+ anIndFaceSet->SetCoordinates(aCoord);
+ }
+ else if (anIt.Value()->IsKind(STANDARD_TYPE(VrmlData_IndexedLineSet)))
+ {
+ anIndLineSet = Handle(VrmlData_IndexedLineSet)::DownCast(anIt.Value());
+ anIndLineSet->SetCoordinates(aCoord);
+ }

Do you always sure that aCoord will be not null? The code is not protected from it.
Please add a comment if it is strictly standardized by VRML format, or add a protection.

VrmlData_Material.cxx
4) Please add separators between the methods.

git

2023-09-13 11:50

administrator   ~0114155

Branch CR33426_1 has been created by ichesnokova.

SHA-1: a85a8e34cfcea4e5fa834a286510bb53856549e2


Detailed log of new commits:

Author: ichesnok
Date: Mon Jul 24 09:43:30 2023 +0100

    0033426: Data Exchange, VRML - Impossible to import VRML V1
    
    VrmlData_ShapeNode creating (for vrml v1 case) was added

Author: ichesnok
Date: Wed Sep 13 09:48:40 2023 +0100

    remarks fixed

ichesnokova

2023-09-13 11:58

developer   ~0114156

Dear ika,
please review branch CR33426_1.
About the 2nd remark, I left it so that the general style of file is preserved.

git

2023-09-14 10:17

administrator   ~0114160

Branch CR33426_1 has been updated forcibly by ichesnokova.

SHA-1: 06f2625c35e9a8897ad4989835fab40da23529b5

ika

2023-09-14 14:18

developer   ~0114167

No more remarks.

Dear bugmaster,
please integrate
OCCT: CR33426_1

jokwajeb

2023-09-19 15:15

administrator   ~0114186

Combination -
OCCT branch : IR-2023-09-15
master SHA - 06f2625c35e9a8897ad4989835fab40da23529b5
38e09ead3f71b0f6ee0ece13e05a6f9009c86eba
Products branch : master SHA - c00d777bc21fca09e275ef4c9272442b9bd1caef
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18263.210000000217 / 17992.18000000026 [+1.51%]
Products
Total CPU difference: 12050.169999999993 / 11923.35000000001 [+1.06%]
Windows-64-VC142:
OCCT
Total CPU difference: 18536.21875 / 19076.859375 [-2.83%]
Products
Total CPU difference: 13940.40625 / 14318.203125 [-2.64%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2023-09-21 13:02

administrator   ~0114226

Branch CR33426 has been deleted by mnt.

SHA-1: dc96d288adeebd8479d63fd5c8bcd2faf3fc1225

git

2023-09-21 13:02

administrator   ~0114227

Branch CR33426_1 has been deleted by mnt.

SHA-1: 06f2625c35e9a8897ad4989835fab40da23529b5

Related Changesets

occt: master 06f2625c

2023-07-24 11:43:30

ichesnok

Details Diff		 0033426: Data Exchange, VRML - Impossible to import VRML V1

VrmlData_ShapeNode creating (for vrml v1 case) was added		 Affected Issues
0033426
mod - src/VrmlData/VrmlData_Group.cxx Diff File
mod - src/VrmlData/VrmlData_Material.cxx Diff File
mod - src/VrmlData/VrmlData_Material.hxx Diff File
mod - src/VrmlData/VrmlData_Scene.cxx Diff File
add - tests/bugs/stlvrml/bug33426 Diff File

Issue History

Date Modified Username Field Change
2023-07-13 19:34 dpasukhi New Issue
2023-07-13 19:34 dpasukhi Assigned To => ika
2023-07-13 19:34 dpasukhi Relationship added related to 0030066
2023-07-14 11:54 dpasukhi Assigned To ika => dpasukhi
2023-07-14 11:54 dpasukhi Summary Data Exchange, VRLM - Impossible to import VRLM V1 [Regression] => Data Exchange, VRML - Impossible to import VRML V1
2023-07-14 11:54 dpasukhi Description Updated
2023-07-14 11:56 dpasukhi Assigned To dpasukhi => ika
2023-07-14 11:56 dpasukhi Target Version 7.7.2 => Unscheduled
2023-07-18 14:11 ika Assigned To ika => ichesnokova
2023-07-18 16:18 dpasukhi Product Version => 7.7.0
2023-07-18 16:18 dpasukhi Status new => assigned
2023-07-31 13:14 dpasukhi Note Added: 0113815
2023-07-31 13:22 dpasukhi Priority normal => low
2023-08-24 13:41 git Note Added: 0114019
2023-08-25 18:14 git Note Added: 0114024
2023-08-25 19:07 git Note Added: 0114025
2023-08-31 10:57 git Note Added: 0114043
2023-08-31 16:51 ichesnokova Assigned To ichesnokova => ika
2023-08-31 16:51 ichesnokova Status assigned => resolved
2023-08-31 16:51 ichesnokova Note Added: 0114049
2023-09-01 18:22 ichesnokova Relationship added related to 0029539
2023-09-05 10:25 git Note Added: 0114072
2023-09-08 18:24 ika Assigned To ika => ichesnokova
2023-09-08 18:24 ika Status resolved => assigned
2023-09-08 18:24 ika Note Added: 0114112
2023-09-13 11:50 git Note Added: 0114155
2023-09-13 11:58 ichesnokova Assigned To ichesnokova => ika
2023-09-13 11:58 ichesnokova Status assigned => resolved
2023-09-13 11:58 ichesnokova Note Added: 0114156
2023-09-14 10:17 git Note Added: 0114160
2023-09-14 14:18 ika Assigned To ika => bugmaster
2023-09-14 14:18 ika Status resolved => reviewed
2023-09-14 14:18 ika Note Added: 0114167
2023-09-19 15:04 Changeset attached => occt master 06f2625c
2023-09-19 15:15 jokwajeb Note Added: 0114186
2023-09-20 19:12 vglukhik Status reviewed => verified
2023-09-20 19:12 vglukhik Resolution open => fixed
2023-09-20 19:12 vglukhik Fixed in Version => 7.8.0
2023-09-20 19:12 vglukhik Test case number => 33426
2023-09-20 19:13 vglukhik Relationship replaced has duplicate 0029539
2023-09-21 13:02 git Note Added: 0114226
2023-09-21 13:02 git Note Added: 0114227