MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0030716Open CASCADE[OCCT] OCCT:Visualizationpublic2019-05-17 12:042019-08-09 19:19
Reportertizmaylo 
Assigned Tobugmaster 
PrioritynormalSeverityintegration request 
StatusverifiedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version[OCCT] 7.4.0Fixed in Version 
Summary0030716: Visualization - change default polygon offset units property from 0.0 to 1.0
DescriptionCurrently the default constructor of Graphic3d_PolygonOffset class sets the value of its Units property to 0.0f and it is a default setting used in ShadingAspect of Prs3d_Drawer class. But there are some situations when the plane which visualized triangles and segments are located in is parallel to the view plane and segments are hided behind triangles. Standard mechanisms of solving of such problem (like setting the display priority for Prs3d_Presentation objects) may be not applicable or easy to implement. However it is obvious that edges should not be hided behind triangles almost always in such situations. So it would be appropriate to change the default value of the Units property of Graphic3d_PolygonOffset class to 1.0f.
Steps To ReproduceNot required
TagsNo tags attached.
Test case numberNot required
Attached Files

- Relationships
related to 0030689closedbugmaster Community Visualization - Free edges disappear depending on viewing perspective 
related to 0024867closedbugmaster Open CASCADE [Regression] Visualization - polygon offsets look broken 
related to 0030721verifiedbugmaster Open CASCADE Visualization - Arrows in dimensions are drawn behind some other lines after applying 30716 
related to 0030887newnds Open CASCADE Visualization - provide information about Graphic3d_PolygonOffset default value change in upgrade 7.4.0 

-  Notes
(0084417)
git (administrator)
2019-05-17 12:09

Branch CR30716 has been created by tizmaylo.

SHA-1: bb60385cb6d676479720f15c215f892b99521099


Detailed log of new commits:

Author: tiv
Date: Fri May 17 12:01:01 2019 +0300

     0030716: Visualization - Set polygon offset units property to 1.0
    
    The default value of the Units property of the Graphic3d_PolygonOffset class is changed to 1.0f (instead of 0.0f used previously).
(0084424)
tizmaylo (developer)
2019-05-17 14:26

Patch is ready for review: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30716-master-TIV/view/ALL/ [^]
(0084429)
kgv (developer)
2019-05-17 15:36

Please raise the patch.
(0084471)
bugmaster (administrator)
2019-05-20 11:12

Combination -
OCCT branch : CR30716
master SHA - bb60385cb6d676479720f15c215f892b99521099
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - bde66da19002bfd6a68440a079d00728c5796b30
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16381.320000000025 / 16346.709999999983 [+0.21%]
Products
Total CPU difference: 10503.220000000054 / 10516.200000000064 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 17743.859375 / 17692.25 [+0.29%]
Products
Total CPU difference: 12066.390625 / 12107.796875 [-0.34%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0084504)
tizmaylo (developer)
2019-05-21 12:52
edited on: 2019-05-21 13:42

The problem with appearance of arrows in dimension objects will be fixed in 0030721.

(0084635)
git (administrator)
2019-05-26 10:48

Branch CR30716 has been deleted by inv.

SHA-1: bb60385cb6d676479720f15c215f892b99521099

- Related Changesets
occt: master 8fd45ae7
Timestamp: 2019-05-17 09:01:01
Author: tiv
Committer: bugmaster
Details ] Diff ]
0030716: Visualization - Set polygon offset units property to 1.0

The default value of the Units property of the Graphic3d_PolygonOffset class is changed to 1.0f (instead of 0.0f used previously).
mod - src/Graphic3d/Graphic3d_PolygonOffset.hxx Diff ] File ]

- Issue History
Date Modified Username Field Change
2019-05-17 12:04 tizmaylo New Issue
2019-05-17 12:04 tizmaylo Assigned To => tizmaylo
2019-05-17 12:09 git Note Added: 0084417
2019-05-17 12:18 kgv Summary Visualization - Set polygon offset units property to 1.0 => Visualization - set default polygon offset units property to 1.0
2019-05-17 12:18 kgv Severity tweak => integration request
2019-05-17 12:19 kgv Relationship added related to 0030689
2019-05-17 12:19 kgv Summary Visualization - set default polygon offset units property to 1.0 => Visualization - change default polygon offset units property from 0.0 to 1.0
2019-05-17 12:26 kgv Relationship added child of 0004895
2019-05-17 12:43 kgv Relationship added related to 0024867
2019-05-17 14:26 tizmaylo Note Added: 0084424
2019-05-17 14:27 tizmaylo Assigned To tizmaylo => kgv
2019-05-17 14:27 tizmaylo Status new => resolved
2019-05-17 14:27 tizmaylo Steps to Reproduce Updated View Revisions
2019-05-17 15:36 kgv Note Added: 0084429
2019-05-17 15:36 kgv Assigned To kgv => bugmaster
2019-05-17 15:36 kgv Status resolved => reviewed
2019-05-20 11:03 bugmaster Test case number => Not required
2019-05-20 11:12 bugmaster Note Added: 0084471
2019-05-20 11:12 bugmaster Status reviewed => tested
2019-05-21 12:50 tizmaylo Relationship added related to 0030721
2019-05-21 12:52 tizmaylo Note Added: 0084504
2019-05-21 13:42 tizmaylo Note Edited: 0084504 View Revisions
2019-05-25 19:58 bugmaster Changeset attached => occt master 8fd45ae7
2019-05-25 19:58 bugmaster Status tested => verified
2019-05-25 19:58 bugmaster Resolution open => fixed
2019-05-26 10:48 git Note Added: 0084635
2019-08-09 19:19 nds Relationship added related to 0030887


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker