View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0026363 | Open CASCADE | OCCT:Visualization | public | 2015-06-23 10:07 | 2016-04-20 15:48 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.9.0 | ||||
| Target Version | 7.0.0 | Fixed in Version | 7.0.0 | ||
| Summary | 0026363: Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode | ||||
| Description | Current implementation of OpenGl_View::ShaderSource::Load() uses Standard_ASSERT_RETURN() in case of missing files. This results in weird error reporting when GLSL program has been build with incomplete sources list. | ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR26363 has been created by kgv. SHA-1: 3d07f786609ede1f33b903332c6bc5d1d3beb034 Detailed log of new commits: Author: kgv Date: Tue Jun 23 10:12:03 2015 +0300 0026363: Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode OpenGl_View::ShaderSource::Load() - print error about missing files. |
|
|
Patch is ready for review in branch CR26363. |
|
|
Dear bugmaster, please test the patch. |
|
|
Dear BugMaster, Branch CR26363 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode. SHA-1: 3d07f786609ede1f33b903332c6bc5d1d3beb034 Number of compiler warnings: occt component : Linux: 25 (25 on master) Windows: 0 (0 on master) products component : Linux: 37 (37 on master) Windows: 0 (0 on master) Regressions/Differences/Improvements: No regressions/differences Testing cases: Not needed Testing on Linux: occt component : Total MEMORY difference: 97770458 / 98272225 [-0.51%] Total CPU difference: 18453.930000000055 / 18555.40000000014 [-0.55%] products component : Total MEMORY difference: 24253444 / 24316064 [-0.26%] Total CPU difference: 8207.90000000001 / 7858.430000000035 [+4.45%] Testing on Windows: occt component : Total MEMORY difference: 56553621 / 56649611 [-0.17%] Total CPU difference: 17328.38827869876 / 17577.05387269885 [-1.41%] products component : Total MEMORY difference: 15546726 / 15550884 [-0.03%] Total CPU difference: 6385.370531599977 / 6414.932721099968 [-0.46%] There are no differences in images found by testdiff. |
|
|
Branch CR26363 has been deleted by kgv. SHA-1: 3d07f786609ede1f33b903332c6bc5d1d3beb034 |
|
occt: master 73722cc9 2015-06-23 07:12:03 Committer: bugmaster Details Diff |
0026363: Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode OpenGl_View::ShaderSource::Load() - print error about missing files. |
Affected Issues 0026363 |
|
| mod - src/OpenGl/OpenGl_View.hxx | Diff File | ||
| mod - src/OpenGl/OpenGl_View_Raytrace.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-06-23 10:07 | kgv | New Issue | |
| 2015-06-23 10:07 | kgv | Assigned To | => kgv |
| 2015-06-23 10:12 | git | Note Added: 0042328 | |
| 2015-06-23 10:12 | kgv | Note Added: 0042329 | |
| 2015-06-23 10:12 | kgv | Assigned To | kgv => dbp |
| 2015-06-23 10:12 | kgv | Severity | minor => trivial |
| 2015-06-23 10:12 | kgv | Status | new => resolved |
| 2015-06-24 11:30 |
|
Note Added: 0042405 | |
| 2015-06-24 11:30 |
|
Assigned To | dbp => bugmaster |
| 2015-06-24 11:30 |
|
Status | resolved => reviewed |
| 2015-06-24 16:54 |
|
Assigned To | bugmaster => mkv |
| 2015-06-25 11:19 |
|
Note Added: 0042437 | |
| 2015-06-25 11:19 |
|
Assigned To | mkv => bugmaster |
| 2015-06-25 11:19 |
|
Status | reviewed => tested |
| 2015-06-25 11:19 |
|
Test case number | => Not needed |
| 2015-06-26 13:42 | bugmaster | Changeset attached | => occt master 73722cc9 |
| 2015-06-26 13:42 | bugmaster | Status | tested => verified |
| 2015-06-26 13:42 | bugmaster | Resolution | open => fixed |
| 2015-07-27 13:39 | git | Note Added: 0043524 | |
| 2016-04-20 15:44 |
|
Fixed in Version | => 7.0.0 |
| 2016-04-20 15:48 |
|
Status | verified => closed |
