View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025101 | Community | OCCT:Foundation Classes | public | 2014-07-22 16:38 | 2014-11-11 12:59 |
| Reporter | Timo | Assigned To | bugmaster | ||
| Priority | normal | Severity | text | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.7.1 | ||||
| Target Version | 6.8.0 | Fixed in Version | 6.8.0 | ||
| Summary | 0025101: Typo in code documentation of gp_Trsf::SetValues | ||||
| Description | Currently, the code documentation of gp_Trsf::SetValues is: "Sets the coefficients of the transformation. The transformation of the point x,y,z is the point x',y',z' with : x' = a11 x + a12 y + a13 z + a14 y' = a21 x + a22 y + a23 z + a24 z' = a31 x + a32 y + a43 z + a34 " In the last mentioned line, the parameter a43 should be a33. Additionally, parameter Tolang isn't used anymore and could be removed. | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Additionally, two remarks about another class: gp_GTrsf. The code documentation of gp_GTrsf::Multiplied and gp_GTrsf::Multiply seems to be interchanged. One of these documentations is: "Computes the transformation composed with <me> and T. <me> = T * <me>" but should be: "Computes the transformation composed with <me> and T. <me> = <me> * T" The same documentation should also be done for gp_Trsf. |
|
|
The original typo is corrected in context of 0025194 |
|
|
Branch CR25101 has been created by abv. SHA-1: a1dc44ba7da8d0f53ebfd2abb59cd77f88fdd554 Detailed log of new commits: Author: abv Date: Fri Sep 26 13:57:15 2014 +0400 0025101: Typo in code documentation of gp_Trsf::SetValues Documentation of methods Multiply() and Multiplied() corrected in classes gp_(G)Trsf(2d) |
|
|
Correction pushed to branch CR25101, please review |
|
|
It's OK, just one remark: In gp_Trsf.cdl and gp_Trsf2d.cdl there is an English spelling mistake in the documentation, which was introduced by 0025194: "orthogonalyzed" should be changed to "orthogonalized" |
|
|
Thank you Timo, I have corrected that |
|
|
Branch CR25101 has been deleted by inv. SHA-1: a1dc44ba7da8d0f53ebfd2abb59cd77f88fdd554 |
|
occt: master 01a7df1b 2014-09-26 09:57:15
Committer: bugmaster Details Diff |
0025101: Typo in code documentation of gp_Trsf::SetValues Documentation of methods Multiply() and Multiplied() corrected in classes gp_(G)Trsf(2d) |
Affected Issues 0025101 |
|
| mod - src/gp/gp_Trsf.cdl | Diff File | ||
| mod - src/gp/gp_Trsf2d.cdl | Diff File | ||
|
occt: master 008297e1 2014-09-26 09:57:15
Committer: bugmaster Details Diff |
0025101: Typo in code documentation of gp_Trsf::SetValues Documentation of methods Multiply() and Multiplied() corrected in classes gp_(G)Trsf(2d) |
Affected Issues 0025101 |
|
| mod - src/gp/gp_GTrsf.cdl | Diff File | ||
| mod - src/gp/gp_GTrsf2d.cdl | Diff File | ||
| mod - src/gp/gp_Trsf.cdl | Diff File | ||
| mod - src/gp/gp_Trsf2d.cdl | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-22 16:38 | Timo | New Issue | |
| 2014-07-22 16:38 | Timo | Assigned To | => abv |
| 2014-07-22 17:40 | Timo | Description Updated | |
| 2014-07-25 17:51 | Timo | Note Added: 0030429 | |
| 2014-07-25 17:52 | Timo | Note Edited: 0030429 | |
| 2014-07-25 17:54 |
|
Assigned To | abv => ysn |
| 2014-07-25 17:54 |
|
Status | new => assigned |
| 2014-09-26 13:28 |
|
Relationship added | related to 0025194 |
| 2014-09-26 13:29 |
|
Note Added: 0032223 | |
| 2014-09-26 13:59 | git | Note Added: 0032225 | |
| 2014-09-26 14:00 |
|
Note Added: 0032226 | |
| 2014-09-26 14:00 |
|
Assigned To | ysn => Timo |
| 2014-09-26 14:00 |
|
Status | assigned => resolved |
| 2014-09-29 12:49 | Timo | Note Added: 0032292 | |
| 2014-09-29 12:49 | Timo | Assigned To | Timo => abv |
| 2014-09-29 12:50 | Timo | Status | resolved => assigned |
| 2014-09-29 15:11 |
|
Note Added: 0032299 | |
| 2014-09-29 15:31 | bugmaster | Changeset attached | => occt master 01a7df1b |
| 2014-09-29 15:31 | bugmaster | Changeset attached | => occt master 008297e1 |
| 2014-09-29 15:31 | bugmaster | Assigned To | abv => bugmaster |
| 2014-09-29 15:31 | bugmaster | Status | assigned => verified |
| 2014-09-29 15:31 | bugmaster | Resolution | open => fixed |
| 2014-09-30 11:36 | git | Note Added: 0032415 | |
| 2014-11-11 12:44 |
|
Fixed in Version | => 6.8.0 |
| 2014-11-11 12:59 |
|
Status | verified => closed |
