View Issue Details

IDProjectCategoryView StatusLast Update
0033410CommunityOCCT:Data Exchangepublic2024-04-08 19:28
Reporterwinfried_156604 Assigned Tovglukhik  
PrioritynormalSeverityintegration request 
Status verifiedResolutionfixed 
PlatformMacOSOS 
Product Version7.7.1 
Target VersionUnscheduled 
Summary0033410: Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries
DescriptionWhen testing, we encountered an issue importing some TRIANGULATED_FACE entries from a step file.

Currently, OCCT is unable to import entries where no pnindex identifiers are specified. In this case, it seems like the correct behaviour is to fallback to indexes in the underlying coordinate set.

The entries that fail to import look as below;

# 466=COORDINATES_LIST('',4,((-157.814575,-532.5,616.),(-157.814575,-167.5,616.),(-25.814579,-532.5,616.),(-25.814579,-167.5,616.)));
# 467=TRIANGULATED_FACE('',# 466,4,((0.,0.,1.)),$,(),((1,3,4),(4,2,1)));
# 468=TESSELLATED_SHELL('',(# 467),$);

Here is the relevant entry from the standard
https://www.steptools.com/stds/smrl/data/modules/tessellated_geometry/sys/4_info_reqs.htm#tessellated_geometry_arm.triangulated_face

Attached is a patch that fixed the behaviour in internal testing, and an example step file that fails to import with OCCT 7.7.1
Steps To ReproduceImport example.step before and after applying the provided patch
TagsNo tags attached.
Test case number

Attached Files

  • occt_import_no_pnvals.patch (1,924 bytes)
  • example.step (9,056 bytes)

Relationships

related to 0030024 verifiedsnn Community Data Exchange - STEP export support of BRep shapes based on tessellated geometry 
related to 0033623 feedbackrobertlipman Community Data Exchange, Step Import - STEP tessellated geometry not reading 
has duplicate 0033412 closedbugmaster Community Fix issue importing TRIANGULATED_FACE from STEP where there are no pnval entries 
has duplicate 0033411 closedbugmaster Community Fix issue importing TRIANGULATED_FACE from STEP where there are no pnval entries 
has duplicate 0033409 closedbugmaster Community Fix issue importing TRIANGULATED_FACE from STEP where there are no pnval entries 

Activities

winfried_156604

2023-06-21 03:33

reporter  

occt_import_no_pnvals.patch (1,924 bytes)
example.step (9,056 bytes)

dpasukhi

2023-06-21 11:12

administrator   ~0113667

Last edited: 2023-06-21 11:13

Dear @winfried_156604
Thank you for your investigation.

To mark you as an author you need to sign the agreement.
https://dev.opencascade.org/get_involved
As soon as you send us the signed document we give you write permit. And after that you will be an author of your commit. And be able to push.

Best regards, Dmitrii

git

2024-03-12 21:01

administrator   ~0115339

Branch CR33410 has been created by ichesnokova.

SHA-1: 2ee43dc2400c190d664b84a0865ab27148305352


Detailed log of new commits:

Author: ichesnok
Date: Tue Mar 12 18:01:09 2024 +0000

    0033410: Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries
    
    Problem fixed by using array of nodes in case when aPnindices is empty.

git

2024-03-14 12:15

administrator   ~0115360

Branch CR33410 has been updated forcibly by ichesnokova.

SHA-1: 188ecd8f4743ea35282c45357cf847e027948cec

git

2024-03-15 13:31

administrator   ~0115373

Branch CR33410 has been updated forcibly by ichesnokova.

SHA-1: 245c35ae14f11d6d16867231fc3decf6978a460f

ichesnokova

2024-03-15 16:39

developer   ~0115377

Dear ika,
please review branch CR33410.
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33410-master-ichesnok/view/COMPARE/

ika

2024-03-18 15:42

developer   ~0115408

No remarks.

Dear bugmaster,
please integrate OCCT: CR33410

vglukhik

2024-03-25 20:24

administrator   ~0115463

Combination -
OCCT branch : IR-2024-03-22
master SHA - 983e35ed71b95137772111751ad41a5da4937005
d2ef868da4165400c82322bd7f11b652decce47a
Products branch : master SHA - 4019cd9a039aa9bb8252b865410207f8d4cf3eb4
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18418.419999999944 / 18393.07999999986 [+0.14%]
Products
Total CPU difference: 11606.279999999959 / 11191.209999999957 [+3.71%]
Windows-64-VC142:
OCCT
Total CPU difference: 20726.4375 / 20708.5625 [+0.09%]
Products
Total CPU difference: 12849.890625 / 12614.34375 [+1.87%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2024-04-08 19:28

administrator   ~0115653

Branch CR33410 has been deleted by vglukhik.

SHA-1: 245c35ae14f11d6d16867231fc3decf6978a460f

Related Changesets

occt: master 983e35ed

2024-03-12 18:01:09

ichesnok


Committer: vglukhik Details Diff
0033410: Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries

Problem fixed by using array of nodes in case when aPnindices is empty.
Affected Issues
0033410
mod - src/StepToTopoDS/StepToTopoDS_TranslateFace.cxx Diff File
add - tests/bugs/step/bug33410 Diff File

Issue History

Date Modified Username Field Change
2023-06-21 03:33 winfried_156604 New Issue
2023-06-21 03:33 winfried_156604 Assigned To => winfried_156604
2023-06-21 03:33 winfried_156604 File Added: occt_import_no_pnvals.patch
2023-06-21 03:33 winfried_156604 File Added: example.step
2023-06-21 11:09 dpasukhi Assigned To winfried_156604 => dpasukhi
2023-06-21 11:10 dpasukhi Status new => assigned
2023-06-21 11:10 dpasukhi Target Version => 7.7.2
2023-06-21 11:10 dpasukhi Severity minor => integration request
2023-06-21 11:12 dpasukhi Note Added: 0113667
2023-06-21 11:13 dpasukhi Note Edited: 0113667
2023-06-21 14:28 dpasukhi Relationship added duplicate of 0033412
2023-06-21 14:28 dpasukhi Relationship added duplicate of 0033411
2023-06-21 14:28 dpasukhi Relationship added duplicate of 0033409
2023-06-21 14:32 dpasukhi Relationship added related to 0030024
2023-06-21 15:04 dpasukhi Summary Fix issue importing TRIANGULATED_FACE from STEP where there are no pnval entries => Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries
2023-06-21 15:04 dpasukhi Description Updated
2023-08-01 14:55 dpasukhi Target Version 7.7.2 => Unscheduled
2023-08-07 16:02 vglukhik Relationship replaced has duplicate 0033412
2023-08-07 16:03 vglukhik Relationship replaced has duplicate 0033411
2023-08-07 16:03 vglukhik Relationship replaced has duplicate 0033409
2024-03-01 22:53 dpasukhi Relationship added related to 0033623
2024-03-11 18:29 dpasukhi Assigned To dpasukhi => ichesnokova
2024-03-12 21:01 git Note Added: 0115339
2024-03-14 12:15 git Note Added: 0115360
2024-03-15 13:31 git Note Added: 0115373
2024-03-15 16:39 ichesnokova Assigned To ichesnokova => ika
2024-03-15 16:39 ichesnokova Status assigned => resolved
2024-03-15 16:39 ichesnokova Note Added: 0115377
2024-03-18 15:42 ika Assigned To ika => bugmaster
2024-03-18 15:42 ika Status resolved => reviewed
2024-03-18 15:43 ika Note Added: 0115408
2024-03-25 04:57 vglukhik Changeset attached => occt master 983e35ed
2024-03-25 04:57 vglukhik Assigned To bugmaster => vglukhik
2024-03-25 04:57 vglukhik Status reviewed => verified
2024-03-25 04:57 vglukhik Resolution open => fixed
2024-03-25 20:24 vglukhik Note Added: 0115463
2024-04-08 19:28 git Note Added: 0115653