View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0026908Open CASCADEOCCT:Visualizationpublic2015-11-20 12:432016-04-20 15:50
ReporteriskAssigned Toabv 
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Target Version7.0.0Fixed in Version7.0.0 
Summary0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
DescriptionCurrent implementation TKOpenGl for android contain compiler warnings:

OpenGl_Structure.cxx:66:57: warning: unused parameter 'theWorkspace' [-Wunused-parameter]
OpenGl_Workspace.cxx:1214:76: warning: unused parameter 'theBufferType' [-Wunused-parameter]
OpenGl_LineAttributes.cxx:523:65:warning: unused parameter 'theGlCtx' [-Wunused-parameter]
OpenGl_LineAttributes.cxx:553:55: warning: unused parameter 'theType' [-Wunused-parameter]
OpenGl_Texture.cxx:721:67: warning: unused parameter 'theSizeX' [-Wunused-parameter]
OpenGl_Texture.cxx:722:67: warning: unused parameter 'theSizeY' [-Wunused-parameter]
OpenGl_Texture.cxx:723:67: warning: unused parameter 'theFormat' [-Wunused-parameter]
OpenGl_Clipping.cxx:212:70: warning: unused parameter 'theGlCtx' [-Wunused-parameter]
OpenGl_GraphicDriver.cxx:738:81:warning: unused parameter 'AWindow' [-Wunused-parameter]
OpenGl_Sampler.cxx:91:44: warning: unused parameter 'theContext' [-Wunused-parameter]
OpenGl_Sampler.cxx:92:44: warning: unused parameter 'theUnit' [-Wunused-parameter]
OpenGl_Sampler.cxx:106:46: warning: unused parameter 'theContext' [-Wunused-parameter]
OpenGl_Sampler.cxx:107:46: warning: unused parameter 'theUnit' [-Wunused-parameter]
OpenGl_Sampler.cxx:121:52: warning: unused parameter 'theContext' [-Wunused-parameter]
OpenGl_Sampler.cxx:122:52: warning: unused parameter 'theParam' [-Wunused-parameter]
OpenGl_Sampler.cxx:123:52: warning: unused parameter 'theValue' [-Wunused-parameter]
OpenGl_ShaderProgram.cxx:813:82: warning: unused parameter 'theValue' [-Wunused-parameter]
OpenGl_ShaderProgram.cxx:845:82: warning: unused parameter 'theCount' [-Wunused-parameter]
OpenGl_ShaderProgram.cxx:846:82: warning: unused parameter 'theValue' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:94:67: warning: unused parameter 'theGlCtx' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:95:52: warning: unused parameter 'theComponentsNb' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:96:52: warning: unused parameter 'theElemsNb' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:97:52: warning: unused parameter 'theData' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:140:67: warning: unused parameter 'theGlCtx' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:141:52: warning: unused parameter 'theComponentsNb' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:142:52: warning: unused parameter 'theElemsNb' [-Wunused-parameter]
OpenGl_TextureBufferArb.cxx:143:52: warning: unused parameter 'theData' [-Wunused-parameter]
OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::uv' [-Wmissing-field-initializers]
OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::px' [-Wmissing-field-initializers]
OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::texture' [-Wmissing-field-initializers]
Steps To ReproduceN/A
TagsNo tags attached.
Test case number

Activities

git

2015-11-24 15:31

administrator   ~0048525

Branch CR26908 has been created by isk.

SHA-1: 30b93c8b98167e131e26aeb1aeaec7536fb5d526


Detailed log of new commits:

Author: isk
Date: Tue Nov 24 15:31:03 2015 +0300

    0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target

isk

2015-11-24 15:35

developer   ~0048526

Dear Kirill,
please review the branch CR26908.

git

2015-12-04 10:45

administrator   ~0048743

Branch CR26908 has been updated forcibly by isk.

SHA-1: f97ab7e83a10e2086e95f2fb4db45d06096e894f

git

2015-12-08 14:01

administrator   ~0048840

Branch CR26908 has been updated forcibly by isk.

SHA-1: 0b57c86d0affca6803a1250729adc36c63084a6e

isk

2015-12-08 14:01

developer   ~0048841

Rebase the branch CR26908 on the current master.

git

2015-12-10 15:33

administrator   ~0048960

Branch CR26908 has been updated by kgv.

SHA-1: 788c2b1afbec4352217834ce2128853ecae50bf9


Detailed log of new commits:

Author: kgv
Date: Thu Dec 10 15:33:50 2015 +0300

    OpenGl_ShaderProgram::SetUniform() - return false where needed

git

2015-12-10 15:40

administrator   ~0048962

Branch CR26908_1 has been created by kgv.

SHA-1: b947b4643fbf1c5498483c7a75ed3cb1cb8783d6


Detailed log of new commits:

Author: isk
Date: Thu Dec 10 15:38:30 2015 +0300

    0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
    
    Support TBO on OpenGL ES 3.2+

kgv

2015-12-10 15:42

developer   ~0048964

Please check compilation of patch in branch CR26908_1, testing is not needed.

git

2015-12-11 14:49

administrator   ~0049036

Branch CR26908_1 has been updated forcibly by apv.

SHA-1: bf6032a28556eb6460ad7a23ce30145ab939159b

apv

2015-12-11 14:49

tester   ~0049037

Branch CR26908_1 has been rebased on the current master

git

2015-12-15 10:58

administrator   ~0049128

Branch CR26908_1 has been updated by kgv.

SHA-1: b8a9bd8af55d9e2cb709748fcc1d01fb1db94794


Detailed log of new commits:

Author: kgv
Date: Tue Dec 15 10:56:46 2015 +0300

    fix new warning

git

2015-12-15 10:59

administrator   ~0049129

Branch CR26908_2 has been created by kgv.

SHA-1: fe27acbf1d2976b14ecd8d6e9400c3ce30b67034


Detailed log of new commits:

Author: isk
Date: Tue Dec 15 10:58:58 2015 +0300

    0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
    
    Support TBO on OpenGL ES 3.2+

kgv

2015-12-15 11:00

developer   ~0049130

Patch has been updated to eliminate new warning on non-Android platforms.

git

2015-12-15 18:19

administrator   ~0049179

Branch CR26908_2 has been updated forcibly by inv.

SHA-1: c1dff3cd9e9d4f4fa7488be6ae7c1ba139fd417e

bugmaster

2015-12-16 21:20

administrator   ~0049221

Warnings on Android were eliminated.
New warnings were not detected
http://jenkins-test-03.nnov.opencascade.com:8080/view/Warnings%20OCCT%20/

There are no regressions testing on Linux and Windows platforms
occt
Windows
Total MEMORY difference: 54269737 / 55997393 [-3.09%]
Total CPU difference: 17417.371249098724 / 17618.019735298913 [-1.14%]
Linux
Total MEMORY difference: 88335602 / 92539349 [-4.54%]
Total CPU difference: 18740.920000000144 / 18299.43999999996 [+2.41%]

Difference in images were not detected

git

2016-04-17 13:54

administrator   ~0052990

Branch CR26908 has been deleted by kgv.

SHA-1: 788c2b1afbec4352217834ce2128853ecae50bf9

git

2016-04-17 13:54

administrator   ~0052991

Branch CR26908_1 has been deleted by kgv.

SHA-1: b8a9bd8af55d9e2cb709748fcc1d01fb1db94794

git

2016-04-17 13:54

administrator   ~0052992

Branch CR26908_2 has been deleted by kgv.

SHA-1: c1dff3cd9e9d4f4fa7488be6ae7c1ba139fd417e

Related Changesets

occt: master 20aeeb7b

2015-12-15 07:58:58

abv


Committer: abv Details Diff		 0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target

Support TBO on OpenGL ES 3.2+		 Affected Issues
0026908
mod - src/OpenGl/OpenGl_ArbTBO.hxx Diff File
mod - src/OpenGl/OpenGl_Clipping.cxx Diff File
mod - src/OpenGl/OpenGl_Context.cxx Diff File
mod - src/OpenGl/OpenGl_GlFunctions.hxx Diff File
mod - src/OpenGl/OpenGl_GraphicDriver.cxx Diff File
mod - src/OpenGl/OpenGl_LineAttributes.cxx Diff File
mod - src/OpenGl/OpenGl_Sampler.cxx Diff File
mod - src/OpenGl/OpenGl_ShaderProgram.cxx Diff File
mod - src/OpenGl/OpenGl_Structure.cxx Diff File
mod - src/OpenGl/OpenGl_TextBuilder.cxx Diff File
mod - src/OpenGl/OpenGl_Texture.cxx Diff File
mod - src/OpenGl/OpenGl_TextureBufferArb.cxx Diff File
mod - src/OpenGl/OpenGl_Workspace.cxx Diff File

Issue History

Date Modified Username Field Change
2015-11-20 12:43 isk New Issue
2015-11-20 12:43 isk Assigned To => kgv
2015-11-20 12:54 kgv Summary Visualization, TKOpenGl - avoid compiler warnings on android. => Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
2015-11-20 12:54 kgv Description Updated
2015-11-20 12:54 kgv Steps to Reproduce Updated
2015-11-20 12:54 kgv Additional Information Updated
2015-11-24 15:31 git Note Added: 0048525
2015-11-24 15:35 isk Note Added: 0048526
2015-11-24 15:35 isk Status new => resolved
2015-11-25 09:04 isk Assigned To kgv => isk
2015-11-25 09:04 isk Status resolved => assigned
2015-12-04 10:45 git Note Added: 0048743
2015-12-04 10:46 isk Assigned To isk => kgv
2015-12-04 10:46 isk Status assigned => resolved
2015-12-08 14:01 git Note Added: 0048840
2015-12-08 14:01 isk Note Added: 0048841
2015-12-10 15:33 git Note Added: 0048960
2015-12-10 15:40 git Note Added: 0048962
2015-12-10 15:42 kgv Note Added: 0048964
2015-12-10 15:42 kgv Assigned To kgv => bugmaster
2015-12-10 15:42 kgv Status resolved => reviewed
2015-12-11 12:31 apv Assigned To bugmaster => apv
2015-12-11 14:49 git Note Added: 0049036
2015-12-11 14:49 apv Note Added: 0049037
2015-12-15 10:58 git Note Added: 0049128
2015-12-15 10:59 git Note Added: 0049129
2015-12-15 11:00 kgv Note Added: 0049130
2015-12-15 11:04 apv Assigned To apv => bugmaster
2015-12-15 18:19 git Note Added: 0049179
2015-12-16 21:20 bugmaster Note Added: 0049221
2015-12-16 21:20 bugmaster Status reviewed => tested
2015-12-18 15:25 abv Changeset attached => occt master 20aeeb7b
2015-12-18 15:25 abv Assigned To bugmaster => abv
2015-12-18 15:25 abv Status tested => verified
2015-12-18 15:25 abv Resolution open => fixed
2016-04-17 13:54 git Note Added: 0052990
2016-04-17 13:54 git Note Added: 0052991
2016-04-17 13:54 git Note Added: 0052992
2016-04-20 15:42 aiv Fixed in Version => 7.0.0
2016-04-20 15:50 aiv Status verified => closed