View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0023687 | Community | OCCT:Data Exchange | public | 2013-01-04 14:52 | 2013-04-29 15:21 |
Reporter | Pawel | Assigned To | Pawel | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Platform | A | OS | L | ||
Product Version | 6.5.4 | ||||
Target Version | 6.6.0 | Fixed in Version | 6.6.0 | ||
Summary | 0023687: Two opposite conditions. The second condition is always false in ifselect_shareout.cxx | ||||
Description | In lines 44, 45 if (!modifier.IsNull()) { if (modifier.IsNull()) return Standard_False; the second check is always 'false'. The second if-clause can either be deleted or checked as first but I'm not sure about the logic (should the method return 'Standard_False' if there is no modifier?). | ||||
Tags | No tags attached. | ||||
Test case number | Not needed | ||||
|
I suggest line 45 should be removed: this is safe as it will keep existing behavior, while recovering the complete logic of this tool seems to be not worth the candle |
|
Branch CR23687 pushed. Please review. |
|
No remarks, please test |
|
Dear BugMaster, Branch CR23687 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-01-04 14:52 | Pawel | New Issue | |
2013-01-04 14:52 | Pawel | Assigned To | => bugmaster |
2013-01-04 17:24 |
|
Note Added: 0022902 | |
2013-01-04 18:20 | Pawel | Note Added: 0022904 | |
2013-01-04 18:20 | Pawel | Status | new => resolved |
2013-01-04 18:26 |
|
Note Added: 0022906 | |
2013-01-04 18:26 |
|
Status | resolved => reviewed |
2013-01-11 18:30 |
|
Note Added: 0022949 | |
2013-01-11 18:30 |
|
Test case number | => Not needed |
2013-01-11 18:30 |
|
Status | reviewed => tested |
2013-01-21 18:29 | Pawel | Changeset attached | => occt master e1db25a9 |
2013-01-21 18:29 | Pawel | Assigned To | bugmaster => Pawel |
2013-01-21 18:29 | Pawel | Status | tested => verified |
2013-01-21 18:29 | Pawel | Resolution | open => fixed |
2013-04-23 13:36 |
|
Status | verified => closed |
2013-04-29 15:21 |
|
Fixed in Version | => 6.6.0 |