View Issue Details

IDProjectCategoryView StatusLast Update
0033665CommunityOCCT:Data Exchangepublic2024-10-01 13:45
Reporterlin789 Assigned Tobugmaster  
PrioritynormalSeveritycrash 
Status verifiedResolutionfixed 
Product Version7.8.0 
Target Version7.9.0Fixed in Version7.9.0 
Summary0033665: Data Exchange, Step Import - TransferRoots crashes for invalid STEP files
DescriptionHello everyone,

I would like to report an issue that I encountered. I am new here, so if I am doing this the wrong way, please let me know :)
I have played around with an example model and have attached the following:
box_invalid1.step: Here, I removed the entity #/18
box_invalid2.step: Here, I removed the first parameter of entity #/11.
Both files lead to a crash (segmentation fault) when calling TransferRoots, see below to reproduce.
Can you please have a look at this issue?
Steps To ReproduceSTEPControl_Reader reader;
IFSelect_ReturnStatus stat = reader.ReadFile('box_invalid1.step');
reader.TransferRoots();
TagsNo tags attached.
Test case numberbugs step bug33665

Attached Files

  • box_invalid1.step (16,042 bytes)
  • box_invalid2.step (16,069 bytes)

Activities

lin789

2024-04-04 18:37

reporter  

box_invalid1.step (16,042 bytes)
box_invalid2.step (16,069 bytes)

lin789

2024-04-04 18:55

reporter   ~0115590

I can't edit the issue description, so I'll add it here:
When I wrote number(#) 18 as the entity number, it was automatically converted to a ticket number.
The lines above should be
box_invalid1.step: Here, I removed the entity number 18
box_invalid2.step: Here, I removed the first parameter of entity number 11

git

2024-04-11 18:00

administrator   ~0115686

Branch CR33665 has been created by ichesnokova.

SHA-1: d22aa2cac5f1f008f84dcfe7d073b6c730a16561


Detailed log of new commits:

Author: ichesnok
Date: Thu Apr 11 14:12:41 2024 +0100

    0033665: Data Exchange, Step Import - TransferRoots crashes for invalid STEP files
    
    IsNull() check added for StepShape_FaceBound.

ichesnokova

2024-04-12 16:15

developer   ~0115696

Dear dpasukhi,
please review branch CR33665.

dpasukhi

2024-05-31 16:07

administrator   ~0115924

Please add test case(s)

git

2024-07-15 23:21

administrator   ~0116182

Branch CR33665 has been updated forcibly by ichesnokova.

SHA-1: f62648121085e328b13f858fcecffecc39f4ac78

dpasukhi

2024-07-16 10:45

administrator   ~0116186

Dear @ichesnokova please update git commit message with details about what file are you working on.
It should include that the fix for case when "..." entity is missed in some file (file corrupted) and other.

Because the first mind for user is - why this changes only checking for null and nothing more...

git

2024-07-19 12:31

administrator   ~0116268

Branch CR33665 has been updated forcibly by ichesnokova.

SHA-1: fc7b18fc358f8670ff573075dc05d458aa96d89a

git

2024-07-19 13:36

administrator   ~0116269

Branch CR33665 has been updated forcibly by ichesnokova.

SHA-1: c73d05c0488804d05716f8d3e48ef5a9e33776cc

git

2024-07-22 09:58

administrator   ~0116277

Branch CR33665 has been updated forcibly by ichesnokova.

SHA-1: 09061ca65a9724dc111392c0decd38aecc3855b2

git

2024-09-20 13:56

administrator   ~0116719

Branch CR33665_1 has been created by dpasukhi.

SHA-1: fcf50c688ad2ecd15aba17126d4e072e5dd2467b


Detailed log of new commits:

Author: dkulikov
Date: Thu Sep 19 16:50:01 2024 +0000

    hotfix

Author: dkulikov
Date: Thu Sep 19 15:14:58 2024 +0000

    0033665: Data Exchange, Step Import - TransferRoots crashes for invalid STEP files
    
    Fixed exception in RWStepShape_RWEdgeCurve::Check() thrown when trying
    to access step entity in Interface_EntityIterator with zero entities.
    Fixed a crash in StepToTopoDS_TranslateFace::Init() caused by
    dereferencing nullptr.
    RWStepShape_RWEdgeCurve and RWStepShape_RWEdgeCurve are refactored.
    Test bug33665 is added to check the fixed behaviour.

dpasukhi

2024-09-20 17:24

administrator   ~0116722

PR: https://github.com/Open-Cascade-SAS/OCCT/pull/70

git

2024-09-22 21:00

administrator   ~0116725

Branch CR33665_1 has been deleted by dpasukhi.

SHA-1: fcf50c688ad2ecd15aba17126d4e072e5dd2467b

git

2024-10-01 13:45

administrator   ~0116779

Branch CR33665 has been deleted by vglukhik.

SHA-1: 09061ca65a9724dc111392c0decd38aecc3855b2

Issue History

Date Modified Username Field Change
2024-04-04 18:37 lin789 New Issue
2024-04-04 18:37 lin789 Assigned To => ika
2024-04-04 18:37 lin789 File Added: box_invalid1.step
2024-04-04 18:37 lin789 File Added: box_invalid2.step
2024-04-04 18:55 lin789 Note Added: 0115590
2024-04-04 19:10 dpasukhi Product Version 7.7.0 => 7.8.0
2024-04-04 20:19 dpasukhi Summary TransferRoots crashes for invalid STEP files => Data Exchange, Step Import - TransferRoots crashes for invalid STEP files
2024-04-04 20:19 dpasukhi Assigned To ika => ichesnokova
2024-04-04 20:19 dpasukhi Description Updated
2024-04-04 20:20 dpasukhi Description Updated
2024-04-04 20:20 dpasukhi Assigned To ichesnokova => dpasukhi
2024-04-04 20:20 dpasukhi Assigned To dpasukhi => ichesnokova
2024-04-04 20:20 dpasukhi Target Version => 7.9.0
2024-04-11 18:00 git Note Added: 0115686
2024-04-12 16:15 ichesnokova Assigned To ichesnokova => dpasukhi
2024-04-12 16:15 ichesnokova Status new => resolved
2024-04-12 16:15 ichesnokova Note Added: 0115696
2024-05-31 16:07 dpasukhi Assigned To dpasukhi => ichesnokova
2024-05-31 16:07 dpasukhi Status resolved => assigned
2024-05-31 16:07 dpasukhi Note Added: 0115924
2024-07-15 23:21 git Note Added: 0116182
2024-07-16 10:45 dpasukhi Note Added: 0116186
2024-07-19 12:31 git Note Added: 0116268
2024-07-19 13:36 git Note Added: 0116269
2024-07-22 09:58 git Note Added: 0116277
2024-09-16 10:52 dpasukhi Assigned To ichesnokova => dkulikov
2024-09-20 13:56 git Note Added: 0116719
2024-09-20 17:24 dpasukhi Assigned To dkulikov => ika
2024-09-20 17:24 dpasukhi Status assigned => resolved
2024-09-20 17:24 dpasukhi Note Added: 0116722
2024-09-20 17:24 dpasukhi Assigned To ika => bugmaster
2024-09-20 17:24 dpasukhi Status resolved => reviewed
2024-09-22 20:06 dpasukhi Status reviewed => verified
2024-09-22 20:06 dpasukhi Resolution open => fixed
2024-09-22 20:06 dpasukhi Fixed in Version => 7.9.0
2024-09-22 20:06 dpasukhi Test case number => bugs step bug33665
2024-09-22 21:00 git Note Added: 0116725
2024-10-01 13:45 git Note Added: 0116779