View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0033564 | Open CASCADE | OCCT:Data Exchange | public | 2024-01-02 16:57 | 2024-01-22 02:07 |
| Reporter | dpasukhi | Assigned To | dpasukhi | ||
| Priority | normal | Severity | minor | ||
| Status | verified | Resolution | fixed | ||
| Target Version | 7.8.1 | ||||
| Summary | 0033564: Data Exchange, STEP - Making default unit parameter | ||||
| Description | Currently STEP entities makers use Length paramerter but it has no default version. Need to use default version as progress indicator. | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR33564 has been created by dpasukhi. SHA-1: 78541f86afd69141446c52c3eccfd83970f0e980 Detailed log of new commits: Author: dpasukhi Date: Thu Jan 4 12:29:53 2024 +0000 0033564: Data Exchange, STEP - Making default unit parameter Updated signature for step makers with units to have default unit as a mm (no scaling) |
|
|
Dear ika, please review OCCT:CR33564 PROD: NO The main issue is using default unit parameter for STEP entity makers. It helps to create a STEP entity in external projects with default units (MM, no scaling). All tests are OK, see: http://jenkins-test-10.nnov.opencascade.com/view/CR33564-master-dpasukhi/view/COMPARE/ |
|
|
No remarks. Dear bugmaster, please integrate OCCT CR33564 |
|
|
Combination - OCCT branch : IR-2024-01-12 master SHA - cb290cc932e533628a2cdfcfbbbfe1f0883821b5 d2ef868da4165400c82322bd7f11b652decce47a Products branch : IR-2024-01-12 SHA - 26d4be518afdc90351afcaba4723111377b4827d was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Ubuntu2004-64: OCCT Total CPU difference: 18615.09999999999 / 18183.169999999875 [+2.38%] Products Total CPU difference: 11794.089999999893 / 12064.139999999925 [-2.24%] Windows-64-VC142: OCCT Total CPU difference: 21170.703125 / 20937.65625 [+1.11%] Products Total CPU difference: 12543.890625 / 12661.46875 [-0.93%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR33564 has been deleted by vglukhik. SHA-1: 78541f86afd69141446c52c3eccfd83970f0e980 |
|
occt: master cdc6566c 2024-01-04 12:29:53 Committer: vglukhik Details Diff |
0033564: Data Exchange, STEP - Making default unit parameter Updated signature for step makers with units to have default unit as a mm (no scaling) |
Affected Issues 0033564 |
|
| mod - src/GeomToStep/GeomToStep_MakeAxis1Placement.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeAxis2Placement2d.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeAxis2Placement3d.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBoundedCurve.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBoundedSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBSplineCurveWithKnots.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBSplineCurveWithKnotsAndRationalBSplineCurve.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBSplineSurfaceWithKnots.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeBSplineSurfaceWithKnotsAndRationalBSplineSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeCircle.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeConic.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeConicalSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeCurve.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeCylindricalSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeElementarySurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeEllipse.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeHyperbola.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeLine.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeParabola.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakePlane.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakePolyline.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeRectangularTrimmedSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeSphericalSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeSurfaceOfLinearExtrusion.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeSurfaceOfRevolution.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeSweptSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeToroidalSurface.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_MakeVector.hxx | Diff File | ||
| mod - src/GeomToStep/GeomToStep_Root.hxx | Diff File | ||
| mod - src/STEPCAFControl/STEPCAFControl_Reader.hxx | Diff File | ||
| mod - src/STEPCAFControl/STEPCAFControl_Writer.hxx | Diff File | ||
| mod - src/STEPConstruct/STEPConstruct_UnitContext.hxx | Diff File | ||
| mod - src/STEPConstruct/STEPConstruct_ValidationProps.hxx | Diff File | ||
| mod - src/STEPControl/STEPControl_ActorRead.cxx | Diff File | ||
| mod - src/STEPControl/STEPControl_ActorRead.hxx | Diff File | ||
| mod - src/STEPControl/STEPControl_ActorWrite.hxx | Diff File | ||
| mod - src/StepToGeom/StepToGeom.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_Builder.cxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_Builder.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_MakeTransformed.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateCompositeCurve.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateCurveBoundedSurface.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateEdge.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateEdgeLoop.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateFace.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslatePolyLoop.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateShell.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateSolid.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateVertex.hxx | Diff File | ||
| mod - src/StepToTopoDS/StepToTopoDS_TranslateVertexLoop.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_Builder.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeBrepWithVoids.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeFacetedBrep.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeFacetedBrepAndBrepWithVoids.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeGeometricCurveSet.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeManifoldSolidBrep.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeShellBasedSurfaceModel.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeStepEdge.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeStepFace.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeStepVertex.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_MakeStepWire.hxx | Diff File | ||
| mod - src/TopoDSToStep/TopoDSToStep_WireframeBuilder.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-02 16:57 | dpasukhi | New Issue | |
| 2024-01-02 16:57 | dpasukhi | Assigned To | => dpasukhi |
| 2024-01-02 16:59 | dpasukhi | Relationship added | child of 0033351 |
| 2024-01-04 15:30 | git | Note Added: 0114855 | |
| 2024-01-09 18:29 | dpasukhi | Assigned To | dpasukhi => ika |
| 2024-01-09 18:29 | dpasukhi | Status | new => resolved |
| 2024-01-09 18:29 | dpasukhi | Steps to Reproduce Updated | |
| 2024-01-09 18:29 | dpasukhi | Note Added: 0114886 | |
| 2024-01-10 02:54 | ika | Assigned To | ika => bugmaster |
| 2024-01-10 02:54 | ika | Status | resolved => reviewed |
| 2024-01-10 02:54 | ika | Note Added: 0114888 | |
| 2024-01-17 15:31 | vglukhik | Note Added: 0114917 | |
| 2024-01-17 15:32 | vglukhik | Changeset attached | => occt master cdc6566c |
| 2024-01-17 15:32 | dpasukhi | Assigned To | bugmaster => dpasukhi |
| 2024-01-17 15:32 | dpasukhi | Status | reviewed => verified |
| 2024-01-17 15:32 | dpasukhi | Resolution | open => fixed |
| 2024-01-22 02:07 | git | Note Added: 0114945 |
