View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0033514 | Open CASCADE | OCCT:Visualization | public | 2023-10-24 14:52 | 2024-07-17 12:56 |
Reporter | Assigned To | bugmaster | |||
Priority | normal | Severity | minor | ||
Status | verified | Resolution | fixed | ||
Platform | Windows | OS | VC++ 2022 | ||
Product Version | 7.7.0 | ||||
Target Version | 7.9.0 | Fixed in Version | 7.9.0 | ||
Summary | 0033514: Visualization - Scaled view twists zoom persistence objects | ||||
Description | Objects like manipulators with zoom persistence need to maintain its visual aspects for proper usage in a scene. The application of a visual scale is twisting its effects (see figure zoom_scaled.png). A similar effect was observed in issue https://tracker.dev.opencascade.org/view.php?id=27832. The proposal is to adjust the zoom persistent object scale according to the view's axial scale. | ||||
Steps To Reproduce | pload ALL vinit box b 10 10 10 vdisplay b vfit vsetdispmode 1 vmanipulator vm -attach b vscale 1 3 10 vviewparams -scale 6.28866 -proj 0.57735 -0.57735 0.57735 -up -0.408248 0.408248 0.816497 -at 0 10 30 | ||||
Tags | No tags attached. | ||||
Test case number | v3d/manipulator/bug33514 & v3d/trihedron/bug27832 | ||||
2023-10-24 14:52 developer |
zoom_scaled.png (75,368 bytes) |
|
Branch CR33514 has been created by drochalo. SHA-1: 8e37a5f85c7fbca4045c374ba6470dafbee79dfb Detailed log of new commits: Author: drochalo Date: Tue Oct 24 15:50:27 2023 +0100 0033514: Visualization - Scaled view twists zoom persistence objects added test Author: drochalo Date: Tue Oct 24 14:44:14 2023 +0100 0033514: Visualization - Scaled view twists zoom persistence objects Adjusted object scale of zoom persistent objects. Now takes view's axial scale into account. |
|
Dear Marina, please review changes made to the behaviour of zoom persistence objects. The tests in jenkins do not produce errors connected to these particular changes (http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-drochalo/view/COMPARE/). |
|
This is wrong The scale must be applied to all objects with Graphic3d_TMF_ZoomPers except the manipulator. //Adjust the camera axial scale for zoom persistent objects gp_XYZ anAxialScale = theCamera->AxialScale(); Standard_Real anAxialX = anAxialScale.X(); Standard_Real anAxialY = anAxialScale.Y(); Standard_Real anAxialZ = anAxialScale.Z(); if (anAxialX > 0 && anAxialY > 0 && anAxialZ > 0) { Graphic3d_TransformUtils::Scale(aWorldView, 1.0 / anAxialX, 1.0 / anAxialY, 1.0 / anAxialZ); } |
|
Branch CR33514 has been updated by drochalo. SHA-1: 880af45ddf6bf0990abe40be8d18d21b5d374d57 Detailed log of new commits: Author: drochalo Date: Mon Dec 18 16:30:32 2023 +0000 0033514: Visualization - Scaled view twists zoom persistence objects Added flag to transform persistence to handle axial scaling. Modified manipulator's zoom transform persistence to fit in axial scaling events. Added tests for cases 27832 and 33514. Author: drochalo Date: Mon Dec 18 10:32:36 2023 +0000 Merge branch 'master' of git.dev.opencascade.org:occt into CR33514 Author: drochalo Date: Mon Nov 20 13:09:03 2023 +0000 Merge branch 'master' of git.dev.opencascade.org:occt into CR33514 |
|
Branch CR33514 has been updated forcibly by drochalo. SHA-1: 97d8382305add039ad674ceb369f991cd12a3541 |
|
Branch CR33514 has been updated forcibly by drochalo. SHA-1: a9defae33c4391419a2070912833f1cd5e84978b |
|
Dear Marina, please review. Note that some of the changes made include fix to bug reported on issue 27832. Tests on Jenkins present minor issues but only on tests not connected with the changes: http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-drochalo/view/COMPARE/ |
|
Please add into Graphic3d_TransformPers::Applyif ((myMode & Graphic3d_TMF_AxialScalePers) != 0) { //... } |
|
Branch CR33514 has been updated by drochalo. SHA-1: 566f7690a841aa551215de3af15cbb257b2f6625 Detailed log of new commits: Author: drochalo Date: Fri Jan 5 16:21:36 2024 +0000 0033514: Visualization - Scaled view twists zoom persistence objects Logic change on Graphic3d_TransformPers::Apply for Graphic3d_TMF_AxialScalePers. |
|
Dear Marina, please review once again. New tests in Jenkins only present minor issues but not connected to the changes: http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-drochalo/view/COMPARE/ |
|
Please set Graphic3d_TMF_AxialScalePers if myIsZoomPersistentMode is false if (myIsZoomPersistentMode) { if (TransformPersistence().IsNull() || TransformPersistence()->Mode() != Graphic3d_TMF_ZoomPers || !TransformPersistence()->AnchorPoint().IsEqual (myPosition.Location(), 0.0)) { setTransformPersistence (new Graphic3d_TransformPers (Graphic3d_TMF_ZoomPers, myPosition.Location())); } } Please split this line It should be shorter than 120 symbols Standard_OutOfRange_Raise_if (theAxialScale.X() <= 0.0 || theAxialScale.Y() <= 0.0 || theAxialScale.Z() <= 0.0, "Graphic3d_Camera::SetAxialScale, bad coefficient"); Please update description, not clear what 'locally' means here Graphic3d_TMF_AxialZoomPers = Graphic3d_TMF_ZoomPers | Graphic3d_TMF_AxialScalePers //!< Object doesn't resize locally or with axial scale. Please provide more clear description //! Graphic3d_TMF_AxialPers and Graphic3d_TMF_AxialZoomPers defines persistence in the axial scale. Please split this line It should be shorter than 120 symbols Graphic3d_TransformUtils::Scale (aWorldView, 1.0 / theCamera->AxialScale().X(), 1.0 / theCamera->AxialScale().Y(), 1.0 / theCamera->AxialScale().Z()); Please remove extra comments // Adjust the camera axial scale to preserve trihedron shape. // Adjust the camera axial scale for axial scale persistent objects. Please add empty line to the end of test: bug33514 Please use lowercase for description enum values without point in the end of sentence. Please remove extra spaces. image.png (48,443 bytes) image-2.png (29,347 bytes) |
|
Branch CR33514 has been updated by drochalo. SHA-1: ad49fa8b7c99ff01502a7dd854a0f7771a4e00cc Detailed log of new commits: Author: drochalo Date: Tue Jan 9 16:45:40 2024 +0000 0033514: Visualization - Scaled view twists zoom persistence objects Logic fixes in AIS_Manipulator to integrate axial scale in both zoomable and unzoomable states. Code cleanup. Modified test. |
|
Dear Marina, I made the requested changes. New tests on Jenkins show no major issues (http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-drochalo/view/COMPARE/). Please review. |
|
Please undo the underlined change. Please add (Graphic3d_TMF_AxialScalePers & myMode) == 0to the Graphic3d_TransformPers::IsZoomOrRotate method or create separate method for it. Should we use Redisplay() here? ViewerTest::GetAISContext()->Remove (aManipulator, Standard_False); ViewerTest::GetAISContext()->Display (aManipulator, Standard_False); ViewerTest::GetAISContext()->Redisplay (aManipulator, Standard_False); image-3.png (294,086 bytes) |
|
Branch CR33514 has been updated by drochalo. SHA-1: 7e78e304cf172b6704fe7388a3cb346a26d81f4f Detailed log of new commits: Author: drochalo Date: Fri Apr 5 11:12:16 2024 +0100 0033514: Visualization - Scaled view twists zoom persistence objects Code tweaks. |
|
Branch CR33514 has been updated forcibly by drochalo. SHA-1: fca945d7a6855c5f3156233544da85a5d450ac75 |
|
Branch CR33514 has been updated by drochalo. SHA-1: 67e265580c9f5e921716df8e94c61aa9c821838d Detailed log of new commits: Author: drochalo Date: Mon Apr 8 17:00:40 2024 +0100 0033514: Visualization - Scaled view twists zoom persistence objects Code tweaks. |
|
Dear Marina, the requested changes were made. The branch was also updated to include previous changes made to Graphic3d_TransformPers. New tests on Jenkins show minor issues but that are not connected to the changes. http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-drochalo/view/COMPARE/ Please review. |
|
Branch CR33514_1 has been created by mzernova. SHA-1: de3d892051ad6c6915fe02fefe4c8e216336ff75 Detailed log of new commits: Author: drochalo Date: Tue Oct 24 14:44:14 2023 +0100 0033514: Visualization - Scaled view twists zoom persistence objects Added flag to transform persistence to handle axial scaling. Modified manipulator's zoom transform persistence to fit in axial scaling events. Added tests for cases 27832 and 33514. Logic change on Graphic3d_TransformPers::Apply for Graphic3d_TMF_AxialScalePers. Logic fixes in AIS_Manipulator to integrate axial scale in both zoomable and unzoomable states. |
|
Dear bugmaster, please integrate Test reports: http://jenkins-test-10.nnov.opencascade.com/view/CR33514-master-mzernova/view/ALL/ For integration: OCCT: CR33514_1 PROD: none |
|
Branch CR33514 has been deleted by vglukhik. SHA-1: 67e265580c9f5e921716df8e94c61aa9c821838d |
|
Branch CR33514_1 has been deleted by vglukhik. SHA-1: de3d892051ad6c6915fe02fefe4c8e216336ff75 |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-10-24 14:52 |
|
New Issue | |
2023-10-24 14:52 |
|
Assigned To | => drochalo |
2023-10-24 14:52 |
|
File Added: zoom_scaled.png | |
2023-10-24 15:13 |
|
Steps to Reproduce Updated | |
2023-10-24 17:51 | git | Note Added: 0114416 | |
2023-10-25 18:38 |
|
Status | new => feedback |
2023-10-25 18:38 |
|
Note Added: 0114430 | |
2023-10-25 18:38 |
|
Assigned To | drochalo => mzernova |
2023-10-27 16:55 |
|
Status | feedback => resolved |
2023-11-17 02:43 | mzernova | Note Added: 0114607 | |
2023-11-17 02:43 | mzernova | Assigned To | mzernova => drochalo |
2023-11-17 02:43 | mzernova | Status | resolved => assigned |
2023-12-18 19:32 | git | Note Added: 0114815 | |
2023-12-19 18:09 | git | Note Added: 0114824 | |
2023-12-19 19:19 | git | Note Added: 0114826 | |
2023-12-20 13:08 |
|
Note Added: 0114830 | |
2023-12-20 13:08 |
|
Assigned To | drochalo => mzernova |
2023-12-20 13:08 |
|
Status | assigned => resolved |
2024-01-05 17:55 | mzernova | Note Added: 0114865 | |
2024-01-05 17:55 | mzernova | Assigned To | mzernova => drochalo |
2024-01-05 17:55 | mzernova | Status | resolved => assigned |
2024-01-05 19:22 | git | Note Added: 0114868 | |
2024-01-09 12:10 |
|
Note Added: 0114880 | |
2024-01-09 12:10 |
|
Assigned To | drochalo => mzernova |
2024-01-09 12:10 |
|
Status | assigned => resolved |
2024-01-09 18:21 | mzernova | Note Added: 0114885 | |
2024-01-09 18:21 | mzernova | File Added: image.png | |
2024-01-09 18:21 | mzernova | File Added: image-2.png | |
2024-01-09 18:21 | mzernova | Assigned To | mzernova => drochalo |
2024-01-09 18:21 | mzernova | Status | resolved => assigned |
2024-01-22 20:47 | git | Note Added: 0114955 | |
2024-01-23 12:43 |
|
Note Added: 0114956 | |
2024-01-23 12:45 |
|
Assigned To | drochalo => mzernova |
2024-01-23 12:45 |
|
Status | assigned => resolved |
2024-01-23 12:45 |
|
Test case number | => v3d/manipulator/bug33514 & v3d/trihedron/bug27832 |
2024-03-25 12:53 | dpasukhi | Target Version | 7.8.0 => 7.9.0 |
2024-04-02 13:29 | mzernova | Note Added: 0115538 | |
2024-04-02 13:29 | mzernova | File Added: image-3.png | |
2024-04-02 13:29 | mzernova | Assigned To | mzernova => drochalo |
2024-04-02 13:29 | mzernova | Status | resolved => assigned |
2024-04-05 19:37 | git | Note Added: 0115619 | |
2024-04-08 13:05 | git | Note Added: 0115634 | |
2024-04-09 18:48 | git | Note Added: 0115667 | |
2024-04-10 12:38 |
|
Note Added: 0115671 | |
2024-04-10 12:38 |
|
Assigned To | drochalo => mzernova |
2024-04-10 12:38 |
|
Status | assigned => resolved |
2024-04-16 01:45 | git | Note Added: 0115714 | |
2024-04-16 01:52 | mzernova | Assigned To | mzernova => bugmaster |
2024-04-16 01:52 | mzernova | Status | resolved => reviewed |
2024-04-16 01:52 | mzernova | Note Added: 0115715 | |
2024-07-05 17:35 | dpasukhi | Status | reviewed => verified |
2024-07-05 17:35 | dpasukhi | Resolution | open => fixed |
2024-07-05 17:35 | dpasukhi | Fixed in Version | => 7.9.0 |
2024-07-17 12:56 | git | Note Added: 0116207 | |
2024-07-17 12:56 | git | Note Added: 0116208 |