View Issue Details

IDProjectCategoryView StatusLast Update
0033487CommunityOCCT:Data Exchangepublic2024-09-30 20:50
Reporterpavelmoje Assigned Tobugmaster  
PrioritynormalSeveritycrash 
Status verifiedResolutionfixed 
PlatformWindowsOSVC++ 2022 
Product Version7.7.1 
Summary0033487: Data Exchange, Step Import - Unresolved reference crashes
DescriptionCall STEPCAFControl_Reader->Transfer() caused exception Access Violation when file has Unresolved Reference, see occt_bug3.PNG.
Other attached files occt_bug[1, 2, 4].PNG shows other exception details.
https://github.com/Open-Cascade-SAS/OCCT/pull/76
Steps To ReproduceRead STEP file with Unresolved Reference (occt_bug3.PNG) and use STEPCAFControl_Reader.
I've to ask my college if I can provide this file.
Additional information
and documentation updates
When I've set STEPCAFControl_Reader.SetColorMode(false) file is normally read.
TagsNo tags attached.
Test case numbertests/bugs/step/bug33487

Attached Files

  • occt_bug5.PNG (16,061 bytes)
  • occt_bug4.PNG (39,358 bytes)
  • occt_bug3.PNG (17,108 bytes)
  • occt_bug2.PNG (92,422 bytes)
  • occt_bug1.PNG (39,039 bytes)
  • loaded_model_after_fix.jpg (133,409 bytes)

Activities

dpasukhi

2023-09-22 14:24

administrator   ~0114252

Dear @pavelmoje
please reattache a files. There was some problem with attachemtns

pavelmoje

2023-09-22 14:41

reporter   ~0114254

Bug is fixed and PR is created https://github.com/Open-Cascade-SAS/OCCT/pull/13.

pavelmoje

2023-09-22 14:42

reporter   ~0114255

Missing attached files.
occt_bug5.PNG (16,061 bytes)
occt_bug4.PNG (39,358 bytes)
occt_bug3.PNG (17,108 bytes)
occt_bug2.PNG (92,422 bytes)
occt_bug1.PNG (39,039 bytes)

pavelmoje

2023-09-22 14:54

reporter   ~0114256

Attached occt_bug5.PNG is from CAD Assistant.

And see loaded model with applied PR https://github.com/Open-Cascade-SAS/OCCT/pull/13.
loaded_model_after_fix.jpg (133,409 bytes)

dpasukhi

2024-04-15 11:31

administrator   ~0115704

Fix:
https://github.com/Open-Cascade-SAS/OCCT/pull/13

dpasukhi

2024-04-15 11:33

administrator   ~0115705

Needs to prepare correct fix to check empty name

git

2024-04-17 10:31

administrator   ~0115728

Branch CR33487 has been created by ichesnokova.

SHA-1: 1b836c11404072e2a004526950be3a8f0688d569


Detailed log of new commits:

Author: ichesnok
Date: Tue Apr 16 16:38:20 2024 +0100

    0033487: Data Exchange, Step Import - Unresolved reference crashes
    
    IsNull() check added for Handle(StepVisual_FillAreaStyleColour).

dpasukhi

2024-07-16 10:43

administrator   ~0116185

@ichesnokova please share details about why this entity is null inside file. It is not exist or we have no read some data?

Please avoid to write git commit message with trivial description. Try to describe a scenario that leads to the issue and issue itself.

pavelmoje

2024-08-05 13:57

reporter   ~0116372

I would like to share this model with unresolved references, but I don't have a permission for it.
I can only offer to test it after some provided fix.

git

2024-09-23 19:01

administrator   ~0116755

Branch CR33487_1 has been created by dpasukhi.

SHA-1: 2aa164a121ed258d83913c94d884a70a39c4e902


Detailed log of new commits:

Author: dkulikov
Date: Mon Sep 23 13:59:28 2024 +0000

    0033487: Data Exchange, Step Import - Unresolved reference crashes
    
    Fixed crash in STEPConstruct_Styles::GetColors() due to nullptr
    dereferencing when source step file has missing
    FILL_AREA_STYLE_COLOUR entities.
    
    STEPConstruct_Styles::GetColors () is refactored.
    
    Test bug33487 ia added to check that crash doesn't occur.

git

2024-09-23 19:30

administrator   ~0116756

Branch CR33487_1 has been updated by dpasukhi.

SHA-1: 15bd298c3a4c39f6970fd145dcec8ff2495cecda


Detailed log of new commits:

Author: dkulikov
Date: Mon Sep 23 16:29:40 2024 +0000

    code style fix

git

2024-09-23 21:22

administrator   ~0116759

Branch CR33487_1 has been updated by dpasukhi.

SHA-1: 7b6f1c7592bb477c01f35af54a4de603462ef0c0


Detailed log of new commits:

Author: dkulikov
Date: Mon Sep 23 18:20:05 2024 +0000

    small fix

git

2024-09-24 16:50

administrator   ~0116761

Branch CR33487_1 has been updated by dpasukhi.

SHA-1: 2d30324c2887885f1f2fac9df5937eb246fe44a2


Detailed log of new commits:

Author: dkulikov
Date: Tue Sep 24 09:49:19 2024 +0000

    small fix

pavelmoje

2024-09-30 17:13

reporter   ~0116777

I can confirm that problematic STP model is loading correctly without crash. Thank you for fixing.

dpasukhi

2024-09-30 20:50

administrator   ~0116778

PR:
https://github.com/Open-Cascade-SAS/OCCT/pull/76

Issue History

Date Modified Username Field Change
2023-09-22 14:22 pavelmoje New Issue
2023-09-22 14:22 pavelmoje Assigned To => pavelmoje
2023-09-22 14:24 dpasukhi Note Added: 0114252
2023-09-22 14:41 pavelmoje Note Added: 0114254
2023-09-22 14:42 pavelmoje Note Added: 0114255
2023-09-22 14:42 pavelmoje File Added: occt_bug5.PNG
2023-09-22 14:42 pavelmoje File Added: occt_bug4.PNG
2023-09-22 14:42 pavelmoje File Added: occt_bug3.PNG
2023-09-22 14:42 pavelmoje File Added: occt_bug2.PNG
2023-09-22 14:42 pavelmoje File Added: occt_bug1.PNG
2023-09-22 14:54 pavelmoje Note Added: 0114256
2023-09-22 14:54 pavelmoje File Added: loaded_model_after_fix.jpg
2024-04-15 11:31 dpasukhi Note Added: 0115704
2024-04-15 11:33 dpasukhi Note Added: 0115705
2024-04-15 11:34 dpasukhi Assigned To pavelmoje => ichesnokova
2024-04-15 11:34 dpasukhi Severity major => crash
2024-04-15 11:34 dpasukhi Summary Read specific STEP file with unresolved references caused Exception Access Violation when Transfer() is called => Data Exchange, Step Import - Unresolved reference crashes
2024-04-17 10:31 git Note Added: 0115728
2024-07-16 10:43 dpasukhi Note Added: 0116185
2024-08-05 13:57 pavelmoje Note Added: 0116372
2024-08-05 15:04 dpasukhi Status new => assigned
2024-09-16 10:52 dpasukhi Assigned To ichesnokova => dkulikov
2024-09-23 19:01 git Note Added: 0116755
2024-09-23 19:30 git Note Added: 0116756
2024-09-23 21:22 git Note Added: 0116759
2024-09-24 12:13 dpasukhi Assigned To dkulikov => ika
2024-09-24 12:13 dpasukhi Status assigned => resolved
2024-09-24 12:13 dpasukhi Assigned To ika => bugmaster
2024-09-24 12:13 dpasukhi Status resolved => reviewed
2024-09-24 16:50 git Note Added: 0116761
2024-09-29 22:16 dpasukhi Status reviewed => verified
2024-09-29 22:16 dpasukhi Resolution open => fixed
2024-09-29 22:16 dpasukhi Test case number => tests/bugs/step/bug33487
2024-09-30 17:13 pavelmoje Note Added: 0116777
2024-09-30 20:50 dpasukhi Note Added: 0116778
2024-09-30 20:50 dpasukhi Description Updated