View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0033474Open CASCADEOCCT:Data Exchangepublic2023-09-07 20:342024-01-18 19:33
Reporterdpasukhi Assigned Todpasukhi  
PrioritynormalSeverityminor 
Status verifiedResolutionfixed 
Product Version7.7.1 
Target Version7.8.0 
Summary0033474: Data Exchange - Implement stream reading into RWMesh interface
DescriptionIt's necessary to implement the ability to read from a stream by adding several new methods for readers.
TagsNo tags attached.
Test case number

Relationships

related to 0030844 newdpasukhi Community Data Exchange - Support import from and export to stream for data exchange interface 

Activities

git

2023-09-12 14:19

administrator   ~0114145

Branch CR33474 has been created by ichesnokova.

SHA-1: 5ca1607db2e63e30f770a1b0c160f2311572f3b6


Detailed log of new commits:

Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100

    0033474: Data Exchange - Implement stream reading into RWMesh interface
    
    Stream usage as parameter

git

2023-09-12 18:04

administrator   ~0114146

Branch CR33474 has been updated forcibly by ichesnokova.

SHA-1: d8180da5302e2f729509fdbc1e2566cd08f62c94

git

2023-09-13 00:34

administrator   ~0114151

Branch CR33474 has been updated forcibly by ichesnokova.

SHA-1: 9ccd62b26a88af79439163e4178d4711d192025d

git

2023-09-13 12:59

administrator   ~0114157

Branch CR33474 has been updated forcibly by ichesnokova.

SHA-1: 33f284148ad927012d5f6bc60abf6a868a2f8918

git

2023-09-14 12:27

administrator   ~0114162

Branch CR33474 has been updated forcibly by ichesnokova.

SHA-1: b0f47ac48d4fa0f87aa5909afe613fa9787701cd

ichesnokova

2023-09-15 10:27

developer   ~0114174

Dear dpasukhi,
please review branch CR33474
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33474-master-ichesnok/view/COMPARE/

ika

2023-10-10 13:32

developer   ~0114382

Dear ichesnokova,

I looked throw the patch and have one remark, but it occurs in several files. It is about the "theFile" parameter it is totally unclear, what it means. In some files the description is missing, in some, it confuses ("path of additional file(s)").

As far as I understand, this parameter should mean the folder with additional files, so I would ask you to update the name (theFolder/theCatalog/... not single theFile) of the parameter and add/update the description to make this parameter clear in all the touched files.

After such an update, retest won't be necessary.

git

2023-10-24 14:12

administrator   ~0114413

Branch CR33474_1 has been created by ichesnokova.

SHA-1: 34c9b14d9406c37490130656dd15b6f3425169b6


Detailed log of new commits:

Author: ichesnok
Date: Tue Oct 24 12:08:07 2023 +0100

    remark fixed

Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100

    0033474: Data Exchange - Implement stream reading into RWMesh interface
    
    Stream usage as parameter

ichesnokova

2023-10-24 14:14

developer   ~0114414

Dear ika,
please review branch CR33474_1.

ika

2023-10-24 18:27

developer   ~0114419

Dear ichesnokova,
please add the description to the issue.

I have several style/text remarks. The retesting is not necessary after the applying.

1) RWObj_CafReader.hxx, RWGltf_CafReader.hxx
Add a description of the parameters to the method
2) VrmlAPI_CafReader.hxx
Add spaces into "std::istream& theStream," to align the parameter list.
3) RWObj_Reader.cxx
a)Message::SendFail (TCollection_AsciiString ("Error: file is not found"));
I think such an error message is not valid for the streams, please update them so that the text will be correct for both cases.
b) // determine file location to load associated files
unnecessary comment with a new approach
4) RWGltf_CafReader.cxx
Message::SendFail (TCollection_AsciiString ("The stream can't be open"));
The inverted case of (3a), also please make valid for both file and stream invalidity.
5) RWMesh_CafReader.cxx
Add method separator before Standard_Boolean RWMesh_CafReader::performMesh()
6) RWMesh_CafReader.hxx
+ TCollection_AsciiString myFilePath;
Please add a description to the new pole.

git

2023-11-09 19:28

administrator   ~0114553

Branch CR33474_1 has been updated forcibly by ichesnokova.

SHA-1: 7f81d983c20d64525a5ea950bb915ea8f48d3d72

ichesnokova

2023-11-09 19:31

developer   ~0114555

Dear ika,
please review branch CR33474_1.

git

2023-11-10 15:03

administrator   ~0114558

Branch CR33474_2 has been created by ichesnokova.

SHA-1: 6015f36a27ff850886f4485ee07f70ee5d43b0af


Detailed log of new commits:

Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100

    0033474: Data Exchange - Implement stream reading into RWMesh interface
    
    Several new functions has been added to readers for stream reading.

ika

2023-11-10 15:06

developer   ~0114559

No more remarks.

Dear bugmaster,
please integrate:
OCCT CR33474_2

vglukhik

2023-11-13 18:10

administrator   ~0114573

Dear ichesnokova,
I reject this ticket from IR-2023-11-10, because it has errors during compilation. Please check everything again and make fixes if they are needed.

http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Ubuntu2004-64-opt-compile/3/parsed_console/
http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Windows-64-VC142-opt-compile/3/parsed_console/

ichesnokova

2023-11-22 12:10

developer   ~0114620

Dear ika,
please review branch CR33474 (OCCT Products).

ika

2023-11-22 19:16

developer   ~0114625

Dear ichesnokova,

please update comments about the method parameters (add for theStream, and update for theFile).
Also, please do not forget to rebase the branch to the current master.

git

2023-11-23 15:18

administrator   ~0114631

Branch CR33474_2 has been updated forcibly by ichesnokova.

SHA-1: 3d4b67e2078a811460dd7b1dfe34d66772e99eb3

ichesnokova

2023-11-23 15:20

developer   ~0114632

Dear ika,
please review branch CR33474.

dpasukhi

2023-11-24 17:54

administrator   ~0114665

it will be a part of 7.8
I will include it into Release candidate.

ichesnokova

2023-11-27 15:20

developer   ~0114671

Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33474-master-ichesnok/view/COMPARE/

dpasukhi

2023-11-28 15:58

administrator   ~0114675 

Dear ika,
please review branch CR33474.

Previous problem was a result of the same problem PROD branch was forgotten.
Please write a repo and correct branches name.

dpasukhi

2023-11-28 15:59

administrator   ~0114676

The tests were OK all time. Compilation errors was as a result of missing PROD commit.

dpasukhi

2023-12-12 15:31

administrator   ~0114722

Integrated into CR0-780

git

2023-12-18 04:04

administrator   ~0114773

Branch CR33474 has been deleted by mnt.

SHA-1: b0f47ac48d4fa0f87aa5909afe613fa9787701cd

git

2023-12-18 04:04

administrator   ~0114774

Branch CR33474_1 has been deleted by mnt.

SHA-1: 7f81d983c20d64525a5ea950bb915ea8f48d3d72

git

2023-12-18 04:04

administrator   ~0114775

Branch CR33474_2 has been deleted by mnt.

SHA-1: 3d4b67e2078a811460dd7b1dfe34d66772e99eb3

Related Changesets

occt: master 0435edfe

2023-09-12 10:58:55

ichesnok


Committer: dpasukhi Details Diff		 0033474: Data Exchange - Implement stream reading into RWMesh interface

Stream usage as parameter		 Affected Issues
0033474
mod - src/RWGltf/RWGltf_CafReader.cxx Diff File
mod - src/RWGltf/RWGltf_CafReader.hxx Diff File
mod - src/RWMesh/RWMesh_CafReader.cxx Diff File
mod - src/RWMesh/RWMesh_CafReader.hxx Diff File
mod - src/RWObj/RWObj_CafReader.cxx Diff File
mod - src/RWObj/RWObj_CafReader.hxx Diff File
mod - src/RWObj/RWObj_Reader.cxx Diff File
mod - src/RWObj/RWObj_Reader.hxx Diff File
mod - src/VrmlAPI/VrmlAPI_CafReader.cxx Diff File
mod - src/VrmlAPI/VrmlAPI_CafReader.hxx Diff File
mod - src/VrmlData/VrmlData_Scene.cxx Diff File

occt-products: master 5dec4946

2023-09-14 12:20:15

ichesnok


Committer: dpasukhi Details Diff		 0033474: Data Exchange - Implement stream reading into RWMesh interface

Function parameters corrected		 Affected Issues
0033474
mod - diff Diff File
mod - diff Diff File

Issue History

Date Modified Username Field Change
2023-09-07 20:34 dpasukhi New Issue
2023-09-07 20:34 dpasukhi Assigned To => ichesnokova
2023-09-07 20:34 dpasukhi Product Version => 7.7.1
2023-09-08 17:17 dpasukhi Relationship added related to 0030844
2023-09-12 14:19 git Note Added: 0114145
2023-09-12 14:19 ichesnokova Assigned To ichesnokova => dpasukhi
2023-09-12 14:19 ichesnokova Status new => feedback
2023-09-12 14:44 dpasukhi Assigned To dpasukhi => ichesnokova
2023-09-12 14:44 dpasukhi Status feedback => assigned
2023-09-12 18:04 git Note Added: 0114146
2023-09-13 00:34 git Note Added: 0114151
2023-09-13 12:59 git Note Added: 0114157
2023-09-14 12:27 git Note Added: 0114162
2023-09-15 10:27 ichesnokova Assigned To ichesnokova => dpasukhi
2023-09-15 10:27 ichesnokova Status assigned => resolved
2023-09-15 10:27 ichesnokova Note Added: 0114174
2023-10-09 11:55 dpasukhi Assigned To dpasukhi => ika
2023-10-10 13:32 ika Assigned To ika => ichesnokova
2023-10-10 13:32 ika Status resolved => assigned
2023-10-10 13:32 ika Note Added: 0114382
2023-10-24 14:12 git Note Added: 0114413
2023-10-24 14:14 ichesnokova Assigned To ichesnokova => ika
2023-10-24 14:14 ichesnokova Status assigned => resolved
2023-10-24 14:14 ichesnokova Note Added: 0114414
2023-10-24 18:27 ika Status resolved => assigned
2023-10-24 18:27 ika Note Added: 0114419
2023-10-27 16:23 ika Assigned To ika => ichesnokova
2023-11-09 18:26 ichesnokova Description Updated
2023-11-09 19:28 git Note Added: 0114553
2023-11-09 19:31 ichesnokova Assigned To ichesnokova => ika
2023-11-09 19:31 ichesnokova Status assigned => resolved
2023-11-09 19:31 ichesnokova Note Added: 0114555
2023-11-10 15:03 git Note Added: 0114558
2023-11-10 15:06 ika Assigned To ika => bugmaster
2023-11-10 15:06 ika Status resolved => reviewed
2023-11-10 15:06 ika Note Added: 0114559
2023-11-13 18:10 vglukhik Assigned To bugmaster => ichesnokova
2023-11-13 18:10 vglukhik Status reviewed => assigned
2023-11-13 18:10 vglukhik Note Added: 0114573
2023-11-22 12:10 ichesnokova Assigned To ichesnokova => ika
2023-11-22 12:10 ichesnokova Status assigned => resolved
2023-11-22 12:10 ichesnokova Note Added: 0114620
2023-11-22 19:16 ika Assigned To ika => ichesnokova
2023-11-22 19:16 ika Status resolved => assigned
2023-11-22 19:16 ika Note Added: 0114625
2023-11-23 15:18 git Note Added: 0114631
2023-11-23 15:20 ichesnokova Assigned To ichesnokova => ika
2023-11-23 15:20 ichesnokova Status assigned => resolved
2023-11-23 15:20 ichesnokova Note Added: 0114632
2023-11-24 17:54 dpasukhi Note Added: 0114665
2023-11-27 15:20 ichesnokova Note Added: 0114671
2023-11-28 15:58 dpasukhi Note Added: 0114675
2023-11-28 15:59 dpasukhi Assigned To ika => dpasukhi
2023-11-28 15:59 dpasukhi Note Added: 0114676
2023-12-12 15:31 dpasukhi Assigned To dpasukhi => bugmaster
2023-12-12 15:31 dpasukhi Status resolved => reviewed
2023-12-12 15:31 dpasukhi Note Added: 0114722
2023-12-15 17:16 dpasukhi Changeset attached => occt master 0435edfe
2023-12-15 17:16 dpasukhi Assigned To bugmaster => dpasukhi
2023-12-15 17:16 dpasukhi Status reviewed => verified
2023-12-15 17:16 dpasukhi Resolution open => fixed
2023-12-18 04:04 git Note Added: 0114773
2023-12-18 04:04 git Note Added: 0114774
2023-12-18 04:04 git Note Added: 0114775
2024-01-18 19:33 dpasukhi Changeset attached => occt-products master 5dec4946