View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0033350 | Open CASCADE | OCCT:Data Exchange | public | 2023-03-22 21:21 | 2023-05-22 03:17 |
| Reporter | dpasukhi | Assigned To | dpasukhi | ||
| Priority | normal | Severity | minor | ||
| Status | verified | Resolution | fixed | ||
| Product Version | 7.7.0 | ||||
| Target Version | 7.7.2 | ||||
| Summary | 0033350: Data Exchange, Step Import - Improving parsing performance | ||||
| Description | Improving parsing performance | ||||
| Steps To Reproduce | No required | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR33350 has been created by dpasukhi. SHA-1: 0885ede77279a5b2ec15b414d13fdbd94b71c393 Detailed log of new commits: Author: dpasukhi Date: Wed Mar 22 18:22:44 2023 +0000 0033350: Data Exchange, Step Import - Improving parsing performance First commit to checking |
|
|
Branch CR33350 has been updated by dpasukhi. SHA-1: 7914f4cccf250c1559039b7336ea1d9c8cee271f Detailed log of new commits: Author: dpasukhi Date: Thu Mar 23 09:15:02 2023 +0000 // removing artifacts |
|
|
Branch CR33350 has been updated forcibly by dpasukhi. SHA-1: 99b47830a48d62cdd2e3e584c3fdfb92ca172f46 |
|
|
Dear ika, Please review CR33350 There only performance upgrade. Some details: 20% speed up for 700Mb file/ 85sec -> 70sec. Lexical parser updated to not check eof(it is not necessary double) Parsed entity record updated to deque instead of queue to fast access to the end. All tests are ok, see: http://jenkins-test-10.nnov.opencascade.com/view/CR33350-master-dpasukhi/view/COMPARE/ |
|
|
Dear dpasukhi, I don't have remarks on the code idea, but could you please fix the touched French output? "Non defini" -> "Not defined". |
|
|
Branch CR33350 has been updated by dpasukhi. SHA-1: 99b789ebc7e4f7f001a6ccd91a3ae08a05adc3f8 Detailed log of new commits: Author: dpasukhi Date: Thu May 11 14:32:50 2023 +0100 // fixing remarks |
|
|
Branch CR33350_1 has been created by dpasukhi. SHA-1: 5facc48dbea8d5e2f5238616b0bfd1ba9f43d851 Detailed log of new commits: Author: dpasukhi Date: Wed Mar 22 18:22:44 2023 +0000 0033350: Data Exchange, Step Import - Improving parsing performance Improved performance of parser by disable checking for eof (20% parsing time) Changed step parser's record to keep last one to fast insert into end. |
|
|
Remarks have been fixed. Please check CR33350. And review CR33350_1 Tests are not required (there are only comment changes) |
|
|
No more remarks. Dear bugmaster, please integrate OCCT - CR33350_1 |
|
|
Combination - OCCT branch : IR-2023-05-12 Products branch : IR-2023-05-12 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Ubuntu2004-64: OCCT Total CPU difference: 18189.300000000207 / 18355.18000000007 [-0.90%] Products Total CPU difference: 12137.909999999983 / 12171.56000000001 [-0.28%] Windows-64-VC142: OCCT Total CPU difference: 19812.3125 / 20719.140625 [-4.38%] Products Total CPU difference: 5352.15625 / 5404.359375 [-0.97%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR33350 has been deleted by mnt. SHA-1: 99b789ebc7e4f7f001a6ccd91a3ae08a05adc3f8 |
|
|
Branch CR33350_1 has been deleted by mnt. SHA-1: 5facc48dbea8d5e2f5238616b0bfd1ba9f43d851 |
|
occt: master 5d8b1a40 2023-03-22 18:22:44 Committer: vglukhik Details Diff |
0033350: Data Exchange, Step Import - Improving parsing performance Improved performance of parser by disable checking for eof (20% parsing time) Changed step parser's record to keep last one to fast insert into end. |
Affected Issues 0033350 |
|
| mod - src/StepFile/lex.step.cxx | Diff File | ||
| mod - src/StepFile/step.lex | Diff File | ||
| mod - src/StepFile/StepFile_ReadData.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-03-22 21:21 | dpasukhi | New Issue | |
| 2023-03-22 21:21 | dpasukhi | Assigned To | => dpasukhi |
| 2023-03-22 21:25 | git | Note Added: 0113315 | |
| 2023-03-23 12:15 | git | Note Added: 0113316 | |
| 2023-05-07 03:50 | git | Note Added: 0113443 | |
| 2023-05-08 17:54 | dpasukhi | Assigned To | dpasukhi => ika |
| 2023-05-08 17:54 | dpasukhi | Status | new => resolved |
| 2023-05-08 17:54 | dpasukhi | Steps to Reproduce Updated | |
| 2023-05-08 21:25 | dpasukhi | Note Added: 0113444 | |
| 2023-05-08 21:27 | dpasukhi | Steps to Reproduce Updated | |
| 2023-05-11 16:24 | ika | Assigned To | ika => dpasukhi |
| 2023-05-11 16:24 | ika | Status | resolved => assigned |
| 2023-05-11 16:24 | ika | Note Added: 0113460 | |
| 2023-05-11 16:33 | git | Note Added: 0113461 | |
| 2023-05-11 16:33 | git | Note Added: 0113462 | |
| 2023-05-11 16:34 | dpasukhi | Assigned To | dpasukhi => ika |
| 2023-05-11 16:34 | dpasukhi | Status | assigned => resolved |
| 2023-05-11 16:34 | dpasukhi | Note Added: 0113463 | |
| 2023-05-11 16:51 | ika | Assigned To | ika => bugmaster |
| 2023-05-11 16:51 | ika | Status | resolved => reviewed |
| 2023-05-11 16:51 | ika | Note Added: 0113464 | |
| 2023-05-15 16:34 | vglukhik | Note Added: 0113484 | |
| 2023-05-15 16:38 | vglukhik | Changeset attached | => occt master 5d8b1a40 |
| 2023-05-15 16:38 | dpasukhi | Assigned To | bugmaster => dpasukhi |
| 2023-05-15 16:38 | dpasukhi | Status | reviewed => verified |
| 2023-05-15 16:38 | dpasukhi | Resolution | open => fixed |
| 2023-05-22 03:17 | git | Note Added: 0113554 | |
| 2023-05-22 03:17 | git | Note Added: 0113555 |
