View Issue Details

IDProjectCategoryView StatusLast Update
0033338Open CASCADEOCCT:Codingpublic2023-03-16 17:35
ReporterDenisOrlov Assigned Todpasukhi  
PrioritynormalSeveritytweak 
Status resolvedResolutionopen 
Product Version7.7.0 
Target VersionUnscheduled 
Summary0033338: Coding - IGESToBRep_CurveAndSurface's method has unreachable code
DescriptionIGESToBRep_CurveAndSurface::TransferGeometry method has unreachable "else if" section:
 line 424 of the file IGESToBRep_CurveAndSurface.cxx :
in case of start->IsKind(STANDARD_TYPE(IGESBasic_GroupWithoutBackP))
the code is stopped on the line 361, which works with most general case:
start->IsKind(STANDARD_TYPE(IGESBasic_Group)).
Moreover, both sections are equal, and should be merged into one.
Steps To ReproduceNot required
TagsNo tags attached.
Test case number

Relationships

related to 0023638 resolveddpasukhi Community Data Exchange - Reading IGES file produced invalid shape 

Activities

git

2023-02-28 17:11

administrator   ~0113215

Branch CR33338 has been created by DenisOrlov.

SHA-1: 5a0564a28e28f05143ba750a6dac2181d1d2e30f


Detailed log of new commits:

Author: dorlov
Date: Tue Feb 28 14:11:06 2023 +0000

    0033338: Coding - IGESToBRep_CurveAndSurface's method has unreachable code
    
    Fixed unreachable code in IGESToBRep_CurveAndSurface::TransferGeometry method

DenisOrlov

2023-03-16 17:35

developer   ~0113289

Dear dpasukhi, please review: OCCT: CR33338 PROD: NO
Most of builds are ok,
http://jenkins-test-10.nnov.opencascade.com/view/CR33338-master-DenisOrlov/view/OCCT%20compile/
Tests relevant to the bug are passed.
http://jenkins-test-10.nnov.opencascade.com/view/CR33338-master-DenisOrlov/view/COMPARE/
I Removed unreachable code.

Issue History

Date Modified Username Field Change
2023-02-27 15:44 DenisOrlov New Issue
2023-02-27 15:44 DenisOrlov Assigned To => dpasukhi
2023-02-27 16:13 dpasukhi Product Version 7.7.1 => 7.7.0
2023-02-27 16:13 dpasukhi Target Version 7.7.1 => 7.8.0
2023-02-27 16:15 dpasukhi Summary IGESToBRep_CurveAndSurface::TransferGeometry method has unreachable "else if" section => Coding - IGESToBRep_CurveAndSurface's method has unreachable code
2023-02-27 16:55 dpasukhi Severity minor => tweak
2023-02-27 17:46 dpasukhi Relationship added related to 0023638
2023-02-28 15:21 DenisOrlov Assigned To dpasukhi => DenisOrlov
2023-02-28 17:11 git Note Added: 0113215
2023-03-06 18:53 eugeny.belousov_162739 Target Version 7.8.0 => Unscheduled
2023-03-16 17:35 DenisOrlov Assigned To DenisOrlov => dpasukhi
2023-03-16 17:35 DenisOrlov Status new => resolved
2023-03-16 17:35 DenisOrlov Steps to Reproduce Updated
2023-03-16 17:35 DenisOrlov Note Added: 0113289