View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0033312CommunityOCCT:Data Exchangepublic2023-01-10 13:062023-03-07 14:12
Reportergkv311 Assigned Tovglukhik  
PrioritynormalSeverityminor 
Status verifiedResolutionfixed 
PlatformLinuxOSUbuntu 20.04 
Product Version7.7.0 
Target Version7.7.1 
Summary0033312: Data Exchange - NULL-dereference in StepToTopoDS_TranslateShell::Init()
DescriptionGCC12 found the following misprint in StepToTopoDS_TranslateShell::Init() leading to obvious NULL-dereference introduced by commit for 0030024:
C:\occt.git\src\StepToTopoDS\StepToTopoDS_TranslateShell.cxx:143: warning: 'this' pointer is null [-Wnonnull]
C:/occt.git/src/StepToTopoDS/StepToTopoDS_TranslateShell.cxx: In member function 'void StepToTopoDS_TranslateShell::Init(const opencascade::handle<StepVisual_TessellatedShell>&, StepToTopoDS_Tool&, StepToTopoDS_NMTool&, Standard_Boolean, Standard_Boolean&, const Message_ProgressRange&)':
C:/occt.git/src/StepToTopoDS/StepToTopoDS_TranslateShell.cxx:143:27: warning: 'this' pointer is null [-Wnonnull]
  143 |       aSh = aBinder->Shell();
      |             ~~~~~~~~~~~~~~^~


on the following code:
    Handle(TransferBRep_ShapeBinder) aBinder
      = Handle(TransferBRep_ShapeBinder)::DownCast(aTP->Find(theTSh->TopologicalLink()));
    if (aBinder.IsNull()) 
    {
      aSh = aBinder->Shell();
      theHasGeom = Standard_True;
    }
Steps To ReproduceNot required
TagsNo tags attached.
Test case number

Relationships

related to 0030024 verifiedsnn Community Data Exchange - STEP export support of BRep shapes based on tessellated geometry 

Activities

git

2023-01-12 14:39

administrator   ~0112795

Branch CR33312 has been created by DenisOrlov.

SHA-1: 0aaf1ad9f904a3337366b64212d6793a1bddec62


Detailed log of new commits:

Author: dorlov
Date: Thu Jan 12 11:39:07 2023 +0000

    0033312: Data Exchange - NULL-dereference in StepToTopoDS_TranslateShell::Init()
    The condition "if" was changed to opposite

git

2023-01-19 12:19

administrator   ~0112880

Branch CR33312 has been updated forcibly by DenisOrlov.

SHA-1: a659752c444703f35a75300ab9289e9376b2b4eb

git

2023-01-19 12:23

administrator   ~0112881

Branch CR33312 has been updated forcibly by DenisOrlov.

SHA-1: b362f8849b25ac757066aa2ae0b27441e32900b8

DenisOrlov

2023-01-19 12:40

developer   ~0112884

The condition "if" was changed to opposite

DenisOrlov

2023-01-19 13:22

developer   ~0112885

Dear ika, please review: OCCT: CR33312 PROD: NO
All builds are ok,
http://jenkins-test-10.nnov.opencascade.com/view/CR33312-master-DenisOrlov/view/OCCT%20compile/job/CR33312-master-DenisOrlov-OCCT-Ubuntu2004-64-opt-compile/
http://jenkins-test-10.nnov.opencascade.com/view/CR33312-master-DenisOrlov/view/OCCT%20compile/job/CR33312-master-DenisOrlov-OCCT-Windows-64-VC142-opt-compile/
Tests are not required. 
I fixed the problem with incorrect compare

ika

2023-01-19 17:05

developer   ~0112887

No remarks.
Dear bugmaster,
please integrate
OCCT CR33312

git

2023-01-21 16:27

administrator   ~0112909

Branch CR33312 has been deleted by mnt.

SHA-1: b362f8849b25ac757066aa2ae0b27441e32900b8

Related Changesets

occt: master fc72568b

2023-01-12 14:39:07

dorlov


Committer: vglukhik Details Diff		 0033312: Data Exchange - NULL-dereference in StepToTopoDS_TranslateShell::Init()

The condition "if" was changed to opposite		 Affected Issues
0033312
mod - src/StepToTopoDS/StepToTopoDS_TranslateShell.cxx Diff File

Issue History

Date Modified Username Field Change
2023-01-10 13:06 gkv311 New Issue
2023-01-10 13:06 gkv311 Assigned To => ika
2023-01-10 13:45 dpasukhi Relationship added related to 0030024
2023-01-11 16:54 dpasukhi Assigned To ika => DenisOrlov
2023-01-12 14:39 git Note Added: 0112795
2023-01-19 11:50 DenisOrlov Status new => resolved
2023-01-19 12:18 dpasukhi Status resolved => assigned
2023-01-19 12:19 git Note Added: 0112880
2023-01-19 12:23 git Note Added: 0112881
2023-01-19 12:40 DenisOrlov Status assigned => feedback
2023-01-19 12:40 DenisOrlov Note Added: 0112884
2023-01-19 12:44 dpasukhi Status feedback => assigned
2023-01-19 12:45 DenisOrlov Assigned To DenisOrlov => ika
2023-01-19 12:45 DenisOrlov Status assigned => resolved
2023-01-19 12:45 DenisOrlov Steps to Reproduce Updated
2023-01-19 12:46 dpasukhi Assigned To ika => DenisOrlov
2023-01-19 12:46 dpasukhi Status resolved => assigned
2023-01-19 12:47 dpasukhi Steps to Reproduce Updated
2023-01-19 12:56 DenisOrlov Assigned To DenisOrlov => ika
2023-01-19 12:56 DenisOrlov Status assigned => resolved
2023-01-19 12:56 DenisOrlov Steps to Reproduce Updated
2023-01-19 13:22 DenisOrlov Note Added: 0112885
2023-01-19 17:05 ika Assigned To ika => bugmaster
2023-01-19 17:05 ika Status resolved => reviewed
2023-01-19 17:05 ika Note Added: 0112887
2023-01-21 16:23 vglukhik Changeset attached => occt master fc72568b
2023-01-21 16:23 vglukhik Assigned To bugmaster => vglukhik
2023-01-21 16:23 vglukhik Status reviewed => verified
2023-01-21 16:23 vglukhik Resolution open => fixed
2023-01-21 16:27 git Note Added: 0112909
2023-03-07 14:12 dpasukhi Product Version => 7.7.0
2023-03-07 14:12 dpasukhi Target Version => 7.7.1