View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0033099 | Open CASCADE | OCCT:Data Exchange | public | 2022-08-10 15:36 | 2025-02-19 22:14 |
| Reporter | dpasukhi | Assigned To | dpasukhi | ||
| Priority | normal | Severity | major | ||
| Status | assigned | Resolution | open | ||
| Target Version | 7.8.0 | ||||
| Summary | 0033099: Data Exchange, Step Import - Wrong PMI values in GDT | ||||
| Description | When read step file contains the GDT with complex type of measure(main value). The GDT value does set to XCAD (0,0 by default) It is needed to update handle measure as a complex type too (use a base class to keep the entity) Complex measure type is a StepRepr_ReprItemAndLengthMeasureWithUnitAndQRI. Now we only process StepBasic_LengthMeasureWithUnit as a measure entity | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
| related to | 0033633 | new | Data Exchange, Step Import - Zero value of semantic dimentions |
|
|
Branch CR33099 has been created by dpasukhi. SHA-1: 0f455fa7c44b346e92a6d91707ee2373446de31a Detailed log of new commits: Author: dpasukhi Date: Fri Aug 12 15:02:44 2022 +0300 0033099: Data Exchange, Step Import - Wrong PMI values in GDT Fixed magnitude class to handle main GDT value. |
|
|
Branch CR33099_1 has been created by ichesnokova. SHA-1: 91fe6e53adb6c21de3535203eff8e0e70763c2c2 Detailed log of new commits: Author: dpasukhi Date: Fri Aug 12 15:02:44 2022 +0300 0033099: Data Exchange, Step Import - Wrong PMI values in GDT Fixed magnitude class to handle main GDT value. |
|
|
Branch CR33099_1 has been updated forcibly by ichesnokova. SHA-1: 3efb5c2a7e1221f455b7d768dfea3ee25ce04e28 |
|
|
Branch CR33099_1 has been updated forcibly by ichesnokova. SHA-1: 58239e1c0c05127e0d3bf70d988ece9d3eb05c80 |
|
|
Branch CR33099_2 has been created by anv. SHA-1: 05657c1989ed3c46f77877ae53569d12ad08e591 Detailed log of new commits: Author: dpasukhi Date: Fri Aug 12 13:02:44 2022 +0100 0033099: Data Exchange, Step Import - Wrong PMI values in GDT Create StepRepr_MeasureWithUnit class for select type of measure. |
|
|
Branch CR33099_2 has been updated forcibly by anv. SHA-1: 0738b90a3dcf8850e42f3ec52218db30542d5114 |
|
|
Branch CR33099_2 has been updated forcibly by anv. SHA-1: 98fd3a7958610b481dc7d5998e007c3f41e9bd29 |
|
|
Dear ika, The fix is ready and tested. Branch for integration is CR33099_2. Please review. |
|
|
Dear anv, The general approach is not OK from my point of view: 1) Creating of new StepRepr_MeasureWithUnit while we already have StepBasic_MeasureWithUnit will lead to problems with understanding in the future. 2) The STEP reading classes copy the STEP schema as much as possible, so it will be better to avoid creating an auxiliary SELECT entity that does not exist in the schema. Summarising these items, I would suppose a bit another approach. First of all, the root of the problem are complex entities used in the file to define the GDT value. The class for them is already implemented in OCCT StepRepr_ReprItemAndLengthMeasureWithUnitAndQRI. It will be better to use it, but here we will face another issue. Two entities reference this complex type: SHAPE_DIMENSION_REPRESENTATION and GEOMETRIC_TOLERANCE. The first one should process the StepRepr_ReprItemAndLengthMeasureWithUnitAndQRI properly because the inheritance branch of the corresponding attribute is OK, but GEOMETRIC_TOLERANCE supposes measure_with_unit as the magnitude parameter, which is not inherited from the same item, but we can use the root Standard_Transient for the magnitude pole. ReadEntity() is smart enough to read both StepRepr_ReprItemAndLengthMeasureWithUnitAndQRI and StepBasic_MeasureWithUnit into it. The last step will be to check the processing of the value in STEPCAFControl_Reader and add necessary ifs. |
|
|
Branch CR33099_2 has been updated forcibly by anv. SHA-1: b281b7eb0962bb22b53286e2b55b8474ac727a35 |
|
|
Branch CR33099_2 has been updated forcibly by anv. SHA-1: 180d78172c15c1c3a41536e7e90f4770265e8776 |
|
|
Reminder sent to: avn |
|
|
Needs to clear code style changes. Needs to clear non-PMI related updates. Changes must to be mostly for PMI related objects. Recommended way is read as Entity and put into PMI anly needed type. So, only RW will need to be updated. But for the beginning need to revert any code style changes. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-10 15:36 | dpasukhi | New Issue | |
| 2022-08-10 15:36 | dpasukhi | Assigned To | => dpasukhi |
| 2022-10-24 10:38 |
|
Target Version | 7.7.0 => 7.8.0 |
| 2023-01-25 18:50 | dpasukhi | Severity | minor => major |
| 2023-02-27 17:17 | dpasukhi | Assigned To | dpasukhi => ichesnokova |
| 2023-02-27 17:17 | dpasukhi | Status | new => assigned |
| 2023-03-01 14:25 | git | Note Added: 0113218 | |
| 2023-03-03 16:59 | git | Note Added: 0113222 | |
| 2023-03-03 21:46 | git | Note Added: 0113225 | |
| 2023-03-03 21:46 |
|
Assigned To | ichesnokova => dpasukhi |
| 2023-03-03 21:46 |
|
Status | assigned => feedback |
| 2023-03-09 14:36 | git | Note Added: 0113241 | |
| 2023-03-09 19:15 | dpasukhi | Status | feedback => resolved |
| 2023-09-19 21:09 | git | Note Added: 0114196 | |
| 2023-09-20 07:22 | git | Note Added: 0114206 | |
| 2023-09-20 19:23 | git | Note Added: 0114208 | |
| 2023-09-22 08:05 |
|
Assigned To | dpasukhi => ika |
| 2023-09-22 08:07 |
|
Note Added: 0114245 | |
| 2023-09-22 18:58 | ika | Assigned To | ika => anv |
| 2023-09-22 18:58 | ika | Status | resolved => assigned |
| 2023-09-22 18:58 | ika | Note Added: 0114261 | |
| 2023-09-27 08:37 | git | Note Added: 0114304 | |
| 2023-09-27 18:17 | git | Note Added: 0114311 | |
| 2024-03-06 18:09 | dpasukhi | Relationship added | related to 0033633 |
| 2024-03-06 18:12 | dpasukhi | Note Added: 0115250 | |
| 2024-03-06 18:33 | dpasukhi | Note Added: 0115251 | |
| 2025-02-19 22:14 | dpasukhi | Project | Internal => Open CASCADE |
| 2025-02-19 22:14 | dpasukhi | Assigned To | anv => dpasukhi |
