View Issue Details

IDProjectCategoryView StatusLast Update
0032952Open CASCADEOCCT:Codingpublic2022-07-10 12:09
Reporterkgv Assigned Tokgv  
PrioritynormalSeverityminor 
Status verifiedResolutionfixed 
Product Version7.7.0 
Target Version7.7.0 
Summary0032952: Coding Rules, Graphic3d_DisplayPriority - rename inconsistent Below2/Above1 enties
DescriptionEntries Below2, Below3 are named inconsistently to Above1, Above2:
  Graphic3d_DisplayPriority_INVALID      = -1,
  Graphic3d_DisplayPriority_Bottom       =  0,
  Graphic3d_DisplayPriority_AlmostBottom =  1,
  Graphic3d_DisplayPriority_Below3       =  2,
  Graphic3d_DisplayPriority_Below2       =  3,
  Graphic3d_DisplayPriority_Below        =  4,
  Graphic3d_DisplayPriority_Normal       =  5,
  Graphic3d_DisplayPriority_Above        =  6,
  Graphic3d_DisplayPriority_Above1       =  7,
  Graphic3d_DisplayPriority_Above2       =  8,
  Graphic3d_DisplayPriority_Highlight    =  9,
  Graphic3d_DisplayPriority_Topmost      = 10,
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberN/A

Relationships

child of 0032725 verifiedkgv Visualization - Graphic3d_Structure::SetDisplayPriority() should use public enumeration Graphic3d_DisplayPriority 

Activities

git

2022-07-06 22:13

administrator   ~0109630

Branch CR32952 has been created by kgv.

SHA-1: 8abec9cf149bf443c3778bea46c3441952cd730b


Detailed log of new commits:

Author: kgv
Date: Wed Jul 6 22:12:52 2022 +0300

    0032952: Coding Rules, Graphic3d_DisplayPriority - rename inconsistent Below2/Above1 enties
    
    Below/Below2/Below3 triplet has been renamed to Below/Below1/Below2
    for consistency with Above/Above1/Above2

kgv

2022-07-06 22:13

developer   ~0109631

Patch is ready for review
- OCCT: branch CR32952.

osa

2022-07-07 16:19

developer   ~0109670

The patch was reviewed

smoskvin

2022-07-10 11:22

administrator   ~0109714

Combination -
OCCT branch : IR-2022-07-08
master SHA - changes and them, and you can discard any commits you make in this
33c8a72788661285860902f261062e39f32a2d46
changes and them, and you can discard any commits you make in this
e0ceb716c70188b98130b1550914140d0502a6f9
Products branch : IR-2022-07-08 SHA - 79a687f1cd4081ec53ec08c201360e89fce62abc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18685.930000000586 / 18908.870000000694 [-1.18%]
Products
Total CPU difference: 11796.890000000125 / 11832.130000000114 [-0.30%]
Windows-64-VC14:
OCCT
Total CPU difference: 20784.828125 / 20752.59375 [+0.16%]
Products
Total CPU difference: 13361.3125 / 13368.90625 [-0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2022-07-10 12:09

administrator   ~0109736

Branch CR32952 has been deleted by mnt.

SHA-1: 8abec9cf149bf443c3778bea46c3441952cd730b

Related Changesets

occt: master 7a52478f

2022-07-06 22:12:52

kgv


Committer: smoskvin Details Diff
0032952: Coding Rules, Graphic3d_DisplayPriority - rename inconsistent Below2/Above1 enties

Below/Below2/Below3 triplet has been renamed to Below/Below1/Below2
for consistency with Above/Above1/Above2
Affected Issues
0032952
mod - src/Graphic3d/Graphic3d_DisplayPriority.hxx Diff File

Issue History

Date Modified Username Field Change
2022-04-27 10:49 kgv New Issue
2022-04-27 10:49 kgv Assigned To => kgv
2022-04-27 10:49 kgv Relationship added child of 0032725
2022-07-06 22:13 git Note Added: 0109630
2022-07-06 22:13 kgv Assigned To kgv => osa
2022-07-06 22:13 kgv Status new => resolved
2022-07-06 22:13 kgv Test case number => N/A
2022-07-06 22:13 kgv Note Added: 0109631
2022-07-07 16:19 osa Assigned To osa => bugmaster
2022-07-07 16:19 osa Status resolved => reviewed
2022-07-07 16:19 osa Note Added: 0109670
2022-07-10 11:22 smoskvin Status reviewed => tested
2022-07-10 11:22 smoskvin Note Added: 0109714
2022-07-10 12:03 smoskvin Changeset attached => occt master 7a52478f
2022-07-10 12:03 kgv Assigned To bugmaster => kgv
2022-07-10 12:03 kgv Status tested => verified
2022-07-10 12:03 kgv Resolution open => fixed
2022-07-10 12:09 git Note Added: 0109736