View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0032922 | Open CASCADE | OCCT:Data Exchange | public | 2022-04-07 13:05 | 2023-03-19 19:10 |
Reporter | Assigned To | ||||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 7.7.0 | ||||
Target Version | 7.7.0 | Fixed in Version | 7.6.3 | ||
Summary | 0032922: Data Exchange, STEP - The torus is stored incorrectly in STEP format | ||||
Description | If you create a torus and save it in STEP format, then after it is loaded and converted to TopoDS_Shape and before the ShapeHealing procedure is applied, the wire specifying the only face of the torus has an incorrect edge orientation. | ||||
Steps To Reproduce | To reproduce the problem you must to turn off shape healing procedure in STEP read processing. This can be done with XSTEPResource/STEPfile. The script bug32922was made to simplify the task. Just put it on tests/bugs/step/directory and run. | ||||
Tags | No tags attached. | ||||
Test case number | Not required | ||||
|
|
|
Branch CR32922 has been created by atereshi. SHA-1: 9c693e275a62199b67d85e477ac9a8a5e0ca93e2 Detailed log of new commits: Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Some refactoring. Replaced circle through edges after ShapeFix_Wire::FixReorder() to BRepTools_WireExplorer circle. |
|
Branch CR32922_1 has been created by atereshi. SHA-1: d6bcdfd8889e3be7489d66f8e54a23419eb6bfec Detailed log of new commits: Author: atereshi Date: Mon Apr 11 14:06:43 2022 +0300 0032922: Some refactoring. Added extra analysis in UV-space for toroidal surface. Author: atereshi Date: Mon Apr 11 12:18:15 2022 +0300 0032922: Some refactoring. Added extra analysis in UV-space for toroidal surface. |
|
Branch CR32922_2 has been created by atereshi. SHA-1: 6f19592b1a1bef7ad72136d8a37a7df0d6ee3a88 Detailed log of new commits: Author: atereshi Date: Thu Apr 14 14:21:31 2022 +0300 0032922: Some refactoring. 3D and 2D mode. |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: 00289f9844b3de16161fbacd71a03da5d8f069a3 Detailed log of new commits: Author: atereshi Date: Fri Apr 15 11:24:48 2022 +0300 0032922: Some refactoring. Both mode only if capable. Author: atereshi Date: Thu Apr 14 16:25:22 2022 +0300 0032922: Some refactoring. 3D and 2D mode. Author: atereshi Date: Thu Apr 14 16:20:36 2022 +0300 0032922: Some refactoring. 3D and 2D mode. |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: b938a3852e171e16c4503dcdd6f4b70c5f359409 Detailed log of new commits: Author: atereshi Date: Fri Apr 15 21:32:22 2022 +0300 0032922: Some refactoring. Author: atereshi Date: Fri Apr 15 13:52:07 2022 +0300 0032922: Some refactoring. Both mode only if capable. test file |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: 1327ef33ceef130c65c24977442ea40818d5189f Detailed log of new commits: Author: atereshi Date: Fri Apr 15 22:17:43 2022 +0300 0032922: Some refactoring. Minus file |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: a60c0f3fb7403a4310d682dfa6e2d7cfdad86b88 Detailed log of new commits: Author: atereshi Date: Mon Apr 18 11:23:31 2022 +0300 0032922_2: Back from enum to bool. |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: fe9b7a2ed513c0259fb42923c96099201e48710f Detailed log of new commits: Author: atereshi Date: Mon Apr 18 14:40:44 2022 +0300 0032922_2: isShiftForward -> nothing to do |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: d3967d82d0d39b6ffee2f324e87d48a9b0f9f1c4 Detailed log of new commits: Author: atereshi Date: Wed Apr 20 11:14:31 2022 +0300 0032922_2: -save to file, +theModeBoth Author: atereshi Date: Tue Apr 19 15:48:53 2022 +0300 0032922_2: test cr standard C9 |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: 599f41237391b76c5f0998c345d0ab926f76e75e Detailed log of new commits: Author: atereshi Date: Wed Apr 20 16:53:54 2022 +0300 0032922_2: comments + fix test |
|
Branch CR32922_3 has been created by atereshi. SHA-1: 9dc7af5d4d15156bb1106a548804e1d152d15228 Detailed log of new commits: Author: atereshi Date: Wed Apr 20 19:34:42 2022 +0300 0032922_3: aCurMin = Min(aMinDistToTail, aMinDistToHead); |
|
Branch CR32922_2 has been updated by atereshi. SHA-1: 915a7df6bed09a6c3180575014a712806b8758ce Detailed log of new commits: Author: atereshi Date: Thu Apr 21 15:17:48 2022 +0300 0032922_3: added FromSTEP2 = without healing |
|
The test has been created to detect the problem. No more need to use debugger. bug32922 (4,392 bytes) |
|
Branch CR32922 has been deleted by atereshi. SHA-1: 9c693e275a62199b67d85e477ac9a8a5e0ca93e2 |
|
Branch CR32922_1 has been deleted by atereshi. SHA-1: d6bcdfd8889e3be7489d66f8e54a23419eb6bfec |
|
Branch CR32922_2 has been deleted by atereshi. SHA-1: 915a7df6bed09a6c3180575014a712806b8758ce |
|
Branch CR32922_3 has been deleted by atereshi. SHA-1: 9dc7af5d4d15156bb1106a548804e1d152d15228 |
|
Branch CR32922 has been created by atereshi. SHA-1: 53a224238e17881783a70e8284310bf5ea90d928 Detailed log of new commits: Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information. The new mode is used for torus-like surfaces before saving to STEP format. Added a test. |
|
Added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information to ShapeAnalysis_WireOrder. The new mode is used only for torus-like surfaces (ShapeFix_Wire::FixReorder) and only before saving to STEP format (TopoDSToStep_MakeStepWire). |
|
Branch CR32922_1 has been created by atereshi. SHA-1: 2514248803c7f7133dc70f6563ab7d2f0c28185a Detailed log of new commits: Author: atereshi Date: Mon Apr 25 15:19:30 2022 +0300 0032922_1: removed unused include Author: atereshi Date: Mon Apr 25 15:17:02 2022 +0300 Merge branch 'master' into CR32922_1 |
|
Branch CR32922_1 has been deleted by atereshi. SHA-1: 2514248803c7f7133dc70f6563ab7d2f0c28185a |
|
Branch CR32922 has been deleted by atereshi. SHA-1: 53a224238e17881783a70e8284310bf5ea90d928 |
|
Branch CR32922 has been created by atereshi. SHA-1: aeda79abb5b955af3afb5e7be41ba923fea3f560 Detailed log of new commits: Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
|
The first line of the first commit must contain the bug summary followed by the empty line. General remark: according to coding rules when a simple type is passed as value argument it should be declared const. So, do not change old interfaces and use it in a new one. src/ShapeAnalysis/ShapeAnalysis_Wire.cxx - CheckOrder (sawo, isClosed, mode3d); + CheckOrder(sawo, isClosed, mode3d, Standard_False); Tune your text editor to insert a space before open parenthesis. 595: do not raise fail status if you are not going to return false. src/ShapeAnalysis/ShapeAnalysis_WireOrder.hxx 158: witch -> which, is works -> works 170: for pure 2D points it is better to use TColgp_HSequenceOfXY. src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx 98: It is not following the method description. It must check the condition "myMode != aNewMode". 226: restore the method cover. 240: instead use NCollection_Sequence<Handle(TColStd_HSequenceOfInteger)>. 245: TColgp_Array1OfXY 268: gp_Pnt2d 287,464: remove comment 449: remove extra code 459: move definition of aCloseDist where it is used. 504: replace with simple break, but aLoops.Append(anEdgeSeq) restore again after the cycle. 755: if the mode is Both it is needed to get coords from myXY. src/TopoDSToStep/TopoDSToStep_MakeStepWire.cxx 208 and below: replace tabs with spaces src/XSTEPResource/STEP Not relevant only spacing changes, please revert. tests/bugs/step/bug32922 2: output the full bug summary |
|
Result of the bug32922 script for master branch. torus_wire.png (9,776 bytes) |
|
Branch CR32922 has been updated by atereshi. SHA-1: d972a09cdaf1fa107ae3072466496c2b71096603 Detailed log of new commits: Author: atereshi Date: Fri May 6 12:03:31 2022 +0300 Merge remote-tracking branch 'origin/CR32922' into CR32922 Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
|
Branch CR32922 has been deleted by atereshi. SHA-1: d972a09cdaf1fa107ae3072466496c2b71096603 |
|
Branch CR32922 has been created by atereshi. SHA-1: a0ba11c492d1b7ce735a7b585584d4bd35133ad8 Detailed log of new commits: Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
|
Branch CR32922 has been deleted by atereshi. SHA-1: a0ba11c492d1b7ce735a7b585584d4bd35133ad8 |
|
Branch CR32922 has been created by atereshi. SHA-1: fa6b27db8736d6767b4f3364f8a21b6c2d4c1eb8 Detailed log of new commits: Author: atereshi Date: Wed May 11 14:04:10 2022 +0300 # consideration of comments from the review Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Bug in ShapeFix_Wire.cxx, ShapeAnalysis_Wire.cxx, ShapeAnalysis_WireOrder.cxx Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
|
Comments from the review have been eliminated |
|
The first line of the first commit must contain the bug summary. src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx 125: Make new myXY only in ModeBoth. Otherwise just nullify it. 176: theStart2d is of type gp_XY already, so no need to create a temporary variable. 532: syntax "is than", use 'when' or 'that'. 547: use const&. 757: what if Mode3d? |
|
Branch CR32922 has been deleted by atereshi. SHA-1: fa6b27db8736d6767b4f3364f8a21b6c2d4c1eb8 |
|
Branch CR32922 has been created by atereshi. SHA-1: 317663ff1e5d9fb0c2539a198399f48258e4a4fd Detailed log of new commits: Author: atereshi Date: Wed May 11 14:04:10 2022 +0300 # consideration of comments from the review Author: atereshi Date: Tue May 24 11:22:21 2022 +0300 # remarks correction from the review2 Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Data Exchange, STEP - The torus is stored incorrectly in STEP format Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
|
Branch CR32922 has been updated by atereshi. SHA-1: c8dc2e5adf74d98d9d103dbf863bb1f4dad6b511 Detailed log of new commits: Author: ifv Date: Mon May 16 11:37:40 2022 +0300 0032973: Modeling Algorithms - Regression in BRepExtrema_DistShapeShape compared with 7.5 BRepExtrema/BRepExtrema_ExtCF.cxx - set correct using BRepAdaptor_Curve in Extrema tests/bugs/modalg_8/bug32973 - new test case added Author: mgerus Date: Wed May 18 09:45:05 2022 +0300 0026697: BRepFeat_MakePrism returns empty compound Add fix in direction of prism calculation Author: kgv Date: Mon May 16 23:02:31 2022 +0300 0032976: Visualization - AIS_InteractiveContext::FitSelected() includes objects invisible in current View Author: kgv Date: Mon May 16 22:28:09 2022 +0300 0032975: Visualization, TKOpenGl - do not blit inactive Subview Author: aml Date: Fri Jan 14 18:56:30 2022 +0300 0032969: Coding - get rid of unused headers [IMeshData to PLib] Removed unused exception classes OSD_Exception_FLT_DIVIDE_BY_ZERO, OSD_Exception_INT_DIVIDE_BY_ZERO, OSD_Exception_FLT_DENORMAL_OPERAND, OSD_Exception_FLT_INEXACT_RESULT, OSD_Exception_FLT_INVALID_OPERATION, OSD_Exception_FLT_OVERFLOW, OSD_Exception_FLT_STACK_CHECK, OSD_Exception_FLT_UNDERFLOW. Author: mgerus Date: Wed May 11 16:08:55 2022 +0300 0032807: Modeling Algorithms - Bad result of sweep operation when the UEdges has more than one intersect points Add choosing the intersect point taking into account the tangentCross when prev UEdge and next UEdge has more than one intersect points; Add exact correction of edge tolerance (it fix problems with edge tolerance on Linux); Add exact check of edge tolerance in testcase Author: kgv Date: Sun May 15 01:11:06 2022 +0300 0032970: Visualization, TKOpenGl - fix compilation on Linux: 'False' was not declared |
|
Branch CR32922 has been deleted by atereshi. SHA-1: c8dc2e5adf74d98d9d103dbf863bb1f4dad6b511 |
|
Branch CR32922 has been created by atereshi. SHA-1: 516b305e2bbb4c030f7349d5c5c2f99265ab5f42 Detailed log of new commits: Author: atereshi Date: Fri Apr 8 14:16:01 2022 +0300 0032922: Data Exchange, STEP - The torus is stored incorrectly in STEP format Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. Author: atereshi Date: Wed May 11 14:04:10 2022 +0300 # consideration of comments from the review Author: atereshi Date: Tue May 24 11:22:21 2022 +0300 # remarks correction from the review2 |
|
Branch CR32922 has been updated by atereshi. SHA-1: ee481e1f2d6e1d51226a27ac1f8dd43368b6780f Detailed log of new commits: Author: atereshi Date: Tue May 24 14:20:22 2022 +0300 # fix regression |
|
Corrected remarks |
|
For integration: occt - CR32922 products - none |
|
Combination - OCCT branch : IR-2022-05-27 master SHA - 23c56fc66a1823b6e5e58ec3925a490d00eec6bc e0ceb716c70188b98130b1550914140d0502a6f9 Products branch : IR-2022-05-27 SHA - aa5fde964222c544924ec5189b662b75a13e6bdd was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 18742.72000000061 / 18677.050000000647 [+0.35%] Products Total CPU difference: 11723.460000000106 / 11729.870000000092 [-0.05%] Windows-64-VC14: OCCT Total CPU difference: 20706.5625 / 20665.84375 [+0.20%] Products Total CPU difference: 13249.46875 / 13282.171875 [-0.25%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
Branch CR32922 has been deleted by mnt. SHA-1: ee481e1f2d6e1d51226a27ac1f8dd43368b6780f |
occt: master 9b9aac4a 2022-04-08 14:16:01
Committer: |
0032922: Data Exchange, STEP - The torus is stored incorrectly in STEP format Problem: the complete surface of the torus is not stored correctly in STEP format due to the fact that the edges are not properly ordered. Change: added a mode for reordering edges in the wire with simultaneous use of 2d and 3d information (ShapeAnalysis_WireOrder). The new mode is used for torus-like surfaces before saving to STEP format. Result: Torus correctly stored. |
Affected Issues 0032922 |
|
mod - src/ShapeAnalysis/ShapeAnalysis_Wire.cxx | Diff File | ||
mod - src/ShapeAnalysis/ShapeAnalysis_Wire.hxx | Diff File | ||
mod - src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx | Diff File | ||
mod - src/ShapeAnalysis/ShapeAnalysis_WireOrder.hxx | Diff File | ||
mod - src/ShapeFix/ShapeFix_Wire.cxx | Diff File | ||
mod - src/ShapeFix/ShapeFix_Wire.hxx | Diff File | ||
mod - src/TopoDSToStep/TopoDSToStep_MakeStepWire.cxx | Diff File | ||
mod - tests/bugs/step/bug28256 | Diff File | ||
add - tests/bugs/step/bug32922 | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-04-07 13:05 |
|
New Issue | |
2022-04-07 13:05 |
|
Assigned To | => msv |
2022-04-07 13:05 |
|
File Added: torus.stp | |
2022-04-07 13:14 |
|
Steps to Reproduce Updated | |
2022-04-07 13:19 |
|
Steps to Reproduce Updated | |
2022-04-07 13:21 |
|
Steps to Reproduce Updated | |
2022-04-07 13:46 | kgv | Summary | Data Exchange - The torus is stored incorrectly in STEP format => Data Exchange, STEP - The torus is stored incorrectly in STEP format |
2022-04-07 14:02 | kgv | Steps to Reproduce Updated | |
2022-04-07 14:04 |
|
Note Added: 0107680 | |
2022-04-07 14:04 |
|
File Added: torus_bug.png | |
2022-04-08 14:45 | git | Note Added: 0107756 | |
2022-04-11 14:12 | git | Note Added: 0107841 | |
2022-04-14 14:21 | git | Note Added: 0107953 | |
2022-04-15 11:25 | git | Note Added: 0107990 | |
2022-04-15 22:11 | git | Note Added: 0107993 | |
2022-04-15 22:17 | git | Note Added: 0107994 | |
2022-04-18 11:23 | git | Note Added: 0108015 | |
2022-04-18 14:40 | git | Note Added: 0108016 | |
2022-04-20 11:14 | git | Note Added: 0108037 | |
2022-04-20 16:54 | git | Note Added: 0108050 | |
2022-04-20 19:34 | git | Note Added: 0108053 | |
2022-04-21 15:18 | git | Note Added: 0108084 | |
2022-04-25 10:41 |
|
Note Added: 0108137 | |
2022-04-25 10:41 |
|
File Added: bug32922 | |
2022-04-25 10:52 | git | Note Added: 0108138 | |
2022-04-25 10:52 | git | Note Added: 0108139 | |
2022-04-25 10:52 | git | Note Added: 0108140 | |
2022-04-25 10:52 | git | Note Added: 0108141 | |
2022-04-25 10:53 | git | Note Added: 0108142 | |
2022-04-25 11:37 |
|
Assigned To | msv => atereshi |
2022-04-25 11:37 |
|
Status | new => assigned |
2022-04-25 12:43 |
|
Assigned To | atereshi => msv |
2022-04-25 12:43 |
|
Status | assigned => resolved |
2022-04-25 12:43 |
|
Steps to Reproduce Updated | |
2022-04-25 12:43 |
|
Note Added: 0108146 | |
2022-04-25 15:19 | git | Note Added: 0108151 | |
2022-04-25 16:13 | git | Note Added: 0108156 | |
2022-04-25 16:14 | git | Note Added: 0108157 | |
2022-04-25 16:20 | git | Note Added: 0108158 | |
2022-04-27 14:59 |
|
Note Added: 0108225 | |
2022-04-27 15:00 |
|
Assigned To | msv => atereshi |
2022-04-27 15:00 |
|
Status | resolved => assigned |
2022-05-04 13:40 |
|
File Deleted: torus_bug.png | |
2022-05-04 13:40 |
|
File Deleted: torus.stp | |
2022-05-04 14:29 |
|
Description Updated | |
2022-05-04 14:29 |
|
Steps to Reproduce Updated | |
2022-05-04 14:30 |
|
Steps to Reproduce Updated | |
2022-05-04 14:31 |
|
Note Added: 0108302 | |
2022-05-04 14:31 |
|
File Added: torus_wire.png | |
2022-05-04 16:11 |
|
Note Edited: 0108302 | |
2022-05-06 12:03 | git | Note Added: 0108363 | |
2022-05-11 10:25 | git | Note Added: 0108390 | |
2022-05-11 10:26 | git | Note Added: 0108391 | |
2022-05-11 14:04 | git | Note Added: 0108392 | |
2022-05-11 16:47 | git | Note Added: 0108399 | |
2022-05-12 11:28 |
|
Assigned To | atereshi => msv |
2022-05-12 11:28 |
|
Status | assigned => resolved |
2022-05-12 11:28 |
|
Note Added: 0108404 | |
2022-05-20 13:23 |
|
Note Added: 0108512 | |
2022-05-20 13:23 |
|
Assigned To | msv => atereshi |
2022-05-20 13:23 |
|
Status | resolved => assigned |
2022-05-24 11:24 | git | Note Added: 0108576 | |
2022-05-24 11:24 | git | Note Added: 0108577 | |
2022-05-24 11:29 | git | Note Added: 0108578 | |
2022-05-24 11:29 | git | Note Added: 0108579 | |
2022-05-24 11:30 | git | Note Added: 0108580 | |
2022-05-24 14:20 | git | Note Added: 0108587 | |
2022-05-25 20:12 |
|
Assigned To | atereshi => gka |
2022-05-25 20:12 |
|
Status | assigned => resolved |
2022-05-25 20:12 |
|
Note Added: 0108614 | |
2022-05-25 20:13 |
|
Assigned To | gka => msv |
2022-05-26 11:45 |
|
Assigned To | msv => bugmaster |
2022-05-26 11:45 |
|
Status | resolved => reviewed |
2022-05-26 11:45 |
|
Note Added: 0108620 | |
2022-05-28 13:04 |
|
Status | reviewed => tested |
2022-05-28 13:04 |
|
Note Added: 0108682 | |
2022-05-28 13:13 |
|
Test case number | => Not required |
2022-05-28 14:24 |
|
Changeset attached | => occt master 9b9aac4a |
2022-05-28 14:24 |
|
Assigned To | bugmaster => atereshi |
2022-05-28 14:24 |
|
Status | tested => verified |
2022-05-28 14:24 |
|
Resolution | open => fixed |
2022-05-28 15:25 | git | Note Added: 0108696 | |
2023-03-19 19:10 | vglukhik | Status | verified => closed |
2023-03-19 19:10 | vglukhik | Fixed in Version | => 7.6.3 |